Micro-optimizations related to std::string

* Rely on the fact that a std::string is empty by default
* Use std::string::empty() rather than comparing to ""
* Construct with std::string() rather than from ""

Reviewed-by: Bertram

1 files changed, 7 insertions, 6 deletions

diff --git a/src/account-server/storage.cpp b/src/account-server/storage.cpp
index 9d293a37..333f3aaf 100644
--- a/src/account-server/storage.cpp
+++ b/src/account-server/storage.cpp
@@ -1981,12 +1981,13 @@ void Storage::syncDatabase()
                 continue;
 
             int weight = XML::getProperty(node, "weight", 0);
-            std::string type = XML::getProperty(node, "type", "");
-            std::string name = XML::getProperty(node, "name", "");
-            std::string desc = XML::getProperty(node, "description", "");
-            std::string eff  = XML::getProperty(node, "effect", "");
-            std::string image = XML::getProperty(node, "image", "");
-            std::string dye("");
+            std::string type = XML::getProperty(node, "type", std::string());
+            std::string name = XML::getProperty(node, "name", std::string());
+            std::string desc = XML::getProperty(node, "description",
+                                                std::string());
+            std::string eff  = XML::getProperty(node, "effect", std::string());
+            std::string image = XML::getProperty(node, "image", std::string());
+            std::string dye;
 
             // Split image name and dye string
             size_t pipe = image.find("|");