Introduced an AttributeValue class for convenience and readability

Easier to understand than a std::pair with its 'first' and 'second'
members, and it also provides an implicit constructor so that
AttributeValue is implicitly constructed from a double.

Reviewed-by: Freeyorp

1 files changed, 3 insertions, 4 deletions

diff --git a/src/account-server/storage.cpp b/src/account-server/storage.cpp
index 50b131b7..9d293a37 100644
--- a/src/account-server/storage.cpp
+++ b/src/account-server/storage.cpp
@@ -693,11 +693,10 @@ bool Storage::updateCharacter(Character *character)
     // Character attributes.
     try
     {
-        std::ostringstream sqlAttr;
         for (AttributeMap::const_iterator it = character->mAttributes.begin(),
              it_end = character->mAttributes.end(); it != it_end; ++it)
             updateAttribute(character->getDatabaseID(), it->first,
-                            it->second.first, it->second.second);
+                            it->second.base, it->second.modified);
     }
     catch (const dal::DbSqlQueryExecFailure &e)
     {
@@ -998,8 +997,8 @@ void Storage::flush(Account *account)
                      attr_it != attr_end; ++attr_it)
                 {
                     updateAttribute(character->getDatabaseID(), attr_it->first,
-                                    attr_it->second.first,
-                                    attr_it->second.second);
+                                    attr_it->second.base,
+                                    attr_it->second.modified);
                 }
 
                 // Update the characters skill