Age | Commit message (Collapse) | Author | Files | Lines |
|
Selection' or 'Logout'
This is a suggested fix for !188
Squashed with:
* Added new state SWITCH_WORLD. Now everything works correctly.
* As a temporary fix, have 'Change Login' in World Selection Dialog do SWITCH_SERVER instead of SWITCH_LOGIN
* Move 'Switch World' logic from charselectdialog to SWITCH_LOGIN state
* reverting previous commit. State needs to be LOGIN_ATTEMPT, not LOGIN.
* Have 'Switch World' set client state to LOGIN instead of LOGIN_ATTEMPT
Not strictly necesssary, but LOGIN provides some extra sanity checks
before switch to LOGIN_ATTEMPT
* Got it working! Purely from client side, but horribly hacky solution!
* fixing linter issue. Hopefully it works, otherwise might need to make an extra commit
**** mana/verse!191
Reviewed-by: Fedja Beader <fedja@protonmail.ch>
|
|
ManaPlus was apparently forked before Mana 8954a7ca0f70bbf1. However,
running a bulk sed replace was easier than cherry-picking, resolving
14 years of conflicts and then still having to do a bulk sed to catch the rest.
Special thanks to Meway (for attempting to build on windows)
and Bjorn (for pointing to that commit)
****
mana/verse!211
|
|
only about 160 out of 1500 files that include localconsts.h need
to include performance.h
Saves 12% from compile times (with profiler ON) and 0.1% with profiler OFF.
****
mana/plus!189
|
|
call of overloaded 'toString(long long unsigned int)' is ambiguous, see !189
Squashed with:
* Apply perfo[r]mance typofixes that were missed in mana/plus!186
... because USE_PROFILER was off/undefined.
****
mana/plus!200
|
|
- [x] Something needs to be done about that deletion as it may leak memory. Ditto for inputActionReplayListener (for EditDialog)
- [x] Okay, that M+ -> MV rename must be completed to make the linters pass.
Rename was completed and it works, proper cleanup happens in scheduleDelete, so that's not an issue either.
Squashed with:
* Actually fire homun (code was set to only change name, for testing of
replay stuff)
* Clarify my worries
****
mana/plus!109
|
|
.. instead of manaplus's header.
& update copyrights to 2025.
Open problem: should it be "The ManaVerse Client", "the ManaVerse client" or something in between in "This file is part of ..." line? All caps is current situation.
Squashed with:
* update copyright dates for 2025
* Revert "Switch to branch of mplint that checks for manaverse copyright headers"
* Change back to uppercase The
Why? This line was changed 3 times in history and all had an uppercase
The.
PS: ManaVerse has no endorsment from the parent project, ManaPlus.
* Change to "This file is part of the ManaVerse Client"
poppet says 'the' instead of 'The'
find . \( -name "*.h" -o -name "*.cpp" -o -name "*.cc" -o -name "*.inc"
\) -execdir sed -i -e 's/This file is part of The ManaPlus Client/This
file is part of the ManaVerse Client/' {} \+
* Change 'The ManaPlus Client' to 'The ManaVerse Client' in headers
find . \( -name "*.h" -o -name "*.cpp" -o -name "*.cc" -o -name "*.inc"
\) -execdir sed -i -e '2s/ManaPlus/ManaVerse/' {} \+
* Switch to branch of mplint that checks for manaverse copyright headers
.. instead of manaplus's
****
mana/plus!179
|
|
Split off from mana/plus!45: "Rename the program from ManaPlus to ManaVerse."
+POTFILES.in CI fix
****
mana/plus!132
Co-authored-by: Fedja Beader <fedja@protonmail.ch>
|
|
(Fedja) I'm suspecting that some CI will break on this.
Split off from !45: Rename the program from ManaPlus to ManaVerse.
****
mana/plus!135
Co-authored-by: Fedja Beader <fedja@protonmail.ch>
|
|
Split from mana/plus!28 and rebased on master by specing.
****
mana/plus!131
|
|
In theory split out from mana/plus!28, in practice I (specing)
just ran sed myself instead of bothering with splitting out changes.
****
mana/plus!130
|
|
Tile coordinates dance in pairs, so let's pair them up.
also grows exe size by about 3K, hope this will go away when the rest is
converted to Position as well. Note: on my local debug build only. Not on gcc10 CI.
Squashed with:
* Should it be mNavigateDest or mNavigateTo? Hmm, the jury is still out
there ...
****
mana/plus!116
|
|
Addendum to !89 (and !117)
Amusing: putting this line before the .clear() grows the exe by 40 bytes.
****
mana/plus!118
|
|
Memory may not be freed properly, also code is IMO ugly. See !109 for the other way of implementing this (unrelated). Was done in socialWindow as the join confirmation is already there.
****
mana/plus!110
|
|
|
|
|
|
|
|
|
|
|
|
It is annoying and helps nothing.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Clear map not works on software renderer.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Add in debug window new tab with this counters.
|
|
|
|
From some packet version hercules support item id fields as int32.
|
|
|