Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
every time'
No error/warning? odd.
|
|
This has the side effect that now #Debug history is also loaded.
****
mana/plus!84
|
|
Controller improvements
See merge request mana/plus!52
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
****
mana/plus!83
|
|
Saves 1min10s by not compiling and another 15s by moving it together with linters.
Squashed with:
* Make sure mplint internal error or failure to run is detected
* Make mplint breaking cause job to fail
* Move linters out of lightweight.. goes faster, 3m46s -> 1m45s
* Make script fail if any command returns nonzero or if any variable is
unset.
* Donwload mplint instead of building it
****
mana/plus!80
|
|
|
|
What happened:
1) herc evol sends 0x100 as packet ID offset
2) 0x100 is added to 0x0062 of SMSG_CHAR_PASSWORD_RESPONSE
3) SMSG_CHAR_PASSWORD_RESPONSE is then inserted into 0x162
slot of packet map, shadowing SMSG_GUILD_SKILL_INFO
4) on guild lvl-up, server sends this in SMSG_GUILD_SKILL_INFO
5) ManaVerse exits in confusion.
Note 1: due to popupmenu paste not working in change password dialog, tested password change only with invalid old password, which worked (opened error dialog instead of client exiting).
Note 2: Some packet handlers are bound using &Ea::LoginRecv prefix, this one had &LoginRecv and this was kept this way (uses vtable lookup?).
~~TODO: SMSG_CHAR_PASSWORD_RESPONSE seems to be something about password changes, but I could not find this packet either in TMWA or herc. Still, I need to test if these still work on all active servers~~ Tested.
Squashed with:
* Fix exit on password change, too
* Fix guild lvl-up packet parsing causing client exit in ML
****
mana/plus!81
|
|
Problem happens only on Windows that uses \ for path separators and only when primary download location does not contain requested file with requested checksum.
To repro, it should be enough to change one checksum in resources.xml
Report from Manatauro:
![pathjoin](/uploads/4b969168ba7babc21108c1db1a680f66/pathjoin.jpg)
****
mana/plus!82
|
|
|
|
Should this function gain emplace()-like semantics?
|
|
|
|
|
|
See #73 for discussion
Squashed with:
* Fix mana pearl showing in arrows slot in Classic
* Fix off-by-one. Was causing Old Towel to render in torso slot in ML.
****
mana/plus!78
|
|
See manaplus.log in https://git.themanaworld.org/specing/manaplus/-/jobs/168040#L3241
****
mana/plus!72
|
|
Screenshot code didn't take into account scaling setting which resulted in cropped screenshots.
I didn't touch SDL modes because they don't support scaling and I'm not sure how that would be implemented for software render.
****
mana/plus!70
|
|
Tested on classic & ML
See merge request mana/plus!75
****
|
|
|
|
windowmanager.cpp(456, 9): Incorrect align on long parameter list in
front of 'SetClassLongPtr', it should be aligen in column 25.
[RULE_4_1_C_align_long_function_parameter_list]
|
|
Other addButton sections intentionally left misaligned as a test for future fix in nsiqcppstyle.
.. why does it not complain about every such block?
|
|
This is the simpler solution for issue #64 proposed by @bjorn.
`logic()` gets called on every tick after input is processed so I removed redundant code from `keyPressed()`.
* Update login button in logic() instead of keyPressed()
See merge request mana/plus!67
****
Reviewed-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
|
|
|
|
testing the very bleeding edge for every commit everywhere?
Should still be made to run every so often... TODO
|
|
This is the most logical place for it, IMO. I left stage and branch
specifier up top as this decision happens before any image is fetched.
|
|
Continuation of https://git.themanaworld.org/mana/plus/-/merge_requests/68#note_12819
I've renamed `*_HP2` to `*_HP_BG` and updated their descriptions. I didn't touch configuration keys intentionally.
"Renamed *_HP -> *_HP_FG. Also decided to keep descriptions as is or else they become unreadable."
See merge request mana/plus!71
|
|
See merge request mana/plus!63
|
|
+reformat one bit
See merge request mana/plus!61
|
|
See merge request mana/plus!62
|
|
See merge request mana/plus!64
|
|
This MR displays attack range of monsters from ignore attack list in different color. I picked magenta as default, this may be changed if needed.
There are actor types other than monsters but looks like it's not possible to add them to ignore list anyway.
* Flip if branches for readability
* Color setting for attack range of monsters from ignore list
****
|
|
By popular agreement: https://forums.themanaworld.org/viewtopic.php?t=21696
[ci skip]
****
Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
|
|
****
Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
|
|
No server in use still sends that field.
****
Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
|
|
****
Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
|
|
Requested by Ledmitz.
The /undress <player> command remains.
****
Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
|