| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
|
|
Note: in my regular branch the msgmerge or some other part of the build
process wants to rename nl_BE to nl and sv_SE to sv in the .po files,
however no such rename is done on a clean build of this branch.
Part of !45/"Rename the program from ManaPlus to ManaVerse."
**** mana/verse!227
Reviewed-by: Fedja Beader <fedja@protonmail.ch>
|
|
Split off from: "Rename the program from ManaPlus to ManaVerse." /
mana/verse!45
**** mana/verse!222
Reviewed-by: Fedja Beader <fedja@protonmail.ch>
|
|
Carts are Herc(ML)-only, late game stuff and there's already a button to
open cart in inventory window (which should probably be removed as well, or selectively made visible)
Clans, on the other hand, are not implemented by any supported game?
Also, add documentation
**** mana/verse!220
|
|
Checks limited to the common causes of card insertion failure experienced by players.
I've used the opportunity to also get rid of nondescriptive item1, item2 naming.
**** mana/verse!225
|
|
It crashed whenever any button was clicked (except close), as it
attempted to access deleted memory of mMessage.
Now the window titlebar will signal that it is deleted. The user can
still read the message and possibly reply to it.
Note: I opted to retain the mail window around until the player does
something else with it, but the simplest fix for this would be to just
delete/close the mailViewWindow upon deleting its message.
Note: I did not want to bring in <memory> and shared pointers for this,
since it seemed simple enough to do with manual ownership data.
**** mana/verse!217
|
|
Plus update all strings in translations
**** mana/verse!226
|
|
stripped size remains the same, unstripped grows by ~500bytes. Whatever.
**** mana/verse!224
|
|
Cleanup include guards, too.
align the args because it looks better ;)
**** mana/verse!214
|
|
The issues link was wrong, but also worked (missing dash).
**** mana/verse!223
|
|
Introduced in 2012-01-07:"Use absolute path for launching tests."
and not cleaned up in 2012-05-17:"Fix invoking tests. Remove shell script for tests."
**** mana/verse!218
|
|
(Indirectly reported by @Meway - pallete typo elsewhere)
**** mana/verse!219
|
|
Reported by @Meway
|
|
|
|
|
|
Contains the version with just one grid layout, where the scroll area occupies 6 cells, instead of a nested container for buttons. (on Bjorn's advice).
**** mana/verse!215
|
|
downside: these two proxy funcs can no longer be inlined. But, they're
only used by previous/next chat keybinds. Thus, the performance impact should be minimal (if they were even inlined in the first place).
**** mana/verse!216
|
|
**** mana/verse!208
|
|
Maybe a more "proper" fix would be to #define _USE_MATH_DEFINES before including math.h: https://learn.microsoft.com/en-us/cpp/c-runtime-library/math-constants?view=msvc-170
However:
1) SDL rotozoom already does it this way
2) Meway said: There is a way to do it more properly but it doesn't seem that its supported my msys however the above works.
**** mana/verse!209
Co-authored-by: Meway <mewaysid92@gmail.com>
|
|
the components.
**** mana/verse!207
|
|
Addendum to !211
****
mana/verse!212
|
|
Selection' or 'Logout'
This is a suggested fix for !188
Squashed with:
* Added new state SWITCH_WORLD. Now everything works correctly.
* As a temporary fix, have 'Change Login' in World Selection Dialog do SWITCH_SERVER instead of SWITCH_LOGIN
* Move 'Switch World' logic from charselectdialog to SWITCH_LOGIN state
* reverting previous commit. State needs to be LOGIN_ATTEMPT, not LOGIN.
* Have 'Switch World' set client state to LOGIN instead of LOGIN_ATTEMPT
Not strictly necesssary, but LOGIN provides some extra sanity checks
before switch to LOGIN_ATTEMPT
* Got it working! Purely from client side, but horribly hacky solution!
* fixing linter issue. Hopefully it works, otherwise might need to make an extra commit
**** mana/verse!191
Reviewed-by: Fedja Beader <fedja@protonmail.ch>
|
|
****
mana/verse!206
|
|
ManaPlus was apparently forked before Mana 8954a7ca0f70bbf1. However,
running a bulk sed replace was easier than cherry-picking, resolving
14 years of conflicts and then still having to do a bulk sed to catch the rest.
Special thanks to Meway (for attempting to build on windows)
and Bjorn (for pointing to that commit)
****
mana/verse!211
|
|
Previous commit from MR !194 changed requiring password to
requiring char name for confirmation during deletion.
Text input can now be unmasked since user is
entering char name instead of password.
****
mana/plus!205
|
|
CMake way failed to build because main.h uses PACKAGE_NAME.
Reported by bjorn and meway.
Note: I like PROJECT_NAME better, but:
1) Project name is not something that changes at compile time, but
package name might.
2) PROGRAM_VERSION is already set in CMakeLists
NOTE2: earlier I made PACKAGE_EXTENDED_VERSION (used for useragent) and FULL_VERSION (used in GUI & logs) use PACKAGE_NAME, instead of hardcoding ManaVerse, for improved branding.
****
mana/plus!204
Approved-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
|
|
****
mana/plus!203
|
|
Causes Launcher issues otherwise.
When playing from Launcher, the a/c password gets reset to some random string. Deleting character (specifically on TMW) requires password for confirmation, which player no longer has easy access to.
This changes character deletion to require confirming username instead of password.
Squashed with:
* Change to confirm character name instead of username when deleting
* change text 'password' to 'username' in error dialog.
****
mana/plus!194
|
|
Missed this part in mana/plus!186
|
|
only about 160 out of 1500 files that include localconsts.h need
to include performance.h
Saves 12% from compile times (with profiler ON) and 0.1% with profiler OFF.
****
mana/plus!189
|
|
The "move to target in attack range" option in the Quick Settings is not handled correctly. In its current state that option ends up becoming equivalent to "move to target in distance 10".
This is a fix for that.
****
mana/plus!195
|
|
call of overloaded 'toString(long long unsigned int)' is ambiguous, see !189
Squashed with:
* Apply perfo[r]mance typofixes that were missed in mana/plus!186
... because USE_PROFILER was off/undefined.
****
mana/plus!200
|
|
depends on !192
****
mana/plus!197
|
|
Better names. In case of hunger even corrects a bug as it decreases.
****
mana/plus!196
|
|
This brings it inline with how other models are implemented, and also
makes code so much clearer.
****
mana/plus!193
|
|
instead of hardcoding constants.
****
mana/plus!192
|
|
Removes the "ManaPlus" in version info on updater screen;
Screenshots now have ManaVerse in their file name, too
PS: a lot of instances of "ManaVerse" could use PACKAGE_NAME from
configure
PPS: CMake passes PROJECT_NAME. Would need a proxy header with ifdefs.
Split off by Fedja from: Rename the program from ManaPlus to ManaVerse. (!45)
****
mana/plus!198
|
|
- [x] Something needs to be done about that deletion as it may leak memory. Ditto for inputActionReplayListener (for EditDialog)
- [x] Okay, that M+ -> MV rename must be completed to make the linters pass.
Rename was completed and it works, proper cleanup happens in scheduleDelete, so that's not an issue either.
Squashed with:
* Actually fire homun (code was set to only change name, for testing of
replay stuff)
* Clarify my worries
****
mana/plus!109
|
|
(consequence: if localChatTab is nullptr, then the message will go to debug.)
****
mana/plus!187
|
|
Having the widget pop up in the middle of a fight when shooting arrows makes you go below 50% weight is kinda annoying. This changes the notification to a speech bubble on player which is less intrusive.
Squashed with:
* Move messages to top of branch (so they can be integrated to dialog with
fewer changes).
* Adjust overweight message.
* Fix linter issue. Shortened long line
****
mana/plus!184
Co-authored-by: Fedja Beader <fedja@protonmail.ch>
|
|
|
|
libxml2 deprecated __xmlParserVersion() and added a pointer to constant string version in commit
2023-09-20 "globals: Don't store xmlParserVersion in global state"
and added a compat function with it. This commit was made before v2.12.0 was released. Thus, any version *past* unreleased v2.12.0 is guaranteed to have the new API.
The compat function was removed at some point later, causing a compile failure.
****
mana/plus!190
|
|
****
mana/plus!186
|
|
in chat are disabled.
****
mana/plus!185
|
|
launcher users
Pre: 
Post: 
****
mana/plus!183
|
|
.. instead of manaplus's header.
& update copyrights to 2025.
Open problem: should it be "The ManaVerse Client", "the ManaVerse client" or something in between in "This file is part of ..." line? All caps is current situation.
Squashed with:
* update copyright dates for 2025
* Revert "Switch to branch of mplint that checks for manaverse copyright headers"
* Change back to uppercase The
Why? This line was changed 3 times in history and all had an uppercase
The.
PS: ManaVerse has no endorsment from the parent project, ManaPlus.
* Change to "This file is part of the ManaVerse Client"
poppet says 'the' instead of 'The'
find . \( -name "*.h" -o -name "*.cpp" -o -name "*.cc" -o -name "*.inc"
\) -execdir sed -i -e 's/This file is part of The ManaPlus Client/This
file is part of the ManaVerse Client/' {} \+
* Change 'The ManaPlus Client' to 'The ManaVerse Client' in headers
find . \( -name "*.h" -o -name "*.cpp" -o -name "*.cc" -o -name "*.inc"
\) -execdir sed -i -e '2s/ManaPlus/ManaVerse/' {} \+
* Switch to branch of mplint that checks for manaverse copyright headers
.. instead of manaplus's
****
mana/plus!179
|
|
introduced in 8ad99cc3 / "Add profiler lines into some functions."
****
mana/plus!181
|
|
Squashed with:
* Remove TODOs. Repeats and the other two fields are implemented in latest herc, but
they set beingID to 0 when repeats are requested... what...
Repeats need more in-client support to implement, anyways
****
mana/plus!180
|
|
counterparts.
|
