summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2025-07-31Fix: use plural for mail edit window items labelHEADmasterFedja Beader1-1/+1
2025-07-27Fix: center()ing makes no sense before the window dimensions are known.Fedja Beader1-2/+1
2025-07-27Change text domain to manaversejak16-11/+11
Note: in my regular branch the msgmerge or some other part of the build process wants to rename nl_BE to nl and sv_SE to sv in the .po files, however no such rename is done on a clean build of this branch. Part of !45/"Rename the program from ManaPlus to ManaVerse." **** mana/verse!227 Reviewed-by: Fedja Beader <fedja@protonmail.ch>
2025-07-25Miscallaneous rebrandingjak18-14/+14
Split off from: "Rename the program from ManaPlus to ManaVerse." / mana/verse!45 **** mana/verse!222 Reviewed-by: Fedja Beader <fedja@protonmail.ch>
2025-07-24Remove CA(rt) and CL(an) buttons from quick row.Fedja Beader1-2/+4
Carts are Herc(ML)-only, late game stuff and there's already a button to open cart in inventory window (which should probably be removed as well, or selectively made visible) Clans, on the other hand, are not implemented by any supported game? Also, add documentation **** mana/verse!220
2025-07-24Bump GNU_GETTEXT_VERSION 0.16 -> 0.18.2Fedja Beader1-1/+1
Fixes obsolescence warnings: AM_PROG_MKDIR_P, AC_TRY_LINK 0.18.1 still causes warnings. Fixes: ``` configure.ac:250: warning: AM_PROG_MKDIR_P: this macro is deprecated, and will soon be removed. configure.ac:250: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead, configure.ac:250: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files. ./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from... aclocal.m4:1059: AM_PROG_MKDIR_P is expanded from... m4/po.m4:23: AM_PO_SUBDIRS is expanded from... m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from... configure.ac:250: the top level configure.ac:250: warning: The macro 'AC_TRY_LINK' is obsolete. configure.ac:250: You should run autoupdate. ./lib/autoconf/general.m4:2918: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:690: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:697: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... m4/intlmacosx.m4:18: gt_INTL_MACOSX is expanded from... m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from... configure.ac:250: the top level configure.ac:250: warning: The macro 'AC_TRY_LINK' is obsolete. configure.ac:250: You should run autoupdate. ./lib/autoconf/general.m4:2918: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:690: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:697: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from... configure.ac:250: the top level configure.ac:250: warning: The macro 'AC_TRY_LINK' is obsolete. configure.ac:250: You should run autoupdate. ./lib/autoconf/general.m4:2918: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:690: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:697: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... m4/iconv.m4:20: AM_ICONV_LINK is expanded from... m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from... configure.ac:250: the top level configure.ac:250: warning: The macro 'AC_TRY_RUN' is obsolete. configure.ac:250: You should run autoupdate. ./lib/autoconf/general.m4:2995: AC_TRY_RUN is expanded from... lib/m4sugar/m4sh.m4:690: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:697: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... m4/iconv.m4:20: AM_ICONV_LINK is expanded from... m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from... configure.ac:250: the top level configure.ac:250: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged. configure.ac:250: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead, configure.ac:250: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files. ``` TODO: - [x] test translations - on last test before this change, item name translations worked, but there were none for the client itself? - [x] there's no use of mkdir_p in any file. But there are uses in generated files. But no warnings. And a lot of cases of `mkdir_p = $(MKDIR_P)`. No problem? **** mana/verse!213
2025-07-24Add some checks to drag&drop card insertionFedja Beader3-21/+38
Checks limited to the common causes of card insertion failure experienced by players. I've used the opportunity to also get rid of nondescriptive item1, item2 naming. **** mana/verse!225
2025-07-23Fix mail view window crash when interacting on a deleted messageFedja Beader3-1/+31
It crashed whenever any button was clicked (except close), as it attempted to access deleted memory of mMessage. Now the window titlebar will signal that it is deleted. The user can still read the message and possibly reply to it. Note: I opted to retain the mail window around until the player does something else with it, but the simplest fix for this would be to just delete/close the mailViewWindow upon deleting its message. Note: I did not want to bring in <memory> and shared pointers for this, since it seemed simple enough to do with manual ownership data. **** mana/verse!217
2025-07-23Fix string: View mail -> View Mail (english style capitalisation)Fedja Beader42-42/+42
Plus update all strings in translations **** mana/verse!226
2025-07-23Clean up code that does the same as container emptiness check.Fedja Beader1-19/+8
stripped size remains the same, unstripped grows by ~500bytes. Whatever. **** mana/verse!224
2025-07-15Cleanup: setEnv already handles _WIN32 caseFedja Beader1-9/+3
Cleanup include guards, too. align the args because it looks better ;) **** mana/verse!214
2025-07-15Update buster->bullseye; debian buster is now so out of date that it wasFedja Beader1-10/+10
moved to archive servers (hence package management no longer works without interventions) **** mana/verse!221
2025-07-15Update links for mana/plus -> mana/verse project renameFedja Beader4-8/+8
The issues link was wrong, but also worked (missing dash). **** mana/verse!223
2025-07-13Remove unused selfNameFedja Beader2-5/+0
Introduced in 2012-01-07:"Use absolute path for launching tests." and not cleaned up in 2012-05-17:"Fix invoking tests. Remove shell script for tests." **** mana/verse!218
2025-07-13Typofix palete -> paletteFedja Beader8-21/+21
(Indirectly reported by @Meway - pallete typo elsewhere) **** mana/verse!219
2025-07-13Typofix pallete -> description (to match variable name in impl)Fedja Beader1-1/+1
Reported by @Meway
2025-07-12Fix typo overweigth -> overweight reported by MewayFedja Beader1-1/+1
2025-07-12Fix typo recieved -> received. Reported by MewayFedja Beader2-2/+2
2025-07-10Fix mail list window's layout and sizingFedja Beader1-14/+28
Contains the version with just one grid layout, where the scroll area occupies 6 cells, instead of a nested container for buttons. (on Bjorn's advice). **** mana/verse!215
2025-07-10Move browserbox include from ChatTab header to implementationFedja Beader3-8/+26
downside: these two proxy funcs can no longer be inlined. But, they're only used by previous/next chat keybinds. Thus, the performance impact should be minimal (if they were even inlined in the first place). **** mana/verse!216
2025-07-08Fix crash when deleting last mail and then pressing delete againFedja Beader1-0/+7
**** mana/verse!208
2025-07-08Fix: MSYS on Windows has no M_PI?Fedja Beader3-0/+11
Maybe a more "proper" fix would be to #define _USE_MATH_DEFINES before including math.h: https://learn.microsoft.com/en-us/cpp/c-runtime-library/math-constants?view=msvc-170 However: 1) SDL rotozoom already does it this way 2) Meway said: There is a way to do it more properly but it doesn't seem that its supported my msys however the above works. **** mana/verse!209 Co-authored-by: Meway <mewaysid92@gmail.com>
2025-07-08use urljoin() to join URL components / no longer require slashes in one of ↵Fedja Beader1-6/+7
the components. **** mana/verse!207
2025-07-08Change the wrong, but mostly supported WIN64 macro to the correct _WIN64Fedja Beader3-5/+5
Addendum to !211 **** mana/verse!212
2025-07-04Fix 'Switch' Button in Character Selection to automatically become 'World ↵asuratva4-5/+39
Selection' or 'Logout' This is a suggested fix for !188 Squashed with: * Added new state SWITCH_WORLD. Now everything works correctly. * As a temporary fix, have 'Change Login' in World Selection Dialog do SWITCH_SERVER instead of SWITCH_LOGIN * Move 'Switch World' logic from charselectdialog to SWITCH_LOGIN state * reverting previous commit. State needs to be LOGIN_ATTEMPT, not LOGIN. * Have 'Switch World' set client state to LOGIN instead of LOGIN_ATTEMPT Not strictly necesssary, but LOGIN provides some extra sanity checks before switch to LOGIN_ATTEMPT * Got it working! Purely from client side, but horribly hacky solution! * fixing linter issue. Hopefully it works, otherwise might need to make an extra commit **** mana/verse!191 Reviewed-by: Fedja Beader <fedja@protonmail.ch>
2025-07-04clarify that loadPatch() is checkClientVersion() and add commentsFedja Beader2-6/+11
**** mana/verse!206
2025-07-01Change the wrong, but mostly supported WIN32 macro to the correct _WIN32Fedja Beader46-201/+203
ManaPlus was apparently forked before Mana 8954a7ca0f70bbf1. However, running a bulk sed replace was easier than cherry-picking, resolving 14 years of conflicts and then still having to do a bulk sed to catch the rest. Special thanks to Meway (for attempting to build on windows) and Bjorn (for pointing to that commit) **** mana/verse!211
2025-06-27unmask text input during character deletionasuratva1-1/+1
Previous commit from MR !194 changed requiring password to requiring char name for confirmation during deletion. Text input can now be unmasked since user is entering char name instead of password. **** mana/plus!205
2025-06-27Set PACKAGE_NAME in CMakeListsFedja Beader1-1/+2
CMake way failed to build because main.h uses PACKAGE_NAME. Reported by bjorn and meway. Note: I like PROJECT_NAME better, but: 1) Project name is not something that changes at compile time, but package name might. 2) PROGRAM_VERSION is already set in CMakeLists NOTE2: earlier I made PACKAGE_EXTENDED_VERSION (used for useragent) and FULL_VERSION (used in GUI & logs) use PACKAGE_NAME, instead of hardcoding ManaVerse, for improved branding. **** mana/plus!204 Approved-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
2025-06-27Remove unnecessary includes in utils/performance.hFedja Beader1-4/+0
**** mana/plus!203
2025-06-25Change char deletion to require confirming username instead of password. ↵asuratva1-4/+8
Causes Launcher issues otherwise. When playing from Launcher, the a/c password gets reset to some random string. Deleting character (specifically on TMW) requires password for confirmation, which player no longer has easy access to. This changes character deletion to require confirming username instead of password. Squashed with: * Change to confirm character name instead of username when deleting * change text 'password' to 'username' in error dialog. **** mana/plus!194
2025-06-25Typofix perfo[R]mance - in CMakeLists.txt as wellFedja Beader1-2/+2
Missed this part in mana/plus!186
2025-06-25Split #include "utils/performance.h" out of localconsts.hFedja Beader144-14/+179
only about 160 out of 1500 files that include localconsts.h need to include performance.h Saves 12% from compile times (with profiler ON) and 0.1% with profiler OFF. **** mana/plus!189
2025-06-25Add simple compile time output to gcc-10 jobFedja Beader1-1/+1
used to test !189 in particular, but shall be useful in general. **** mana/plus!201
2025-06-24Fix: Move to target in attack rangeasuratva1-0/+1
The "move to target in attack range" option in the Quick Settings is not handled correctly. In its current state that option ends up becoming equivalent to "move to target in distance 10". This is a fix for that. **** mana/plus!195
2025-06-24Fix profiler compileFedja Beader4-11/+14
call of overloaded 'toString(long long unsigned int)' is ambiguous, see !189 Squashed with: * Apply perfo[r]mance typofixes that were missed in mana/plus!186 ... because USE_PROFILER was off/undefined. **** mana/plus!200
2025-06-23Clarify that sort by type also sorts by slotFedja Beader2-4/+4
depends on !192 **** mana/plus!197
2025-06-23Rename Pet/Homun Intimacy->Loyalty & Hunger->SatiationFedja Beader1-4/+4
Better names. In case of hunger even corrects a bug as it decreases. **** mana/plus!196
2025-06-23Use an array of char arrays to store server type list model textsFedja Beader1-15/+17
This brings it inline with how other models are implemented, and also makes code so much clearer. **** mana/plus!193
2025-06-23Move NUM_ELEMENTS() to localconsts and convert some more files to use it ↵Fedja Beader7-9/+8
instead of hardcoding constants. **** mana/plus!192
2025-06-23Rebrand program display name (appName)jak110-17/+20
Removes the "ManaPlus" in version info on updater screen; Screenshots now have ManaVerse in their file name, too PS: a lot of instances of "ManaVerse" could use PACKAGE_NAME from configure PPS: CMake passes PROJECT_NAME. Would need a proxy header with ifdefs. Split off by Fedja from: Rename the program from ManaPlus to ManaVerse. (!45) **** mana/plus!198
2025-06-05Add a confirmation dialog for killing/firing/dismissing your homunculousFedja Beader5-1/+141
- [x] Something needs to be done about that deletion as it may leak memory. Ditto for inputActionReplayListener (for EditDialog) - [x] Okay, that M+ -> MV rename must be completed to make the linters pass. Rename was completed and it works, proper cleanup happens in scheduleDelete, so that's not an issue either. Squashed with: * Actually fire homun (code was set to only change name, for testing of replay stuff) * Clarify my worries **** mana/plus!109
2025-06-05Delay localChatTab nullptr checks in notify() to where they're required & dedupeFedja Beader1-28/+9
(consequence: if localChatTab is nullptr, then the message will go to debug.) **** mana/plus!187
2025-06-05Change overweight notification from widget to speech bubble.asuratva1-0/+18
Having the widget pop up in the middle of a fight when shooting arrows makes you go below 50% weight is kinda annoying. This changes the notification to a speech bubble on player which is less intrusive. Squashed with: * Move messages to top of branch (so they can be integrated to dialog with fewer changes). * Adjust overweight message. * Fix linter issue. Shortened long line **** mana/plus!184 Co-authored-by: Fedja Beader <fedja@protonmail.ch>
2025-06-05Fix my brain malfunctionFedja Beader1-7/+7
2025-06-05fix missing __xmlParserVersion() compat in newer libxml2, spotted by bakaiFedja Beader2-2/+13
libxml2 deprecated __xmlParserVersion() and added a pointer to constant string version in commit 2023-09-20 "globals: Don't store xmlParserVersion in global state" and added a compat function with it. This commit was made before v2.12.0 was released. Thus, any version *past* unreleased v2.12.0 is guaranteed to have the new API. The compat function was removed at some point later, causing a compile failure. **** mana/plus!190
2025-06-04Typofix perfo[R]manceFedja Beader4-17/+17
**** mana/plus!186
2025-06-04Do not show gp / money / zeny pick-up messages in chat when pickup messages ↵Fedja Beader1-2/+12
in chat are disabled. **** mana/plus!185
2025-06-04Remove the blank space left behind with removal of the "Switch" button for ↵Fedja Beader1-14/+7
launcher users Pre: ![empty_space](/uploads/7690f23cf4e77215be90bf3bd0aedb2c/empty_space.png) Post: ![empty_space_000](/uploads/52176bb12c0b542b6aff393cccad44a6/empty_space_000.png) **** mana/plus!183
2025-06-04Rewrite copyright-updating tool to make it more readable and not use ↵Fedja Beader1-13/+15
temporary files add *.in and *.txt and *.sh (the ones missed by existing version) TODO: it rewrites "test.txt" in data/test/test2.txt into two lines of "test line 1" and "test line 2". I don't know why. .. and test copyright update in same MR Squashed with: * Resolve test2.txt mistery **** mana/plus!182
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2025-08-17 05:40:15 +0000