Age | Commit message (Collapse) | Author | Files | Lines |
|
Autoconf manual states that CXXFLAGS is a user variable and should not
be overriden, so I did not use AX_APPEND_COMPILE_FLAGS for this. Thus,
there are not checks if the compiler supports it, but also the builder can
override this flag by passing another flag that overrides it on the
command line. Okay, this is now way too theoretical.
Indeed, the override happens with ./configure 'CXXFLAGS=-std=c++17'
(both flags in final command line)
Do note:
- The standard has not explicitly set for some builds (thus compiler
default was used)
- The default on my own box is C++17
- I'm setting C++11 as that's required by my previous change. Upgrade to
C++17 is deferred to until it becomes required.
- The use of CPPFLAGS could be reviewed... they may be used incorrectly
(instead of CXXFLAGS).
|
|
Tile coordinates dance in pairs, so let's pair them up.
also grows exe size by about 3K, hope this will go away when the rest is
converted to Position as well. Note: on my local debug build only. Not on gcc10 CI.
Squashed with:
* Should it be mNavigateDest or mNavigateTo? Hmm, the jury is still out
there ...
****
mana/plus!116
|
|
line-length limits.
Introduced in mana/plus!88
and exposed in mana/plus!126
Pushing directly to master from top of !126 before merging 126.
|
|
Addendum to !89 (and !117)
Amusing: putting this line before the .clear() grows the exe by 40 bytes.
****
mana/plus!118
|
|
****
mana/plus!119
|
|
****
mana/plus!120
|
|
Pointless change, I know.
****
mana/plus!115
|
|
****
mana/plus!113
|
|
****
mana/plus!114
|
|
Further idea: a lot of these models are wrappers around a string options array. Maybe convert the classes into a single template class taking an array parameter?
****
mana/plus!111
Approved-by: Led Mitz <smoothshifter@tuta.io>
|
|
description/tooltip.
****
mana/plus!105
|
|
****
mana/plus!104
|
|
Memory may not be freed properly, also code is IMO ugly. See !109 for the other way of implementing this (unrelated). Was done in socialWindow as the join confirmation is already there.
****
mana/plus!110
|
|
Curiously, this increases -g -O2 exe size by 96 bytes, but disassembly
dump around this code is the same (redundant check was already optimised out?)
****
mana/plus!106
|
|
use @toevent, then switch character (and stay on character screen).
Thread 1 "manaplus" received signal SIGSEGV, Segmentation fault.
0x.. in Game::getCurrentMap (this=<optimized out>) at ./game.h:108
108 { return mCurrentMap; }
(gdb) bt
0x.. in Game::getCurrentMap (this=<optimized out>) at ./game.h:108
Ea::PlayerRecv::processMapMask (msg=...) at net/ea/playerrecv.cpp:242
****
mana/plus!108
|
|
Adds a light blue bar for MP below player's HP bar. It shows only if M.Atk is above 0.
I didn't add a checkbox to the settings to disable this, let me know if I should.
Squashed with:
* Sneak in another TODO
* Sneak in a TODO
****
mana/plus!68
Co-authored-by: Fedja Beader <fedja@protonmail.ch>
|
|
Move to target & move to target type intentionally kept in basic's targetting section.
****
mana/plus!103
|
|
work for ML
Squashed with:
* Sync with last comment (Evol->Evol2)
* Another rename, to reflect TMW->Manasource rebrand (maybe?)
****
mana/plus!79
|
|
Split from mana/plus!79
|
|
Shaves some bytes from exe, too
****
mana/plus!102
|
|
TODO: are all these casts actually required? SMH
****
mana/plus!101
|
|
****
mana/plus!96
|
|
Squashed with:
* Appease linters + more reformat
* Further improve skill error handling and messages.
24751878 "Improve skill error messages." added trailing dots only on the
second branch. This adds missing dots on the first one as well as
compacts the logic.
****
mana/plus!93
|
|
& shaves ~5KB from debug binary.
previd=""; while read -r line; do if [[ $line =~ .*"msg.read"[^\"]*"\""([^\"]*).* ]]; then id="${BASH_REMATCH[1]}"; if [[ "$id" == "$previd" ]]; then printf "%s\n" "$line"; fi; previd="$id"; fi; done < <(grep -r 'msg.read.*' src/net/)
****
mana/plus!91
|
|
* Run gcc8 job again in this MR
* Squash the %c strftime gcc warning
****
mana/plus!100
|
|
Server does not communicate sent time.. or it did, until 2017 ??
See src/map/clif.c #if PACKETVER >= 20170419
The RODEX_EXPIRY constant seems not to be communicated either,
preventing us from deducing send time from expiry time.
****
mana/plus!90
|
|
if any, are worth it.
In fact, this might even save some time. Calculating distance may be
faster than iterating through memory twice.
****
mana/plus!95
|
|
****
mana/plus!94
|
|
How to reproduce: spam emote then quickly switch char
Thread 1 "manaplus" received signal SIGSEGV, Segmentation fault.
SkillDialog::getSkill (this=0x0, id=id@entry=1) at gui/windows/skilldialog.cpp:805
0 SkillDialog::getSkill (this=0x0, id=id@entry=1) at gui/windows/skilldialog.cpp:805
1 EAthena::SkillRecv::processSkillFailed (msg=...) at net/eathena/skillrecv.cpp:302
...
****
mana/plus!92
|
|
g
****
mana/plus!77
|
|
****
mana/plus!88
|
|
|
|
|
|
raise default (5->100).
|
|
|
|
Addendum to cbab9d6d "Fix for login button"
See also mana/plus!67 and mana/plus#64
****
mana/plus!86
|
|
This has the side effect that now #Debug history is also loaded.
****
mana/plus!84
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|