diff options
| author | Fedja Beader <fedja@protonmail.ch> | 2023-05-02 16:51:22 +0200 |
|---|---|---|
| committer | Fedja Beader <fedja@protonmail.ch> | 2023-08-10 18:06:13 +0200 |
| commit | 4991dbeaad702f307c9b108fc6c1c91d70c1ce91 (patch) | |
| tree | 92439aa05d55a1fe49078f23a1e5fc3fcd61f147 /README-SWITCH.md | |
| parent | 4936c4353089b4c2542741a153ed6106606b12d3 (diff) | |
| download | manaplus-pickupignoredfix.tar.gz manaplus-pickupignoredfix.tar.bz2 manaplus-pickupignoredfix.tar.xz manaplus-pickupignoredfix.zip | |
Fix unable to pickup non-ignored items while standing on an ignoredpickupignoredfix
item.
What happened:
1) The pickup code first tries to pickup first item under you without
checking if it is ignored.
2) ::pickUp queries ratelimiter, which clears to send.
3) ::pickUp checks if item is ignored and bails out
4) The pickup code did not bail early, despite "success" of (1) and
selects a non-ignored item to pick-up.
5) ::pickUp queries ratelimiter, which thinks that a packet has been
sent in (2) and aborts.
Diffstat (limited to 'README-SWITCH.md')
0 files changed, 0 insertions, 0 deletions