diff options
| author | Fedja Beader <fedja@protonmail.ch> | 2025-02-12 00:47:09 +0100 |
|---|---|---|
| committer | Fedja Beader <fedja@protonmail.ch> | 2025-02-12 00:50:46 +0100 |
| commit | 8c4e666b867df80af088c7f80798d7963f658163 (patch) | |
| tree | 537cb5bd97f5b7f33eceff70fbb3607d7a81e847 | |
| parent | b86071ad388553171aa22558baffdf5adc9df02b (diff) | |
| download | evol-hercules-remove_unnecessary_nullptr_check.tar.gz evol-hercules-remove_unnecessary_nullptr_check.tar.bz2 evol-hercules-remove_unnecessary_nullptr_check.tar.xz evol-hercules-remove_unnecessary_nullptr_check.zip | |
Fix "warning: the comparison will always evaluate as 'true' for the address of 'data' will never be NULL [-Waddress]"remove_unnecessary_nullptr_check
sc.data might be an empty array, but even then it's a valid pointer.
Might be better to check if SC_BOTTER_SYNDROME < SC_MAX, but that should
be an assert someplace else? Depending on how this extra SC mechanics
work (did not look).
| -rw-r--r-- | src/emap/mob.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/emap/mob.c b/src/emap/mob.c index 81f8435..38bf507 100644 --- a/src/emap/mob.c +++ b/src/emap/mob.c @@ -348,7 +348,7 @@ int emob_dead_pre(struct mob_data **mdPtr, // If Botter Syndrome is active, mob may randomly get NODROP // Aka *typePtr |= 1 struct map_session_data *sd = BL_CAST(BL_PC, *srcPtr); - if (sd && sd->sc.data && sd->sc.data[SC_BOTTER_SYNDROME]) { + if (sd && sd->sc.data[SC_BOTTER_SYNDROME]) { if (rnd()%100 < sd->sc.data[SC_BOTTER_SYNDROME]->val1) *typePtr = *typePtr | 1; } |