summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrei Karas <akaras@inbox.ru>2018-02-08 22:39:28 +0300
committerAndrei Karas <akaras@inbox.ru>2018-02-09 02:40:22 +0300
commitec45eda62ff8bd9dd25a05bb3fb175d0ba08d364 (patch)
treee673a1f8f81b60ebbec79c6c81c319479fa91d73
parentcba1ab982443012191947beac493259b71af21c3 (diff)
downloadhercules-s20180215.tar.gz
hercules-s20180215.tar.bz2
hercules-s20180215.tar.xz
hercules-s20180215.zip
Fix different clan issues.s20180215
Add missing online check for clan members. Clean sd pointer after clan member went offline.
-rw-r--r--src/map/clan.c5
-rw-r--r--src/map/clif.c2
2 files changed, 5 insertions, 2 deletions
diff --git a/src/map/clan.c b/src/map/clan.c
index b67726b37..6855e449d 100644
--- a/src/map/clan.c
+++ b/src/map/clan.c
@@ -103,7 +103,7 @@ struct map_session_data *clan_getonlinesd(struct clan *c)
int i;
nullpo_retr(NULL, c);
- ARR_FIND(0, VECTOR_LENGTH(c->members), i, VECTOR_INDEX(c->members, i).sd != NULL);
+ ARR_FIND(0, VECTOR_LENGTH(c->members), i, (VECTOR_INDEX(c->members, i).sd != NULL && VECTOR_INDEX(c->members, i).online == 1));
return (i < VECTOR_LENGTH(c->members)) ? VECTOR_INDEX(c->members, i).sd : NULL;
}
@@ -294,6 +294,7 @@ void clan_member_online(struct map_session_data *sd, bool first)
if (c->kick_time > 0 && inactivity > c->kick_time) {
if (m->online == 1) {
m->online = 0;
+ m->sd = NULL;
c->connect_member--;
c->member_count--;
}
@@ -306,6 +307,7 @@ void clan_member_online(struct map_session_data *sd, bool first)
return;
}
+ m->sd = sd;
m->online = 1;
m->last_login = sd->status.last_login;
}
@@ -403,6 +405,7 @@ void clan_member_offline(struct map_session_data *sd)
if (i != INDEX_NOT_FOUND && VECTOR_INDEX(c->members, i).online == 1) {
// Only if it is online, because unit->free is called twice
VECTOR_INDEX(c->members, i).online = 0;
+ VECTOR_INDEX(c->members, i).sd = NULL;
c->connect_member--;
}
clif->clan_onlinecount(c);
diff --git a/src/map/clif.c b/src/map/clif.c
index 8adb1ae58..ea239ba21 100644
--- a/src/map/clif.c
+++ b/src/map/clif.c
@@ -673,7 +673,7 @@ bool clif_send(const void* buf, int len, struct block_list* bl, enum send_target
nullpo_retr(false, c);
for (i = 0; i < VECTOR_LENGTH(c->members); i++) {
- if ((sd = VECTOR_INDEX(c->members, i).sd) == NULL || (fd = sd->fd) <= 0)
+ if (VECTOR_INDEX(c->members, i).online == 0 || (sd = VECTOR_INDEX(c->members, i).sd) == NULL || (fd = sd->fd) <= 0)
continue;
WFIFOHEAD(fd, len);
memcpy(WFIFOP(fd, 0), buf, len);