Fix false positive for ADDR_EXPR node.

Ignored example: arr.push_back(ptr);

1 files changed, 16 insertions, 0 deletions

diff --git a/src/analysis/expression.cpp b/src/analysis/expression.cpp
index c3fb050..a31f78f 100644
--- a/src/analysis/expression.cpp
+++ b/src/analysis/expression.cpp
@@ -28,6 +28,7 @@
 
 #include "nodes/expr/addr_expr.h"
 #include "nodes/expr/bind_expr.h"
+#include "nodes/expr/call_expr.h"
 #include "nodes/expr/compound_expr.h"
 #include "nodes/expr/cond_expr.h"
 #include "nodes/expr/decl_expr.h"
@@ -83,6 +84,21 @@ void analyseAddrExpr(AddrExprNode *node, const WalkItem &wi, WalkItem &wo)
     if (node->args.empty() || command == FindArgs)
         return;
 
+    // do not report code like func1(ptr) or push_back(ptr)
+    Node *node2 = skipBackNop(node->parent);
+    if (node2)
+    {
+        while (node2 && node2->nodeType == ADDR_EXPR)
+        {
+            node2 = skipBackNop(node2->parent);
+        }
+        // found what some parent is function or method call
+        if (node2 && node2->nodeType == CALL_EXPR)
+        {
+            return;
+        }
+    }
+
     reportParmDeclNullPointer(node, node->args[0], wi);
 }