Add checks for public:/protected:/private: formatting.

6 files changed, 300 insertions, 0 deletions

diff --git a/tests/testsrc/bad/formatting.cpp b/tests/testsrc/bad/formatting.cpp
new file mode 100644
index 0000000..2f0bda5
--- /dev/null
+++ b/tests/testsrc/bad/formatting.cpp
@@ -0,0 +1,51 @@
+/*
+ *  The ManaPlus Client
+ *  Copyright (C) 2014  The ManaPlus Developers
+ *
+ *  This file is part of The ManaPlus Client.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "lintmanager.h"
+
+#include "debug.h"
+
+class Test1 final
+{
+public:
+    Test1::Test1()
+    {
+    }
+}
+
+struct Test2 final
+{
+protected:
+    Test2::Test2() :
+        data1(),
+        data2()
+    {
+    }
+}
+
+struct Test3 final
+{
+        private:
+    Test3::Test3() :
+        data1(),
+        data2()
+    {
+    }
+}
diff --git a/tests/testsrc/bad/formatting.h b/tests/testsrc/bad/formatting.h
new file mode 100644
index 0000000..086e1f7
--- /dev/null
+++ b/tests/testsrc/bad/formatting.h
@@ -0,0 +1,49 @@
+/*
+ *  The ManaPlus Client
+ *  Copyright (C) 2014  The ManaPlus Developers
+ *
+ *  This file is part of The ManaPlus Client.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "lintmanager.h"
+
+class Test1 final
+{
+public:
+    Test1::Test1()
+    {
+    }
+}
+
+struct Test2 final
+{
+     protected:
+    Test2::Test2() :
+        data1(),
+        data2()
+    {
+    }
+}
+
+struct Test3 final
+{
+ private:
+    Test3::Test3() :
+        data1(),
+        data2()
+    {
+    }
+}
diff --git a/tests/testsrc/bad/formatting2.cpp b/tests/testsrc/bad/formatting2.cpp
new file mode 100644
index 0000000..ccf6e86
--- /dev/null
+++ b/tests/testsrc/bad/formatting2.cpp
@@ -0,0 +1,50 @@
+/*
+ *  The ManaPlus Client
+ *  Copyright (C) 2010  The Mana Developers
+ *  Copyright (C) 2011-2014  The ManaPlus Developers
+ *
+ *  This file is part of The ManaPlus Client.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "debug.h"
+
+namespace
+{
+    static class SortPartyFunctor final
+    {
+         public:
+            bool operator() (const PartyMember *const p1,
+                             const PartyMember *const p2) const
+            {
+                if (!p1 || !p2)
+                    return false;
+                if (p1->getLeader())
+                    return true;
+                if (p2->getLeader())
+                    return false;
+
+                if (p1->getName() != p2->getName())
+                {
+                    std::string s1 = p1->getName();
+                    std::string s2 = p2->getName();
+                    toLower(s1);
+                    toLower(s2);
+                    return s1 < s2;
+                }
+                return false;
+            }
+    } partySorter;
+}  // namespace
diff --git a/tests/testsrc/good/formatting.cpp b/tests/testsrc/good/formatting.cpp
new file mode 100644
index 0000000..2819d56
--- /dev/null
+++ b/tests/testsrc/good/formatting.cpp
@@ -0,0 +1,51 @@
+/*
+ *  The ManaPlus Client
+ *  Copyright (C) 2014  The ManaPlus Developers
+ *
+ *  This file is part of The ManaPlus Client.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "lintmanager.h"
+
+#include "debug.h"
+
+class Test1 final
+{
+    public:
+        Test1::Test1()
+        {
+        }
+}
+
+struct Test2 final
+{
+    protected:
+        Test2::Test2() :
+            data1(),
+            data2()
+        {
+        }
+}
+
+struct Test3 final
+{
+    private:
+        Test3::Test3() :
+            data1(),
+            data2()
+        {
+        }
+}
diff --git a/tests/testsrc/good/formatting.h b/tests/testsrc/good/formatting.h
new file mode 100644
index 0000000..df123d2
--- /dev/null
+++ b/tests/testsrc/good/formatting.h
@@ -0,0 +1,49 @@
+/*
+ *  The ManaPlus Client
+ *  Copyright (C) 2014  The ManaPlus Developers
+ *
+ *  This file is part of The ManaPlus Client.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "lintmanager.h"
+
+class Test1 final
+{
+    public:
+        Test1::Test1()
+        {
+        }
+}
+
+struct Test2 final
+{
+    protected:
+        Test2::Test2() :
+            data1(),
+            data2()
+        {
+        }
+}
+
+struct Test3 final
+{
+    private:
+        Test3::Test3() :
+            data1(),
+            data2()
+        {
+        }
+}
diff --git a/tests/testsrc/good/formatting2.cpp b/tests/testsrc/good/formatting2.cpp
new file mode 100644
index 0000000..e790ade
--- /dev/null
+++ b/tests/testsrc/good/formatting2.cpp
@@ -0,0 +1,50 @@
+/*
+ *  The ManaPlus Client
+ *  Copyright (C) 2010  The Mana Developers
+ *  Copyright (C) 2011-2014  The ManaPlus Developers
+ *
+ *  This file is part of The ManaPlus Client.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "debug.h"
+
+namespace
+{
+    static class SortPartyFunctor final
+    {
+        public:
+            bool operator() (const PartyMember *const p1,
+                             const PartyMember *const p2) const
+            {
+                if (!p1 || !p2)
+                    return false;
+                if (p1->getLeader())
+                    return true;
+                if (p2->getLeader())
+                    return false;
+
+                if (p1->getName() != p2->getName())
+                {
+                    std::string s1 = p1->getName();
+                    std::string s2 = p2->getName();
+                    toLower(s1);
+                    toLower(s2);
+                    return s1 < s2;
+                }
+                return false;
+            }
+    } partySorter;
+}  // namespace