diff options
-rw-r--r-- | src/game-server/skillmanager.cpp | 9 | ||||
-rw-r--r-- | src/game-server/skillmanager.hpp | 2 |
2 files changed, 5 insertions, 6 deletions
diff --git a/src/game-server/skillmanager.cpp b/src/game-server/skillmanager.cpp index ccf15923..4d262a4a 100644 --- a/src/game-server/skillmanager.cpp +++ b/src/game-server/skillmanager.cpp @@ -102,17 +102,16 @@ void SkillManager::reload() } } -int SkillManager::getIdFromString(std::string name) +int SkillManager::getIdFromString(const std::string &name) { //check if already an integer, if yes just return it int val; val = atoi(name.c_str()); - if (val) return val; + if (val) + return val; // convert to upper case for easier finding - name = utils::toupper(name); - // find it - SkillMap::iterator i = skillMap.find(name); + SkillMap::iterator i = skillMap.find(utils::toupper(name)); if (i == skillMap.end()) { return 0; diff --git a/src/game-server/skillmanager.hpp b/src/game-server/skillmanager.hpp index 6c8b2c0b..c6a73a5c 100644 --- a/src/game-server/skillmanager.hpp +++ b/src/game-server/skillmanager.hpp @@ -40,7 +40,7 @@ namespace SkillManager * Gets the skill ID of a skill string * (not case-sensitive to reduce wall-bashing) */ - int getIdFromString(std::string name); // no, thorbjorn, I am not passing this as const reference. I need a local copy. + int getIdFromString(const std::string &name); } |