Micro-optimizations related to std::string

* Rely on the fact that a std::string is empty by default
* Use std::string::empty() rather than comparing to ""
* Construct with std::string() rather than from ""

Reviewed-by: Bertram

1 files changed, 5 insertions, 5 deletions

diff --git a/src/utils/stringfilter.cpp b/src/utils/stringfilter.cpp
index 617da90d..b48d267f 100644
--- a/src/utils/stringfilter.cpp
+++ b/src/utils/stringfilter.cpp
@@ -43,13 +43,13 @@ bool StringFilter::loadSlangFilterList()
 {
     mInitialized = false;
 
-    std::string slangsList = Configuration::getValue("SlangsList", "");
-    if (slangsList != "") {
+    const std::string slangsList = Configuration::getValue("SlangsList",
+                                                           std::string());
+    if (!slangsList.empty()) {
         std::istringstream iss(slangsList);
         std::string tmp;
-        while (getline(iss, tmp, ',')) {
+        while (getline(iss, tmp, ','))
             mSlangs.push_back(tmp);
-        }
         mInitialized = true;
     }
 
@@ -59,7 +59,7 @@ bool StringFilter::loadSlangFilterList()
 void StringFilter::writeSlangFilterList()
 {
     // Write the list to config
-    std::string slangsList = "";
+    std::string slangsList;
     for (SlangIterator i = mSlangs.begin(); i != mSlangs.end(); )
     {
         slangsList += *i;