Fixed problems with map-bound world state variables

Due to a wrong primary key, which covered only the state name, it was
impossible to use the same state name on different maps. This has now
been fixed.

Another problem was that the map variables were being included in the
global variables, because the related database query did not filter on
the map_id column properly. While fixing that, the map_id column now
allows explicitly marking a state variable as global (with the value 0)
or system variables (with the value -1).

System variables are currently not accessible from scripts, but that
could be changed later.

Reviewed-by: Yohann Ferreira
Reviewed-by: Erik Schilling

1 files changed, 3 insertions, 3 deletions

diff --git a/src/sql/mysql/createTables.sql b/src/sql/mysql/createTables.sql
index a48644b3..dc405d95 100644
--- a/src/sql/mysql/createTables.sql
+++ b/src/sql/mysql/createTables.sql
@@ -278,10 +278,10 @@ DEFAULT CHARSET=utf8;
 CREATE TABLE IF NOT EXISTS mana_world_states
 (
    state_name   varchar(100)NOT NULL,
-   map_id       INTEGER     NULL,
-   value        TEXT        NULL,
+   map_id       INTEGER     NOT NULL,
+   value        TEXT        NOT NULL,
    moddate      INTEGER     NOT NULL,
-   PRIMARY KEY (`state_name`)
+   PRIMARY KEY (`state_name`, `map_id`)
 );
 
 --