Allowed to push attributeinfos for the attribute recalculation

While on it I replaced the id usage in the server with the usage of the
AttributeInfo directly.

Next steps:
 - Dehardcode the core attribute ids and store their
   attributeinfos somewhere in AttributeManager (for now i simply
   wrapped the ids with getAttributeInfo().
 - Move AttributeInfo out of AttributeManager to shorten the usage + to
   allow using a pointer in ModifierLocation without forward declaring
   it.

1 files changed, 5 insertions, 5 deletions

diff --git a/src/game-server/monster.cpp b/src/game-server/monster.cpp
index 41a69ecb..cf589977 100644
--- a/src/game-server/monster.cpp
+++ b/src/game-server/monster.cpp
@@ -51,9 +51,9 @@ MonsterComponent::MonsterComponent(Entity &entity, MonsterClass *specy):
      */
     auto *beingComponent = entity.getComponent<BeingComponent>();
 
-    for (auto attrInfo : attributeManager->getAttributeScope(MonsterScope))
+    for (auto attribute : attributeManager->getAttributeScope(MonsterScope))
     {
-        beingComponent->createAttribute(attrInfo.first, attrInfo.second);
+        beingComponent->createAttribute(attribute);
     }
 
     /*
@@ -63,15 +63,15 @@ MonsterComponent::MonsterComponent(Entity &entity, MonsterClass *specy):
 
     int mutation = specy->getMutation();
 
-    for (auto &attribute : specy->getAttributes())
+    for (auto &attributeIt : specy->getAttributes())
     {
-        double attributeValue = attribute.second;
+        double attributeValue = attributeIt.second;
         if (mutation != 0)
         {
             double factor = 100 + (rand() % (mutation * 2)) - mutation;
             attributeValue = attributeValue * factor / 100.0;
         }
-        beingComponent->setAttribute(entity, attribute.first->id,
+        beingComponent->setAttribute(entity, attributeIt.first,
                                      attributeValue);
     }