Return a const & from NameMap to avoid potential deep copies

When I introduced NameMap it was only used with pointers, but now it is
also used with std::string so it probably makes sense to keep a default-
constructed value around so that a reference can be returned rather than
a copy.

NameMap::find was renamed to NameMap::value to make it more clear that
it doesn't return an iterator, like std::map::find.

Reviewed-by: Yohann Ferreira
Reviewed-by: Ben Longbons

1 files changed, 2 insertions, 2 deletions

diff --git a/src/game-server/map.h b/src/game-server/map.h
index eca36863..28faed7f 100644
--- a/src/game-server/map.h
+++ b/src/game-server/map.h
@@ -80,8 +80,8 @@ class MapObject
                 mProperties.insert(key, value);
         }
 
-        std::string getProperty(const std::string &key) const
-        { return mProperties.find(key); }
+        const std::string &getProperty(const std::string &key) const
+        { return mProperties.value(key); }
 
         const std::string &getName() const
         { return mName; }