Fixed the crash in setupSpriteDisplay

This happened when an NPC, monster or item couldn't be found and it had
to fall back on Being::Unknown. This instance was bugged since it had a
0 pointer in its sprites list, because when the Being::Unknown was
created, the SpriteDef::Empty was not initialized yet (since both were
global static variables, the initialization order was not well
defined).

Fixed it by removing SpriteDef::Empty and instead creating it in the
BeingInfo constructor. I've also changed the SpriteReference instances
to be inline values rather than instances on the heap, since they're
quite small. That also fixed a leak since those instances were never
getting deleted.

Reviewed-by: Yohann Ferreira

1 files changed, 3 insertions, 3 deletions

diff --git a/src/resources/npcdb.cpp b/src/resources/npcdb.cpp
index ec22c225..44875655 100644
--- a/src/resources/npcdb.cpp
+++ b/src/resources/npcdb.cpp
@@ -73,9 +73,9 @@ void NPCDB::load()
         {
             if (xmlStrEqual(spriteNode->name, BAD_CAST "sprite"))
             {
-                SpriteReference *currentSprite = new SpriteReference;
-                currentSprite->sprite = (const char*)spriteNode->xmlChildrenNode->content;
-                currentSprite->variant = XML::getProperty(spriteNode, "variant", 0);
+                SpriteReference currentSprite;
+                currentSprite.sprite = (const char*)spriteNode->xmlChildrenNode->content;
+                currentSprite.variant = XML::getProperty(spriteNode, "variant", 0);
                 display.sprites.push_back(currentSprite);
             }
             else if (xmlStrEqual(spriteNode->name, BAD_CAST "particlefx"))