Replace most dynamic_casts with static_casts

The remaining instances can't easily or safely be changed as the classes
involved don't have type information like Being does.

Reviewed-by: Freeyorp

1 files changed, 10 insertions, 3 deletions

diff --git a/src/gui/statuswindow.cpp b/src/gui/statuswindow.cpp
index 7312078e..498a4523 100644
--- a/src/gui/statuswindow.cpp
+++ b/src/gui/statuswindow.cpp
@@ -46,7 +46,12 @@
 class AttrDisplay : public Container
 {
     public:
+        enum Type {
+            DERIVED, CHANGEABLE, UNKNOWN
+        };
+
         virtual std::string update();
+        virtual Type getType() { return UNKNOWN; }
 
     protected:
         AttrDisplay(int id, const std::string &name);
@@ -63,6 +68,7 @@ class DerDisplay : public AttrDisplay
 {
     public:
         DerDisplay(int id, const std::string &name);
+        virtual Type getType() { return DERIVED; }
 };
 
 class ChangeDisplay : public AttrDisplay, gcn::ActionListener
@@ -70,6 +76,7 @@ class ChangeDisplay : public AttrDisplay, gcn::ActionListener
     public:
         ChangeDisplay(int id, const std::string &name);
         std::string update();
+        virtual Type getType() { return CHANGEABLE; }
         void setPointsNeeded(int needed);
 
     private:
@@ -269,9 +276,9 @@ void StatusWindow::setPointsNeeded(int id, int needed)
 
     if (it != mAttrs.end())
     {
-        ChangeDisplay *disp = dynamic_cast<ChangeDisplay*>(it->second);
-        if (disp)
-            disp->setPointsNeeded(needed);
+        AttrDisplay *disp = it->second;
+        if (disp->getType() == AttrDisplay::CHANGEABLE)
+            static_cast<ChangeDisplay*>(disp)->setPointsNeeded(needed);
     }
 }