Some cleanups in UpdaterWindow and BrowserBox

Doing some cleanups before working towards optimizing this code.

Removed needless additional wrapping code in BrowserBox::addRow, since
the text will be relayouted anyway.

Simplified layouting code a little. For example, there's no need to keep
track of the number of wrapped lines.

Use more optimal data structures, like an std::deque for the text rows
and a plain std::vector for the line parts. Both have less fragmentation
than an std::list.

1 files changed, 8 insertions, 9 deletions

diff --git a/src/gui/updaterwindow.h b/src/gui/updaterwindow.h
index 6c69cd9b..2d1b059b 100644
--- a/src/gui/updaterwindow.h
+++ b/src/gui/updaterwindow.h
@@ -39,14 +39,13 @@ class Button;
 class ProgressBar;
 class ScrollArea;
 
-struct updateFile
+struct UpdateFile
 {
-    public:
-        std::string name;
-        std::string hash;
-        std::string type;
-        bool required;
-        std::string desc;
+    std::string name;
+    std::string hash;
+    std::string type;
+    bool required;
+    std::string desc;
 };
 
 /**
@@ -76,7 +75,7 @@ class UpdaterWindow : public Window, public gcn::ActionListener,
     /**
      * Set's progress bar status
      */
-    void setProgress(float p);
+    void setProgress(float progress);
 
     /**
      * Set's label above progress
@@ -176,7 +175,7 @@ private:
     Net::Download *mDownload = nullptr;
 
     /** List of files to download. */
-    std::vector<updateFile> mUpdateFiles;
+    std::vector<UpdateFile> mUpdateFiles;
 
     /** Index of the file to be downloaded. */
     unsigned int mUpdateIndex = 0;