General code cleanups

* Use final for all message handlers, Client, LocalPlayer,
  Being::getType, Being::setPosition and Being::setMap.
  (avoids some warnings about virtual dispatch in constructors)
* Use auto in more places
* Use emplace_back instead of push_back in some places
* Use default member initializers
* Less else after return
* Removed superfluous .c_str()
* Removed type aliases that are only used once
* Removed more unused includes

1 files changed, 2 insertions, 13 deletions

diff --git a/src/client.cpp b/src/client.cpp
index 15ebcf96..df360d17 100644
--- a/src/client.cpp
+++ b/src/client.cpp
@@ -179,18 +179,7 @@ Client *Client::mInstance = nullptr;
 
 Client::Client(const Options &options):
     mOptions(options),
-    mGame(nullptr),
-    mCurrentDialog(nullptr),
-    mQuitDialog(nullptr),
-    mDesktop(nullptr),
-    mSetupButton(nullptr),
-    mState(STATE_CHOOSE_SERVER),
-    mOldState(STATE_START),
-    mStateAfterOkDialog(mState),
-    mIcon(nullptr),
-    mLogicCounterId(0),
-    mSecondsCounterId(0),
-    mLimitFps(false)
+    mStateAfterOkDialog(mState)
 {
     assert(!mInstance);
     mInstance = this;
@@ -682,7 +671,7 @@ int Client::exec()
                     {
                         Worlds worlds = Net::getLoginHandler()->getWorlds();
 
-                        if (worlds.size() == 0)
+                        if (worlds.empty())
                         {
                             // Trust that the netcode knows what it's doing
                             mState = STATE_UPDATE;