General code cleanups

* Use final for all message handlers, Client, LocalPlayer,
  Being::getType, Being::setPosition and Being::setMap.
  (avoids some warnings about virtual dispatch in constructors)
* Use auto in more places
* Use emplace_back instead of push_back in some places
* Use default member initializers
* Less else after return
* Removed superfluous .c_str()
* Removed type aliases that are only used once
* Removed more unused includes

1 files changed, 11 insertions, 7 deletions

diff --git a/src/being.cpp b/src/being.cpp
index 46b499af..2d198dbd 100644
--- a/src/being.cpp
+++ b/src/being.cpp
@@ -100,19 +100,18 @@ void Being::setSubtype(Uint16 subtype)
 
     mSubType = subtype;
 
-    if (getType() == MONSTER)
+    switch (getType())
     {
+    case MONSTER:
         mInfo = MonsterDB::get(mSubType);
         setName(mInfo->getName());
         setupSpriteDisplay(mInfo->getDisplay());
-    }
-    else if (getType() == NPC)
-    {
+        break;
+    case NPC:
         mInfo = NPCDB::get(mSubType);
         setupSpriteDisplay(mInfo->getDisplay(), false);
-    }
-    else if (getType() == PLAYER)
-    {
+        break;
+    case PLAYER: {
         int id = -100 - subtype;
 
         // Prevent showing errors when sprite doesn't exist
@@ -120,6 +119,11 @@ void Being::setSubtype(Uint16 subtype)
             id = -100;
 
         setSprite(Net::getCharHandler()->baseSprite(), id);
+        break;
+    }
+    case FLOOR_ITEM:
+    case UNKNOWN:
+        break;
     }
 }