summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-05-14Fix: Job XP Bar not updating on monster kill in mini status windowasuratva1-2/+5
**** mana/plus!83
2024-05-10Download mplint release instead of recompiling every timeFedja Beader4-47/+35
Saves 1min10s by not compiling and another 15s by moving it together with linters. Squashed with: * Make sure mplint internal error or failure to run is detected * Make mplint breaking cause job to fail * Move linters out of lightweight.. goes faster, 3m46s -> 1m45s * Make script fail if any command returns nonzero or if any variable is unset. * Donwload mplint instead of building it **** mana/plus!80
2024-05-09Fix guild lvl-up packet parsing AND change password causing client exit in MLFedja Beader1-3/+1
What happened: 1) herc evol sends 0x100 as packet ID offset 2) 0x100 is added to 0x0062 of SMSG_CHAR_PASSWORD_RESPONSE 3) SMSG_CHAR_PASSWORD_RESPONSE is then inserted into 0x162 slot of packet map, shadowing SMSG_GUILD_SKILL_INFO 4) on guild lvl-up, server sends this in SMSG_GUILD_SKILL_INFO 5) ManaVerse exits in confusion. Note 1: due to popupmenu paste not working in change password dialog, tested password change only with invalid old password, which worked (opened error dialog instead of client exiting). Note 2: Some packet handlers are bound using &Ea::LoginRecv prefix, this one had &LoginRecv and this was kept this way (uses vtable lookup?). ~~TODO: SMSG_CHAR_PASSWORD_RESPONSE seems to be something about password changes, but I could not find this packet either in TMWA or herc. Still, I need to test if these still work on all active servers~~ Tested. Squashed with: * Fix exit on password change, too * Fix guild lvl-up packet parsing causing client exit in ML **** mana/plus!81
2024-05-08Don't use pathJoin for URLsFedja Beader1-2/+1
Problem happens only on Windows that uses \ for path separators and only when primary download location does not contain requested file with requested checksum. To repro, it should be enough to change one checksum in resources.xml Report from Manatauro: ![pathjoin](/uploads/4b969168ba7babc21108c1db1a680f66/pathjoin.jpg) **** mana/plus!82
2024-04-27Rename color identifiers for clarityFedja Beader1-9/+10
2024-04-27ReformatFedja Beader1-13/+7
Should this function gain emplace()-like semantics?
2024-04-27deduplicate branchesFedja Beader1-12/+7
2024-04-27Correct ommision of 0 in hexadecimal format specFedja Beader1-1/+3
2024-04-27Fix "Show items" (equipment display on other players)Fedja Beader2-3/+2
See #73 for discussion Squashed with: * Fix mana pearl showing in arrows slot in Classic * Fix off-by-one. Was causing Old Towel to render in torso slot in ML. **** mana/plus!78
2024-04-16Stop log spam in case download errors outFedja Beader1-0/+2
See manaplus.log in https://git.themanaworld.org/specing/manaplus/-/jobs/168040#L3241 **** mana/plus!72
2024-04-16Fix screenshot size for OpenGL modesewew ukek2-10/+14
Screenshot code didn't take into account scaling setting which resulted in cropped screenshots. I didn't touch SDL modes because they don't support scaling and I'm not sure how that would be implemented for software render. **** mana/plus!70
2024-04-14Show monster info for all, not just GMsFedja Beader1-14/+4
Tested on classic & ML See merge request mana/plus!75 ****
2024-04-09Fix nsiqcppstyle part of linters job to actually fail in case of issuesFedja Beader1-0/+1
2024-04-09Simplify and remove linter's choking hazardFedja Beader1-10/+9
windowmanager.cpp(456, 9): Incorrect align on long parameter list in front of 'SetClassLongPtr', it should be aligen in column 25. [RULE_4_1_C_align_long_function_parameter_list]
2024-04-09Fix all alignment warnings/errors.Fedja Beader6-31/+41
Other addButton sections intentionally left misaligned as a test for future fix in nsiqcppstyle. .. why does it not complain about every such block?
2024-04-07Fix for login buttonewew ukek2-10/+8
This is the simpler solution for issue #64 proposed by @bjorn. `logic()` gets called on every tick after input is processed so I removed redundant code from `keyPressed()`. * Update login button in logic() instead of keyPressed() See merge request mana/plus!67 **** Reviewed-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
2024-04-06Use debian bullseye for all active gcc10 CI jobsFedja Beader1-0/+3
2024-04-06Disable gcc-snapshot CI job.. do we really need to waste CI and dev timeFedja Beader1-1/+3
testing the very bleeding edge for every commit everywhere? Should still be made to run every so often... TODO
2024-04-06Move CI job image specifier to before script and after stage specifierFedja Beader1-14/+14
This is the most logical place for it, IMO. I left stage and branch specifier up top as this decision happens before any image is fetched.
2024-04-05Rename hp bar color identifiers for clarityewew ukek4-46/+47
Continuation of https://git.themanaworld.org/mana/plus/-/merge_requests/68#note_12819 I've renamed `*_HP2` to `*_HP_BG` and updated their descriptions. I didn't touch configuration keys intentionally. "Renamed *_HP -> *_HP_FG. Also decided to keep descriptions as is or else they become unreadable." See merge request mana/plus!71
2024-03-26Remove default shortcut for "Hide [all] Windows"Fedja Beader1-1/+1
See merge request mana/plus!63
2024-03-26Auto-focus number and text input fields in NPC dialogsFedja Beader1-2/+5
+reformat one bit See merge request mana/plus!61
2024-03-26Rename "buggy servers protection" to what it does (packet limiter on/off)Fedja Beader1-1/+1
See merge request mana/plus!62
2024-03-25Typofix Guil -> Guild and insert AndFedja Beader6-20/+20
See merge request mana/plus!64
2024-03-20Color setting for attack range of monsters from ignore listewew ukek4-2/+20
This MR displays attack range of monsters from ignore attack list in different color. I picked magenta as default, this may be changed if needed. There are actor types other than monsters but looks like it's not possible to add them to ignore list anyway. * Flip if branches for readability * Color setting for attack range of monsters from ignore list ****
2024-03-11Disable trade tab and trade filter by defaultFedja Beader1-2/+2
By popular agreement: https://forums.themanaworld.org/viewtopic.php?t=21696 [ci skip] **** Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
2024-03-11Put variable declarations into scope where they are used.Fedja Beader1-3/+3
**** Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
2024-03-11Remove last-login(time) from char select window.Fedja Beader4-8/+9
No server in use still sends that field. **** Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
2024-03-11Typofix {add,remove}InventoyListener -> {add,remove}InventoryListenerFedja Beader4-9/+9
**** Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
2024-03-11Remove right click -> Undress on players.Fedja Beader1-3/+0
Requested by Ledmitz. The /undress <player> command remains. **** Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
2024-03-11Make pickup code go to nearby tile, not on top of item.Fedja Beader1-4/+18
Fixes most cases of walking through doors/warps on pickup. ****
2024-03-11TypofixFedja Beader2-2/+2
**** Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org> Approved-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
2024-02-21Add missing include for libxml2ewewukek1-0/+4
2024-02-21Const correct variable to hold __xmlParserVersion() valueewewukek2-2/+2
2024-02-21Don't depend on __clang__ and include <ctime> on all non-Windows platformsewewukek2-8/+4
2024-02-20Emotes: Only load client emotes if the server is lacking themJesusaves1-5/+6
2024-02-16Client rebranding: Partly import changes from !28Jesusalva Jesusalva32-117/+121
Co-Authored-By: jak1 <jak1@themanaworld.org> Co-Authored-By: jesusalva <jesusalva@themanaworld.org> Co-Authored-By: Fedja Beader <fedja@protonmail.ch>
2024-02-16Remove data/evolFedja Beader18-665/+1
Co-Authored-By: jak1 <jak1@themanaworld.org> Co-Authored-By: jesusalva <jesusalva@themanaworld.org> Co-Authored-By: Fedja Beader <fedja@protonmail.ch>
2024-02-13Hotplug support for joysticksewewukek3-15/+34
2024-02-12Fix the issue reported by MadCamel about a fake "Couldn't update" message.Jesusaves1-2/+1
2024-02-11Total weight sortingFedja Beader4-14/+82
2024-02-11Get rid of manaverse-owned updates. (Coverage warning!)Jesusaves2-74/+3
This leaves some dead corpses behind, cleanup after is advised. Reverts b9e27e9563e32a17cd80142ce05b5770479cc709 For short, the client should not be keeping an override on what server shows. This function (backdoor) also don't exist on Mana client.
2024-02-10[skip ci] Move linters from heavy lifters to light weights.Jesusaves1-1/+1
This should help a bit with queuing, not so much with pipeline CPU time.
2024-02-10Clarify that dyecmd is a tooljak11-1/+1
Commit reviewed and changed by jesusalva and specing
2024-02-10Remove dead serversjak11-74/+0
Commit reviewed and changed by jesusalva and specing
2024-02-10Remove Windows Azure CI (we have our own)jak11-82/+0
Commit reviewed and changed by jesusalva and specing
2024-02-10Remove .cirrus.yml (unused)jak11-138/+0
Commit reviewed and changed by jesusalva and specing
2024-02-09Update copyright headers up to 2023Jesusalva Jesusalva1916-1918/+3836
2024-02-09Log misses in battle tab, alongside hitsFedja Beader1-9/+29
2024-02-09Fix dragging lum (first item) out of the spells window.Fedja Beader1-1/+1
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-11-28 00:28:32 +0000