summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-09-19Horizontally extend the login screen server type selection boxFedja Beader1-1/+9
Split from mana/plus!79
2024-09-08Quote all the variable expansionsFedja Beader1-60/+60
Squashed with: * More quoting, but these are likely unnecessary [^"x]$[a-zA-Z] [^"]x$[a-zA-Z] **** mana/plus!98
2024-09-08Refactor outfit saving logicFedja Beader1-13/+23
Shaves some bytes from exe, too **** mana/plus!102
2024-09-07There is no need to first pack this into a vector and then into arrayFedja Beader1-17/+4
TODO: are all these casts actually required? SMH **** mana/plus!101
2024-08-28Fix off-by-one causing archer attack mode to approach to within attack range - 1Fedja Beader3-17/+18
**** mana/plus!96
2024-08-28Further improve skill error handling and messages.Fedja Beader1-57/+41
Squashed with: * Appease linters + more reformat * Further improve skill error handling and messages. 24751878 "Improve skill error messages." added trailing dots only on the second branch. This adds missing dots on the first one as well as compacts the logic. **** mana/plus!93
2024-08-28Remove silly msg.read* duplicationFedja Beader11-100/+46
& shaves ~5KB from debug binary. previd=""; while read -r line; do if [[ $line =~ .*"msg.read"[^\"]*"\""([^\"]*).* ]]; then id="${BASH_REMATCH[1]}"; if [[ "$id" == "$previd" ]]; then printf "%s\n" "$line"; fi; previd="$id"; fi; done < <(grep -r 'msg.read.*' src/net/) **** mana/plus!91
2024-08-28Squash gcc8 -Wformat-y2k warningFedja Beader1-1/+6
* Run gcc8 job again in this MR * Squash the %c strftime gcc warning **** mana/plus!100
2024-08-27Show mail expiry timeFedja Beader3-1/+7
Server does not communicate sent time.. or it did, until 2017 ?? See src/map/clif.c #if PACKETVER >= 20170419 The RODEX_EXPIRY constant seems not to be communicated either, preventing us from deducing send time from expiry time. **** mana/plus!90
2024-08-27Redundant. I don't think the time savings due to not calculating distance, ↵Fedja Beader1-24/+3
if any, are worth it. In fact, this might even save some time. Calculating distance may be faster than iterating through memory twice. **** mana/plus!95
2024-08-27Sunset/disable some CI jobs to reduce CI load, speed up CI and drop support ↵Fedja Beader1-4/+14
for obsolete platforms. Move some others to only master... Sunset/disable some CI jobs to reduce CI load. Move some others to only master branch as I deem them unlikely to fail if others work. gcc7 is direct replaced by gcc8 (both really obsolete these days) gcc7-default -> gcc10-default (same) gcc10 game/dyecmd only ... no need to test if these two special build options work on every ommit Some special builders are made master-only pending further review. Squashed with: * Fix: only: has to be an array or .. * Sunset/disable some CI jobs to reduce CI load. Move some others to only master branch as I deem them unlikely to fail if others work. gcc7 is direct replaced by gcc8 (both really obsolete these days) gcc7-default -> gcc10-default (same) gcc10 game/dyecmd only ... no need to test if these two special build options work on every ommit Some special builders are made master-only pending further review. **** mana/plus!99
2024-08-24Simplify itempickup codeFedja Beader1-3/+4
**** mana/plus!94
2024-08-22POSIX test does not support ==Fedja Beader1-42/+42
Reported by Skyflare **** mana/plus!97
2024-08-21Fix skill fail packet handling causing nullptr crash when switching charactersFedja Beader1-2/+6
How to reproduce: spam emote then quickly switch char Thread 1 "manaplus" received signal SIGSEGV, Segmentation fault. SkillDialog::getSkill (this=0x0, id=id@entry=1) at gui/windows/skilldialog.cpp:805 0 SkillDialog::getSkill (this=0x0, id=id@entry=1) at gui/windows/skilldialog.cpp:805 1 EAthena::SkillRecv::processSkillFailed (msg=...) at net/eathena/skillrecv.cpp:302 ... **** mana/plus!92
2024-08-18Make code more readableFedja Beader1-17/+29
g **** mana/plus!77
2024-08-17Limit shop's Max button to available carry weightFedja Beader1-1/+15
**** mana/plus!88
2024-07-05Fix cart item add failure messages [skip ci]Fedja Beader1-2/+2
2024-06-25re-integrate windows CIFedja Beader1-2/+14
- [x] integrate docker-windows-builder with or instead of the existing disabled MXE jobs - [x] fix rebranding breaking windows CI (already pushed to master) Part of #71 Squashed with: * $CI_COMMIT_BRANCH is unset in merge request pipelines * Too much text * Cleanup now that the builder branch is merged * Revert "Disable unnecessary builders" This reverts commit f4820e05439792a02601dfef0e2e2ad148615f1f. * Try depend strategy + de-hardcode stuff cleanup * Use downstream branch created for this purpose (testring only, switch to master before merging) * Multi-project pipeline, attempt #1 missing stage definition * Disable back, comment why it doesen't work Forgot to disable the broken windows builder job * Does existing MXE job even work? Kinda doubt it, but after this you can't blame me for not trying (What's the purpose of windows-docker-builder if this works?) But lets try the *32 one as well * Disable unnecessary builders **** mana/plus!87
2024-06-24evol-client.icon missing was breaking windows build after "Remove data/evol"Fedja Beader1-1/+0
2024-05-29Switch "show chat history" into a line limit field and considerablyFedja Beader4-10/+14
raise default (5->100).
2024-05-29Raise default line limit 40->100. 40 is not even a screenful.Fedja Beader1-1/+1
2024-05-29Fix paste in registration windowFedja Beader2-9/+8
Addendum to cbab9d6d "Fix for login button" See also mana/plus!67 and mana/plus#64 **** mana/plus!86
2024-05-17Fix oddity introduced by 'Download mplint release instead of recompilingFedja Beader1-3/+0
every time' No error/warning? odd.
2024-05-16Refactor loadFromLogFile calls into ChatTab contructorFedja Beader8-16/+3
This has the side effect that now #Debug history is also loaded. **** mana/plus!84
2024-05-15Merge branch 'improved_controller' into 'master'Fedja Beader8-189/+413
Controller improvements See merge request mana/plus!52
2024-05-15Rename axis tolerance to joystick dead zone + reformat as per discussionFedja Beader1-6/+6
2024-05-15Enable joystick by default, update default toleranceewewukek2-8/+1
2024-05-15Consume input event in QuitDialog instead of relying on a hackewewukek2-15/+12
2024-05-15Heuristic to detect controller triggersewewukek2-3/+27
2024-05-15Refactor joystick input codeewewukek2-58/+74
2024-05-15Make sticks/triggers behave like regular buttonsewewukek4-7/+103
2024-05-15Extend gui support to joystick hat (d-pad)ewewukek4-2/+12
2024-05-15Gui support for joystick buttonsewewukek4-2/+36
2024-05-15Add a checkbox for d-pad to switch between movement and button behaviorewewukek5-22/+50
2024-05-15Make D-Pad behave like regular buttonsewewukek3-29/+125
2024-05-14Switch joystick axis tolerance type to floatewewukek4-15/+26
2024-05-14Remove joystick calibration logicewewukek4-95/+3
2024-05-14Add a slider to joystick settings to set axis toleranceewewukek4-8/+40
2024-05-14Use single tolerance value for all 4 joystick movement directionsewewukek3-40/+19
2024-05-14Fix: Job XP Bar not updating on monster kill in mini status windowasuratva1-2/+5
**** mana/plus!83
2024-05-10Download mplint release instead of recompiling every timeFedja Beader4-47/+35
Saves 1min10s by not compiling and another 15s by moving it together with linters. Squashed with: * Make sure mplint internal error or failure to run is detected * Make mplint breaking cause job to fail * Move linters out of lightweight.. goes faster, 3m46s -> 1m45s * Make script fail if any command returns nonzero or if any variable is unset. * Donwload mplint instead of building it **** mana/plus!80
2024-05-09Fix guild lvl-up packet parsing AND change password causing client exit in MLFedja Beader1-3/+1
What happened: 1) herc evol sends 0x100 as packet ID offset 2) 0x100 is added to 0x0062 of SMSG_CHAR_PASSWORD_RESPONSE 3) SMSG_CHAR_PASSWORD_RESPONSE is then inserted into 0x162 slot of packet map, shadowing SMSG_GUILD_SKILL_INFO 4) on guild lvl-up, server sends this in SMSG_GUILD_SKILL_INFO 5) ManaVerse exits in confusion. Note 1: due to popupmenu paste not working in change password dialog, tested password change only with invalid old password, which worked (opened error dialog instead of client exiting). Note 2: Some packet handlers are bound using &Ea::LoginRecv prefix, this one had &LoginRecv and this was kept this way (uses vtable lookup?). ~~TODO: SMSG_CHAR_PASSWORD_RESPONSE seems to be something about password changes, but I could not find this packet either in TMWA or herc. Still, I need to test if these still work on all active servers~~ Tested. Squashed with: * Fix exit on password change, too * Fix guild lvl-up packet parsing causing client exit in ML **** mana/plus!81
2024-05-08Don't use pathJoin for URLsFedja Beader1-2/+1
Problem happens only on Windows that uses \ for path separators and only when primary download location does not contain requested file with requested checksum. To repro, it should be enough to change one checksum in resources.xml Report from Manatauro: ![pathjoin](/uploads/4b969168ba7babc21108c1db1a680f66/pathjoin.jpg) **** mana/plus!82
2024-04-27Rename color identifiers for clarityFedja Beader1-9/+10
2024-04-27ReformatFedja Beader1-13/+7
Should this function gain emplace()-like semantics?
2024-04-27deduplicate branchesFedja Beader1-12/+7
2024-04-27Correct ommision of 0 in hexadecimal format specFedja Beader1-1/+3
2024-04-27Fix "Show items" (equipment display on other players)Fedja Beader2-3/+2
See #73 for discussion Squashed with: * Fix mana pearl showing in arrows slot in Classic * Fix off-by-one. Was causing Old Towel to render in torso slot in ML. **** mana/plus!78
2024-04-16Stop log spam in case download errors outFedja Beader1-0/+2
See manaplus.log in https://git.themanaworld.org/specing/manaplus/-/jobs/168040#L3241 **** mana/plus!72
2024-04-16Fix screenshot size for OpenGL modesewew ukek2-10/+14
Screenshot code didn't take into account scaling setting which resulted in cropped screenshots. I didn't touch SDL modes because they don't support scaling and I'm not sure how that would be implemented for software render. **** mana/plus!70
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-11-22 04:15:59 +0000