General code cleanups

* Use default member initializers
* Use range-based loops
* Don't use 'else' after 'return'
* Removed some unused includes
* Construct empty strings with std::string() instead of ""
* Clear strings with .clear() instead of assigning ""
* Check whether strings are empty with .empty() instead of comparing to ""
* Removed redundant initializations

1 files changed, 2 insertions, 2 deletions

diff --git a/src/gui/socialwindow.cpp b/src/gui/socialwindow.cpp
index 3fda9aa0..96a9c389 100644
--- a/src/gui/socialwindow.cpp
+++ b/src/gui/socialwindow.cpp
@@ -360,7 +360,7 @@ SocialWindow::~SocialWindow()
         mPartyAcceptDialog->scheduleDelete();
         mPartyAcceptDialog = nullptr;
 
-        mPartyInviter = "";
+        mPartyInviter.clear();
     }
     delete mCreatePopup;
 }
@@ -445,7 +445,7 @@ void SocialWindow::action(const gcn::ActionEvent &event)
             Net::getPartyHandler()->inviteResponse(mPartyInviter, false);
         }
 
-        mPartyInviter = "";
+        mPartyInviter.clear();
         mPartyAcceptDialog = nullptr;
     }
     else if (event.getSource() == mGuildAcceptDialog)