General code cleanups

* Don't needlessly store or return raw pointers in BeingInfo
* Less copying, more moving
* Less else after return
* Make AddDEF a template instead of a macro
* Removed some unused includes
* Use range-based for loops

1 files changed, 2 insertions, 3 deletions

diff --git a/src/configuration.h b/src/configuration.h
index cd56be05..5864829e 100644
--- a/src/configuration.h
+++ b/src/configuration.h
@@ -162,11 +162,10 @@ class ConfigurationObject
         template<class T, class CONT>
         CONT getList(const std::string &name, CONT empty, ConfigurationListManager<T, CONT> *manager)
         {
-            ConfigurationList *list = &(mContainerOptions[name]);
             CONT container = empty;
 
-            for (ConfigurationList::const_iterator it = list->begin(); it != list->end(); it++)
-                container = manager->readConfigItem(*it, container);
+            for (auto obj : mContainerOptions[name])
+                container = manager->readConfigItem(obj, container);
 
             return container;
         }