python3: Add explicit list()s for python3.6

This should be reverted once we drop support for Ubuntu 18.04, and therefore
python3.6, as it does clutter up the code a bit.

Sourced from specing's work on the porting process.
See https://git.themanaworld.org/legacy/tmwa/-/merge_requests/256

4 files changed, 9 insertions, 9 deletions

diff --git a/src/main-gdb-head.py b/src/main-gdb-head.py
index a465c97..09e22fe 100644
--- a/src/main-gdb-head.py
+++ b/src/main-gdb-head.py
@@ -5,7 +5,7 @@
 
 # gdb sticks everything in one scope.
 # This lets us enumerate what *we* added.
-initial_globals = {id(v):v for v in globals().values()}
+initial_globals = {id(v):v for v in list(globals().values())}
 
 import re
 
diff --git a/src/map/script-parse.py b/src/map/script-parse.py
index 199e348..3346b92 100644
--- a/src/map/script-parse.py
+++ b/src/map/script-parse.py
@@ -106,7 +106,7 @@ class ScriptBuffer(object):
         code_begin = code['_M_impl']['_M_start']
         code_end = code['_M_impl']['_M_finish']
         code_size = int(code_end - code_begin)
-        r = iter(range(code_size))
+        r = iter(list(range(code_size)))
         for i in r:
             buf = []
             for label in labels_dict.get(i, []):
diff --git a/tools/config.py b/tools/config.py
index ce61440..22ece0b 100755
--- a/tools/config.py
+++ b/tools/config.py
@@ -257,7 +257,7 @@ class Group(object):
         short_cpp_name = '%s.cpp' % var_name
         cpp_name = os.path.join(path, short_cpp_name)
 
-        values = sorted(self.options.values(), key=lambda o: o.name)
+        values = sorted(list(self.options.values()), key=lambda o: o.name)
 
         desc = 'Config for %s::%s' % (namespace_name, self.name)
         with OpenWrite(hpp_name) as hpp, \
@@ -382,7 +382,7 @@ class Realm(object):
         return rv
 
     def dump(self):
-        for g in self.groups.values():
+        for g in list(self.groups.values()):
             g.dump_in(self.path, self.path.split('/')[-1])
 
 class Everything(object):
@@ -399,7 +399,7 @@ class Everything(object):
     def dump(self):
         for g in glob.glob('src/*/*_conf.[ch]pp'):
             os.rename(g, g + '.old')
-        for v in self.realms.values():
+        for v in list(self.realms.values()):
             v.dump()
         for g in glob.glob('src/*/*_conf.[ch]pp.old'):
             print('Obsolete: %s' % g)
diff --git a/tools/protocol.py b/tools/protocol.py
index 8059c59..b0d46a4 100755
--- a/tools/protocol.py
+++ b/tools/protocol.py
@@ -7084,7 +7084,7 @@ def partition(d):
     changed = True
     while changed:
         changed = False
-        for k, vlist in d.items():
+        for k, vlist in list(d.items()):
             if vlist:
                 m = min(leaders[v] for v in vlist)
                 if m < leaders[k]:
@@ -7100,9 +7100,9 @@ def partition(d):
                     leaders[v] = m
 
     followers = {}
-    for k, v in leaders.items():
+    for k, v in list(leaders.items()):
         followers.setdefault(v, []).append(k)
-    return [set(v) for v in followers.values()]
+    return [set(v) for v in list(followers.values())]
 
 def ids_only(vpost):
     rv = [e for e in vpost if not isinstance(e, SpecialEventOrigin)]
@@ -7125,7 +7125,7 @@ def make_dots(ctx):
     for g in glob.glob('doc-gen/Packet-*.md'):
         os.rename(g, g + '.old')
 
-    for (id, p) in d.items():
+    for (id, p) in list(d.items()):
         md = 'doc-gen/Packet-0x%04x.md' % id
         dot = 'doc-gen/packets-around-0x%04x.gv' % id
         with OpenWrite(md) as f: