Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
attack priority list mobs within attack range, even if there exist
higher priority targets outside.
|
|
****
mana/plus!150
|
|
Squashed with:
* statuswindow: I like this way better
****
mana/plus!151
|
|
****
mana/plus!147
|
|
Not sure how to trigger this one, couldn't do it with a few simple
tests.
****
mana/plus!149
|
|
2025-03/22/#Debug.log-[19:38:37] Wrong actual or planned inbound packet size!. Packet id: 433(0x1b1), Planned size: 7, Actual size: 4
2025-03/22/#Debug.log:[19:38:52] You picked up 1 [@@760|Overlord's Helmet@@].
****
mana/plus!146
|
|
bb= bounding box
|
|
seems to skip beings with info if stopattack is active or if they are
marked as unselectable (like hammocks in ML)... huh?
|
|
as without filtering, priority and closestPriority are always the same
|
|
making special handling before first suitable being is found unnecessary.
|
|
being (down from 3x)
Note: the filter used priorityMobs (instead of priorityMobsMap).
The former seems to be the std::set variant of the latter, but I can't
find where either are filled. It does work in practice, however...
|
|
|
|
distance criteria.
This should also resolve a theoretical bug if there is a non-ignored
being within range, but something out of range has priority
Cleanup addednum: rename d to distSq
|
|
This resolves at least three instances where squared distance was
compared with non-squared one, two cases of maxDist and no squaring of
getDistance result.
|
|
Cheaper checks reordered to be checked first, removed squared root.
****
mana/plus!144
|
|
(no quantity display reserved for unlimited stock shops)
Depends on !140 due to merge conflicts.
****
mana/plus!141
|
|
distance before (potentially) asking pathfinder.
Pathfinder may get called in the validateBeing() call, can't tell yet.
Squashed with:
* Fix linter
This test and the below static_cast looks like dynamic_cast should've
been used.
****
mana/plus!143
|
|
Squashed with:
* Fix lint.. just revert previous state, I'll deal with it when I make
things pass Positions
****
mana/plus!142
|
|
****
mana/plus!140
|
|
@jesusalva asked what to rename it to, here:
https://forums.themanaworld.org/viewtopic.php?t=21691
Squashed with:
* Rename --without-manaversegame to --without-gameclient
This makes the most sense, I think. Jes agrees, too.
* Rename --without-manaplusgame to --without-manaversegame
Split off from !45: Rename the program from ManaPlus to ManaVerse.
****
mana/plus!138
Co-authored-by: jak1 <jak1@themanaworld.org>
|
|
Reported by Thorbjorn
****
mana/plus!129
Approved-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
|
|
Split off from mana/plus!45: "Rename the program from ManaPlus to ManaVerse."
+POTFILES.in CI fix
****
mana/plus!132
Co-authored-by: Fedja Beader <fedja@protonmail.ch>
|
|
****
mana/plus!139
|
|
This makes sure that ml/clientdata!180 never happens again via message
in Debug tab.
The legacy numeric ID method could be deprecated. Maybe after release.
The client uses full attribute names since 2016.
****
mana/plus!137
|
|
(Fedja) I'm suspecting that some CI will break on this.
Split off from !45: Rename the program from ManaPlus to ManaVerse.
****
mana/plus!135
Co-authored-by: Fedja Beader <fedja@protonmail.ch>
|
|
****
mana/plus!136
|
|
Tested as part of !136, pushed to master
|
|
****
mana/plus!134
|
|
Split from mana/plus!28 and rebased on master by specing.
****
mana/plus!131
|
|
In theory split out from mana/plus!28, in practice I (specing)
just ran sed myself instead of bothering with splitting out changes.
****
mana/plus!130
|
|
Autoconf manual states that CXXFLAGS is a user variable and should not
be overriden, so I did not use AX_APPEND_COMPILE_FLAGS for this. Thus,
there are no checks if the compiler supports it, but also the builder can
override this flag by passing another flag that overrides it on the
command line. Okay, this is now way too theoretical.
Indeed, the override happens with ./configure 'CXXFLAGS=-std=c++17'
(both flags in final command line)
Do note:
- The standard was not explicitly set for some builds (thus compiler
default was used)
- The default on my own box is C++17
- I'm setting C++11 as that's required by my previous change. Upgrade to
C++17 is deferred to until it becomes required.
- The use of CPPFLAGS could be reviewed... they may be used incorrectly
(instead of CXXFLAGS). I would really like to get all the builders going
before requirements are raised.
- CI cleanup would be nice
- wish 4144 would return.
****
mana/plus!128
|
|
Tile coordinates dance in pairs, so let's pair them up.
also grows exe size by about 3K, hope this will go away when the rest is
converted to Position as well. Note: on my local debug build only. Not on gcc10 CI.
Squashed with:
* Should it be mNavigateDest or mNavigateTo? Hmm, the jury is still out
there ...
****
mana/plus!116
|
|
line-length limits.
Introduced in mana/plus!88
and exposed in mana/plus!126
Pushing directly to master from top of !126 before merging 126.
|
|
Addendum to !89 (and !117)
Amusing: putting this line before the .clear() grows the exe by 40 bytes.
****
mana/plus!118
|
|
****
mana/plus!119
|
|
****
mana/plus!120
|
|
Pointless change, I know.
****
mana/plus!115
|
|
****
mana/plus!113
|
|
****
mana/plus!114
|
|
Further idea: a lot of these models are wrappers around a string options array. Maybe convert the classes into a single template class taking an array parameter?
****
mana/plus!111
Approved-by: Led Mitz <smoothshifter@tuta.io>
|
|
description/tooltip.
****
mana/plus!105
|
|
****
mana/plus!104
|
|
Memory may not be freed properly, also code is IMO ugly. See !109 for the other way of implementing this (unrelated). Was done in socialWindow as the join confirmation is already there.
****
mana/plus!110
|
|
Curiously, this increases -g -O2 exe size by 96 bytes, but disassembly
dump around this code is the same (redundant check was already optimised out?)
****
mana/plus!106
|
|
use @toevent, then switch character (and stay on character screen).
Thread 1 "manaplus" received signal SIGSEGV, Segmentation fault.
0x.. in Game::getCurrentMap (this=<optimized out>) at ./game.h:108
108 { return mCurrentMap; }
(gdb) bt
0x.. in Game::getCurrentMap (this=<optimized out>) at ./game.h:108
Ea::PlayerRecv::processMapMask (msg=...) at net/ea/playerrecv.cpp:242
****
mana/plus!108
|
|
Adds a light blue bar for MP below player's HP bar. It shows only if M.Atk is above 0.
I didn't add a checkbox to the settings to disable this, let me know if I should.
Squashed with:
* Sneak in another TODO
* Sneak in a TODO
****
mana/plus!68
Co-authored-by: Fedja Beader <fedja@protonmail.ch>
|
|
Move to target & move to target type intentionally kept in basic's targetting section.
****
mana/plus!103
|
|
work for ML
Squashed with:
* Sync with last comment (Evol->Evol2)
* Another rename, to reflect TMW->Manasource rebrand (maybe?)
****
mana/plus!79
|