summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2025-04-01No need for C++17 herewarp_mage_clientFedja Beader1-2/+1
2025-04-01Also prefer mobs in plain attack list, that are close to player.Fedja Beader1-6/+12
2025-04-01Special client for Warp MageFedja Beader1-0/+10
attack priority list mobs within attack range, even if there exist higher priority targets outside.
2025-04-01Remove weird/unnecessary newlining of __VA_ARGS__ in checkutils.hFedja Beader1-6/+3
**** mana/plus!150
2025-04-01Add free weight indication to mini status barFedja Beader2-6/+16
Squashed with: * statuswindow: I like this way better **** mana/plus!151
2025-04-01Undefine WRONGPACKETSIZE macro. Even more so as it uses local varsFedja Beader2-4/+2
**** mana/plus!147
2025-04-01processTradeResponse: Fix a potential early exit before full packet is readFedja Beader1-1/+2
Not sure how to trigger this one, couldn't do it with a few simple tests. **** mana/plus!149
2025-04-01processTradeItemAddResponse: fix early exit before full packet is consumed.Fedja Beader1-2/+3
2025-03/22/#Debug.log-[19:38:37] Wrong actual or planned inbound packet size!. Packet id: 433(0x1b1), Planned size: 7, Actual size: 4 2025-03/22/#Debug.log:[19:38:52] You picked up 1 [@@760|Overlord's Helmet@@]. **** mana/plus!146
2025-03-25findNearestLivingBeing: do cheap bb check before set lookups or pathfinderFedja Beader1-14/+20
bb= bounding box
2025-03-25findNearestLivingBeing: move (unknown) cheap check before set lookupFedja Beader1-6/+6
seems to skip beings with info if stopattack is active or if they are marked as unselectable (like hammocks in ML)... huh?
2025-03-22findNearestLivingBeing: remove redundant branchFedja Beader1-16/+6
as without filtering, priority and closestPriority are always the same
2025-03-22findNearestLivingBeing: closest* are always set to something sensible,Fedja Beader1-14/+3
making special handling before first suitable being is found unnecessary.
2025-03-22Cleanup findNearestLivingBeing: search priorityMobsMap at most once per ↵Fedja Beader1-19/+15
being (down from 3x) Note: the filter used priorityMobs (instead of priorityMobsMap). The former seems to be the std::set variant of the latter, but I can't find where either are filled. It does work in practice, however...
2025-03-22Cleanup findNearestLivingBeing: rename index -> closestPriorityFedja Beader1-6/+6
2025-03-21Cleanup findNearestLivingBeing: only update closestBeing if it satisfiesFedja Beader1-20/+17
distance criteria. This should also resolve a theoretical bug if there is a non-ignored being within range, but something out of range has priority Cleanup addednum: rename d to distSq
2025-03-21Clean-up ActorManager::findNearestLivingBeingFedja Beader1-13/+16
This resolves at least three instances where squared distance was compared with non-squared one, two cases of maxDist and no squaring of getDistance result.
2025-03-13Clean-up and optimise ActorManager::findMostDamagedPlayerFedja Beader1-15/+21
Cheaper checks reordered to be checked first, removed squared root. **** mana/plus!144
2025-03-13Show quantity for item qty 1 in limited stock shopsFedja Beader1-1/+1
(no quantity display reserved for unlimited stock shops) Depends on !140 due to merge conflicts. **** mana/plus!141
2025-03-10Speedup ActorManager::findNearestByName by testing cheap bounding box ↵Fedja Beader1-9/+8
distance before (potentially) asking pathfinder. Pathfinder may get called in the validateBeing() call, can't tell yet. Squashed with: * Fix linter This test and the below static_cast looks like dynamic_cast should've been used. **** mana/plus!143
2025-03-10Cosmetic cleanup of ActorManager::pickUpNearestFedja Beader2-13/+13
Squashed with: * Fix lint.. just revert previous state, I'll deal with it when I make things pass Positions **** mana/plus!142
2025-03-10Slight cleanup in shopitem.cppFedja Beader1-6/+8
**** mana/plus!140
2025-03-05Rename --without-manaplusgame to --without-gameclientFedja Beader1-2/+2
@jesusalva asked what to rename it to, here: https://forums.themanaworld.org/viewtopic.php?t=21691 Squashed with: * Rename --without-manaversegame to --without-gameclient This makes the most sense, I think. Jes agrees, too. * Rename --without-manaplusgame to --without-manaversegame Split off from !45: Rename the program from ManaPlus to ManaVerse. **** mana/plus!138 Co-authored-by: jak1 <jak1@themanaworld.org>
2025-03-05Change follow-parent default to true (Fix #80).Fedja Beader1-1/+1
Reported by Thorbjorn **** mana/plus!129 Approved-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
2025-03-05Rename manaplus source directories and headers to manaversejak117-38/+38
Split off from mana/plus!45: "Rename the program from ManaPlus to ManaVerse." +POTFILES.in CI fix **** mana/plus!132 Co-authored-by: Fedja Beader <fedja@protonmail.ch>
2025-03-05Remove pointless one-line StatusWindow::addTabBasic() functionFedja Beader2-10/+3
**** mana/plus!139
2025-03-01Report missing/unknown attr fields in clientdata stats.xmlFedja Beader1-4/+8
This makes sure that ml/clientdata!180 never happens again via message in Debug tab. The legacy numeric ID method could be deprecated. Maybe after release. The client uses full attribute names since 2016. **** mana/plus!137
2025-02-26Rename log file manaplus.log -> manaverse.logjak14-4/+4
(Fedja) I'm suspecting that some CI will break on this. Split off from !45: Rename the program from ManaPlus to ManaVerse. **** mana/plus!135 Co-authored-by: Fedja Beader <fedja@protonmail.ch>
2025-02-26StatDB: deduplicate loadBasicStats(...) and loadStats(...)Fedja Beader1-47/+15
**** mana/plus!136
2025-02-26Remove stray continue, loop has no code outside of conditional branches.Fedja Beader1-1/+1
Tested as part of !136, pushed to master
2025-02-25Rename AttributesEnum::find to ::contains to match its meaningFedja Beader3-4/+4
**** mana/plus!134
2025-02-24added manaverse' copyright line to src/jak132-0/+32
Split from mana/plus!28 and rebased on master by specing. **** mana/plus!131
2025-02-24updated copyright -2020 for manaplusjak132-32/+32
In theory split out from mana/plus!28, in practice I (specing) just ran sed myself instead of bothering with splitting out changes. **** mana/plus!130
2025-02-22Set C++11 as default C++ standardFedja Beader1-2/+4
Autoconf manual states that CXXFLAGS is a user variable and should not be overriden, so I did not use AX_APPEND_COMPILE_FLAGS for this. Thus, there are no checks if the compiler supports it, but also the builder can override this flag by passing another flag that overrides it on the command line. Okay, this is now way too theoretical. Indeed, the override happens with ./configure 'CXXFLAGS=-std=c++17' (both flags in final command line) Do note: - The standard was not explicitly set for some builds (thus compiler default was used) - The default on my own box is C++17 - I'm setting C++11 as that's required by my previous change. Upgrade to C++17 is deferred to until it becomes required. - The use of CPPFLAGS could be reviewed... they may be used incorrectly (instead of CXXFLAGS). I would really like to get all the builders going before requirements are raised. - CI cleanup would be nice - wish 4144 would return. **** mana/plus!128
2025-02-20Convert navigateTo to take a Position instead of two integers.Fedja Beader7-59/+54
Tile coordinates dance in pairs, so let's pair them up. also grows exe size by about 3K, hope this will go away when the rest is converted to Position as well. Note: on my local debug build only. Not on gcc10 CI. Squashed with: * Should it be mNavigateDest or mNavigateTo? Hmm, the jury is still out there ... **** mana/plus!116
2025-02-12Fix remaining cpplint error that was introduced while trying to satisfy ↵Fedja Beader1-5/+3
line-length limits. Introduced in mana/plus!88 and exposed in mana/plus!126 Pushing directly to master from top of !126 before merging 126.
2025-02-03Fix unable to switch to another character after -D (chooseDefault) is used.Fedja Beader1-0/+1
Addendum to !89 (and !117) Amusing: putting this line before the .clear() grows the exe by 40 bytes. **** mana/plus!118
2025-02-03Typofix: mShowNavigePath -> mShowNavigatePathFedja Beader2-5/+5
**** mana/plus!119
2025-02-03Trim whitespace at end of lineFedja Beader1-1/+1
**** mana/plus!120
2025-01-29Trim too much newliningFedja Beader2-38/+10
Pointless change, I know. **** mana/plus!115
2025-01-28Fix typo chec -> checkFedja Beader3-5/+5
**** mana/plus!113
2025-01-28Fix typo: opitons -> optionsFedja Beader4-14/+14
**** mana/plus!114
2024-10-12Add dark magic to text command magic schools listFedja Beader2-4/+10
Further idea: a lot of these models are wrappers around a string options array. Maybe convert the classes into a single template class taking an array parameter? **** mana/plus!111 Approved-by: Led Mitz <smoothshifter@tuta.io>
2024-10-11Move trade filtering setting to immidiately under trade tab & fix ↵Fedja Beader1-10/+9
description/tooltip. **** mana/plus!105
2024-10-11Introduce a kludge to deduplicate server type strings.Fedja Beader2-39/+23
**** mana/plus!104
2024-10-11Add confirmation dialog for leaving guildFedja Beader3-2/+39
Memory may not be freed properly, also code is IMO ugly. See !109 for the other way of implementing this (unrelated). Was done in socialWindow as the join confirmation is already there. **** mana/plus!110
2024-10-11Remove redundant nullptr checkFedja Beader1-1/+1
Curiously, this increases -g -O2 exe size by 96 bytes, but disassembly dump around this code is the same (redundant check was already optimised out?) **** mana/plus!106
2024-10-11Fix switchmap during switch character crash (@toevent)Fedja Beader1-1/+6
use @toevent, then switch character (and stay on character screen). Thread 1 "manaplus" received signal SIGSEGV, Segmentation fault. 0x.. in Game::getCurrentMap (this=<optimized out>) at ./game.h:108 108 { return mCurrentMap; } (gdb) bt 0x.. in Game::getCurrentMap (this=<optimized out>) at ./game.h:108 Ea::PlayerRecv::processMapMask (msg=...) at net/ea/playerrecv.cpp:242 **** mana/plus!108
2024-09-23Show MP bar below HP barewew ukek4-4/+49
Adds a light blue bar for MP below player's HP bar. It shows only if M.Atk is above 0. I didn't add a checkbox to the settings to disable this, let me know if I should. Squashed with: * Sneak in another TODO * Sneak in a TODO **** mana/plus!68 Co-authored-by: Fedja Beader <fedja@protonmail.ch>
2024-09-20Move move-specific keybinds from basic to move section of SETUPFedja Beader2-18/+18
Move to target & move to target type intentionally kept in basic's targetting section. **** mana/plus!103
2024-09-19Rename server types - Test_User spent time figuring out why herc doesen't ↵Fedja Beader1-3/+3
work for ML Squashed with: * Sync with last comment (Evol->Evol2) * Another rename, to reflect TMW->Manasource rebrand (maybe?) **** mana/plus!79