summaryrefslogtreecommitdiff
path: root/src/net
AgeCommit message (Collapse)AuthorFilesLines
10 daysFix packet limiter file being updated for no reasonFedja Beader1-4/+7
Prolific use of immediate constants strikes again. Side note: why are these limits not in clientdata? **** mana/plus!168
2025-04-03Fix wrong read of clif_GM_kickack packetFedja Beader8-13/+25
2024-08/01/#Debug.log:[14:25:43] Wrong actual or planned inbound packet size!. Packet id: 205(0xcd), Planned size: 3, Actual size: 6 2 bytes packet id + 1 byte flag = 3 2 bytes packet id + 4 byte flag (wrong) = 6 Squashed with: * Separate processKickAck handler for eathena * Move ea's adminrecv and its sole handler processKickAck into TMWA namespace * Revert "Fix wrong read of clif_GM_kickack packet" This would break TMWA packet processing, as @thorbjorn pointed out. This reverts commit efe43bac4de90b3e427d985b77cb3dd3206bcf9d. **** mana/plus!148
2025-03-30Undefine WRONGPACKETSIZE macro. Even more so as it uses local varsFedja Beader1-1/+2
**** mana/plus!147
2025-03-30processTradeResponse: Fix a potential early exit before full packet is readFedja Beader1-1/+2
Not sure how to trigger this one, couldn't do it with a few simple tests. **** mana/plus!149
2025-03-30processTradeItemAddResponse: fix early exit before full packet is consumed.Fedja Beader1-2/+3
2025-03/22/#Debug.log-[19:38:37] Wrong actual or planned inbound packet size!. Packet id: 433(0x1b1), Planned size: 7, Actual size: 4 2025-03/22/#Debug.log:[19:38:52] You picked up 1 [@@760|Overlord's Helmet@@]. **** mana/plus!146
2025-01-29Trim too much newliningFedja Beader2-38/+10
Pointless change, I know. **** mana/plus!115
2025-01-28Fix typo: opitons -> optionsFedja Beader2-10/+10
**** mana/plus!114
2024-10-11Fix switchmap during switch character crash (@toevent)Fedja Beader1-1/+6
use @toevent, then switch character (and stay on character screen). Thread 1 "manaplus" received signal SIGSEGV, Segmentation fault. 0x.. in Game::getCurrentMap (this=<optimized out>) at ./game.h:108 108 { return mCurrentMap; } (gdb) bt 0x.. in Game::getCurrentMap (this=<optimized out>) at ./game.h:108 Ea::PlayerRecv::processMapMask (msg=...) at net/ea/playerrecv.cpp:242 **** mana/plus!108
2024-08-28Further improve skill error handling and messages.Fedja Beader1-57/+41
Squashed with: * Appease linters + more reformat * Further improve skill error handling and messages. 24751878 "Improve skill error messages." added trailing dots only on the second branch. This adds missing dots on the first one as well as compacts the logic. **** mana/plus!93
2024-08-28Remove silly msg.read* duplicationFedja Beader11-100/+46
& shaves ~5KB from debug binary. previd=""; while read -r line; do if [[ $line =~ .*"msg.read"[^\"]*"\""([^\"]*).* ]]; then id="${BASH_REMATCH[1]}"; if [[ "$id" == "$previd" ]]; then printf "%s\n" "$line"; fi; previd="$id"; fi; done < <(grep -r 'msg.read.*' src/net/) **** mana/plus!91
2024-08-21Fix skill fail packet handling causing nullptr crash when switching charactersFedja Beader1-2/+6
How to reproduce: spam emote then quickly switch char Thread 1 "manaplus" received signal SIGSEGV, Segmentation fault. SkillDialog::getSkill (this=0x0, id=id@entry=1) at gui/windows/skilldialog.cpp:805 0 SkillDialog::getSkill (this=0x0, id=id@entry=1) at gui/windows/skilldialog.cpp:805 1 EAthena::SkillRecv::processSkillFailed (msg=...) at net/eathena/skillrecv.cpp:302 ... **** mana/plus!92
2024-05-16Refactor loadFromLogFile calls into ChatTab contructorFedja Beader4-8/+0
This has the side effect that now #Debug history is also loaded. **** mana/plus!84
2024-05-09Fix guild lvl-up packet parsing AND change password causing client exit in MLFedja Beader1-3/+1
What happened: 1) herc evol sends 0x100 as packet ID offset 2) 0x100 is added to 0x0062 of SMSG_CHAR_PASSWORD_RESPONSE 3) SMSG_CHAR_PASSWORD_RESPONSE is then inserted into 0x162 slot of packet map, shadowing SMSG_GUILD_SKILL_INFO 4) on guild lvl-up, server sends this in SMSG_GUILD_SKILL_INFO 5) ManaVerse exits in confusion. Note 1: due to popupmenu paste not working in change password dialog, tested password change only with invalid old password, which worked (opened error dialog instead of client exiting). Note 2: Some packet handlers are bound using &Ea::LoginRecv prefix, this one had &LoginRecv and this was kept this way (uses vtable lookup?). ~~TODO: SMSG_CHAR_PASSWORD_RESPONSE seems to be something about password changes, but I could not find this packet either in TMWA or herc. Still, I need to test if these still work on all active servers~~ Tested. Squashed with: * Fix exit on password change, too * Fix guild lvl-up packet parsing causing client exit in ML **** mana/plus!81
2024-04-27deduplicate branchesFedja Beader1-12/+7
2024-04-27Correct ommision of 0 in hexadecimal format specFedja Beader1-1/+3
2024-04-27Fix "Show items" (equipment display on other players)Fedja Beader2-3/+2
See #73 for discussion Squashed with: * Fix mana pearl showing in arrows slot in Classic * Fix off-by-one. Was causing Old Towel to render in torso slot in ML. **** mana/plus!78
2024-04-09Fix all alignment warnings/errors.Fedja Beader1-1/+2
Other addButton sections intentionally left misaligned as a test for future fix in nsiqcppstyle. .. why does it not complain about every such block?
2024-03-25Typofix Guil -> Guild and insert AndFedja Beader6-20/+20
See merge request mana/plus!64
2024-03-11Remove last-login(time) from char select window.Fedja Beader3-5/+6
No server in use still sends that field. **** Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org>
2024-03-11TypofixFedja Beader2-2/+2
**** Approved-by: Jesusalva Jesusalva <jesusalva@themanaworld.org> Approved-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
2024-02-16Client rebranding: Partly import changes from !28Jesusalva Jesusalva2-4/+6
Co-Authored-By: jak1 <jak1@themanaworld.org> Co-Authored-By: jesusalva <jesusalva@themanaworld.org> Co-Authored-By: Fedja Beader <fedja@protonmail.ch>
2024-02-09Update copyright headers up to 2023Jesusalva Jesusalva454-454/+908
2023-04-07fix formatingjak11-6/+6
2023-04-07added missing cstdint includejak15-0/+16
2023-04-07fixed curl deprecationjak12-11/+49
2022-12-27Add mobinfo command to popup menuccc1-1/+2
2022-12-27increase trade window items to 20ccc1-1/+1
2022-12-18disable SSL for downloads, since Windows\' OpenSSL doesnt support it.jak11-0/+5
2021-06-06added exitcode 7 to unique sessions (-S)jak12-0/+32
2021-04-13moved all skillbased errors to debugChatTabjak11-2/+8
2020-05-07Fix code style after merged switch port codeAndrei Karas1-2/+4
2020-04-25add "SAVE_PASSWORD" define optioncpasjuste1-5/+13
2020-03-13Fix alternate ip address for char and map servers [ci skip]Andrei Karas2-0/+2
2020-02-23Fix some code style issuesAndrei Karas1-1/+1
2019-10-16Fix code style, ignore some warning in clang-tidyAndrei Karas3-5/+5
2019-08-19Add new shuffle packetsAndrei Karas3-0/+1156
2019-08-19Update shortcuts related packets for zeroAndrei Karas3-2/+17
2019-08-19Update packet SMSG_BEING_HAT_EFFECTSAndrei Karas1-4/+11
2019-08-19Update packet SMSG_RANKS_LISTAndrei Karas3-9/+43
2019-08-19Update packet SMSG_HOMUNCULUS_INFOAndrei Karas3-0/+96
2019-06-26Update packet CMSG_SET_SHORTCUTSAndrei Karas6-1/+13
2019-06-26Update packet CMSG_SHORTCUTS_ROW_SHIFTAndrei Karas6-6/+28
2019-06-26Update packet SMSG_PLAYER_SHORTCUTSAndrei Karas3-8/+60
2019-06-24Fix code styleAndrei Karas2-3/+1
2019-05-18Fix code styleAndrei Karas11-26/+27
2019-05-16Remove extra include from generalhandler.cppAndrei Karas1-1/+0
2019-05-15Remove extra unused attribute in gamerecv.cppAndrei Karas1-1/+1
2019-05-15Change protocol version to 26Andrei Karas1-1/+1
2019-05-15Fix special card constants for clients with item id with size 4Andrei Karas1-1/+1
Also drop support for 65535 item id on old packet versions.
2019-05-15Fix different server packets for packet versions where item id size was changedAndrei Karas1-0/+46
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2025-04-24 05:12:45 +0000