summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
3 daysGameModifiers: use descriptive parameter names + reformat + DOCUMENTgamemodifiers_clarity2Fedja Beader2-42/+71
+ shift one argument's position in changeMode(...)
3 daysUse descriptive argument names for GameModifiers macrosgamemodifiers_clarityFedja Beader2-26/+26
+ slight reformat One shift too little
6 dayslogger.h: de-duplicate __attribute__(__format__(..)) ifdefsFedja Beader4-67/+48
Squashed with: * Rename - it's member shift, not printf shift * So it seems that CILK PLUS either ignores the this argument of member functions or already considers it on its own. Besides.. is CILK PLUS even relevant today? Whatever.. Plus, deduplicate some more functions ..should this attribute be moved to its own file? * Correct indents * logger.h: de-duplicate __attribute__(__format__(..)) **** mana/plus!163
7 daysReformat ActorManager::checkForPickup for (visual) consistency with similar ↵Fedja Beader1-6/+14
blocks in pickup search functions This block repeats many times.. but cannot be de-duplicated without that pesky search for empty string. perhaps I should make an (inline) function that takes allowAll and the item or a scoped functor that does the lookup in constructor. **** mana/plus!166
7 daysLimit nearby pickups to actual nearby area (3x3)Fedja Beader1-4/+2
Why 6? 2*2 + 1*1 is still < 6, so this allowed you to pickup items 2 tiles away. A bug. Test in ML: can pickup in 5x5 area with Quick option selector set to 3x3. Test in TMW: can only pickup in 3x3 area regardless of this setting. **** mana/plus!167
7 daysRemove remnants of unused --enable-commandlinepassword configure option.Fedja Beader3-44/+0
Addendum to 437258c4 / "Remove -enablecommandlinepassword necessity" **** mana/plus!156
7 daysML: turn to face target when attacking and server-side attack is off.Fedja Beader1-3/+2
Git blame for this says that Hercules does this on its own, but this is only true if server side attack is enabled. Using that setting results in archers being warped into targets, so its use is discouraged. End of unit_attack_timer_sub in Hercules:src/map/unit.c has unit direction updates gated on ud->state.attack_continue. **** mana/plus!160
7 daysFix packet limiter file being updated for no reasonFedja Beader1-4/+7
Prolific use of immediate constants strikes again. Side note: why are these limits not in clientdata? **** mana/plus!168
14 daysSave cpplint processing time by excluding generated files instead of ↵Fedja Beader1-11/+6
filtering results. **** mana/plus!158
14 daysun-newline too much newlining in actorsprite.cppFedja Beader1-21/+14
pathJoin indent is probably going to annoy a linter, got a patch ready if that happens. Not ideal but better than now. **** mana/plus!162
14 daysactorsprite.cpp: fix wrong indentFedja Beader1-4/+4
Linters! Wake up! **** mana/plus!161
14 daysAdd total weight accounting for the "shopping list" of herc shops.Fedja Beader2-9/+23
.. this will prevent the shopping list from going above your free carry weight, and thus the buy action failing. Note: I don't particularly like this implemention due to code repetition. But perfection is enemy of progress. TODO: 1) add the same for total price (other MR?) 2) maybe do a small refactor + add comments where necessary (other MR?) 3) ~~free weight display~~ done Squashed with: * buydialog: Add free weight display to money label + fix free weight going below 0 **** mana/plus!152
14 daysExclude attributes when scanning for translatable stringsFedja Beader2-11/+2
attributes such as __attribute__((fallthrough)) Issue found in mana/plus!163 **** mana/plus!164
2025-04-06Refactor ActorManager::validateBeing()Fedja Beader2-6/+40
Squashed with: * More docs for validateBeing * addendum documentation for validateBeing **** mana/plus!154
2025-04-06configure: report final CXXFLAGSFedja Beader1-0/+1
**** mana/plus!157
2025-04-06findNearestLivingBeing: do cheap bb check before set lookups or pathfinderFedja Beader1-14/+20
bb= bounding box **** mana/plus!145
2025-04-06findNearestLivingBeing: move (unknown) cheap check before set lookupFedja Beader1-6/+6
seems to skip beings with info if stopattack is active or if they are marked as unselectable (like hammocks in ML)... huh? **** mana/plus!145
2025-04-06findNearestLivingBeing: remove redundant branchFedja Beader1-16/+6
as without filtering, priority and closestPriority are always the same **** mana/plus!145
2025-04-06findNearestLivingBeing: closest* are always set to something sensible,Fedja Beader1-14/+3
making special handling before first suitable being is found unnecessary. **** mana/plus!145
2025-04-06findNearestLivingBeing: search priorityMobsMap at most once per being (down ↵Fedja Beader1-19/+15
from 3x) Note: the filter used priorityMobs (instead of priorityMobsMap). The former seems to be the std::set variant of the latter, but I can't find where either are filled. It does work in practice, however... **** mana/plus!145
2025-04-06findNearestLivingBeing: rename index -> closestPriorityFedja Beader1-6/+6
**** mana/plus!145
2025-04-06findNearestLivingBeing: only update closestBeing if it satisfiesFedja Beader1-20/+17
distance criteria. This should also resolve a theoretical bug if there is a non-ignored being within range, but something out of range has priority Cleanup addednum: rename d to distSq **** mana/plus!145
2025-04-06Clean-up ActorManager::findNearestLivingBeingFedja Beader1-13/+16
This resolves at least three instances where squared distance was compared with non-squared one, two cases of maxDist and no squaring of getDistance result (which was then compared with squared distance). **** mana/plus!145
2025-04-03Fix wrong read of clif_GM_kickack packetFedja Beader10-17/+29
2024-08/01/#Debug.log:[14:25:43] Wrong actual or planned inbound packet size!. Packet id: 205(0xcd), Planned size: 3, Actual size: 6 2 bytes packet id + 1 byte flag = 3 2 bytes packet id + 4 byte flag (wrong) = 6 Squashed with: * Separate processKickAck handler for eathena * Move ea's adminrecv and its sole handler processKickAck into TMWA namespace * Revert "Fix wrong read of clif_GM_kickack packet" This would break TMWA packet processing, as @thorbjorn pointed out. This reverts commit efe43bac4de90b3e427d985b77cb3dd3206bcf9d. **** mana/plus!148
2025-04-03Typofix unused function OnlinePlayer::getStatus()Fedja Beader1-1/+1
**** mana/plus!153
2025-04-03Re-tag jobs according to discussion in mana/appimg-builder!6Fedja Beader1-62/+4
**** mana/plus!155 Approved-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
2025-03-30Remove weird/unnecessary newlining of __VA_ARGS__ in checkutils.hFedja Beader1-6/+3
**** mana/plus!150
2025-03-30Add free weight indication to mini status barFedja Beader2-6/+16
Squashed with: * statuswindow: I like this way better **** mana/plus!151
2025-03-30Undefine WRONGPACKETSIZE macro. Even more so as it uses local varsFedja Beader2-4/+2
**** mana/plus!147
2025-03-30processTradeResponse: Fix a potential early exit before full packet is readFedja Beader1-1/+2
Not sure how to trigger this one, couldn't do it with a few simple tests. **** mana/plus!149
2025-03-30processTradeItemAddResponse: fix early exit before full packet is consumed.Fedja Beader1-2/+3
2025-03/22/#Debug.log-[19:38:37] Wrong actual or planned inbound packet size!. Packet id: 433(0x1b1), Planned size: 7, Actual size: 4 2025-03/22/#Debug.log:[19:38:52] You picked up 1 [@@760|Overlord's Helmet@@]. **** mana/plus!146
2025-03-24README.md: clarify that clicking on badge takes one to last good build.Fedja Beader1-2/+2
2025-03-13Clean-up and optimise ActorManager::findMostDamagedPlayerFedja Beader1-15/+21
Cheaper checks reordered to be checked first, removed squared root. **** mana/plus!144
2025-03-13Show quantity for item qty 1 in limited stock shopsFedja Beader1-1/+1
(no quantity display reserved for unlimited stock shops) Depends on !140 due to merge conflicts. **** mana/plus!141
2025-03-10Speedup ActorManager::findNearestByName by testing cheap bounding box ↵Fedja Beader1-9/+8
distance before (potentially) asking pathfinder. Pathfinder may get called in the validateBeing() call, can't tell yet. Squashed with: * Fix linter This test and the below static_cast looks like dynamic_cast should've been used. **** mana/plus!143
2025-03-10Cosmetic cleanup of ActorManager::pickUpNearestFedja Beader2-13/+13
Squashed with: * Fix lint.. just revert previous state, I'll deal with it when I make things pass Positions **** mana/plus!142
2025-03-10Slight cleanup in shopitem.cppFedja Beader1-6/+8
**** mana/plus!140
2025-03-05Rename --without-manaplusgame to --without-gameclientFedja Beader26-202/+202
@jesusalva asked what to rename it to, here: https://forums.themanaworld.org/viewtopic.php?t=21691 Squashed with: * Rename --without-manaversegame to --without-gameclient This makes the most sense, I think. Jes agrees, too. * Rename --without-manaplusgame to --without-manaversegame Split off from !45: Rename the program from ManaPlus to ManaVerse. **** mana/plus!138 Co-authored-by: jak1 <jak1@themanaworld.org>
2025-03-05Change follow-parent default to true (Fix #80).Fedja Beader1-1/+1
Reported by Thorbjorn **** mana/plus!129 Approved-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
2025-03-05Rename manaplus source directories and headers to manaversejak120-49/+49
Split off from mana/plus!45: "Rename the program from ManaPlus to ManaVerse." +POTFILES.in CI fix **** mana/plus!132 Co-authored-by: Fedja Beader <fedja@protonmail.ch>
2025-03-05Remove pointless one-line StatusWindow::addTabBasic() functionFedja Beader2-10/+3
**** mana/plus!139
2025-03-01Report missing/unknown attr fields in clientdata stats.xmlFedja Beader1-4/+8
This makes sure that ml/clientdata!180 never happens again via message in Debug tab. The legacy numeric ID method could be deprecated. Maybe after release. The client uses full attribute names since 2016. **** mana/plus!137
2025-02-26Rename log file manaplus.log -> manaverse.logjak16-12/+12
(Fedja) I'm suspecting that some CI will break on this. Split off from !45: Rename the program from ManaPlus to ManaVerse. **** mana/plus!135 Co-authored-by: Fedja Beader <fedja@protonmail.ch>
2025-02-26StatDB: deduplicate loadBasicStats(...) and loadStats(...)Fedja Beader1-47/+15
**** mana/plus!136
2025-02-26Remove stray continue, loop has no code outside of conditional branches.Fedja Beader1-1/+1
Tested as part of !136, pushed to master
2025-02-25Rename AttributesEnum::find to ::contains to match its meaningFedja Beader3-4/+4
**** mana/plus!134
2025-02-24Add POTFILES.in updater check to linter CI job.Fedja Beader4-5/+49
while processing mana/plus!132 I spotted what looked like an ommision of several src/progs/{manaplus,manaverse} files from POTFILES.in, but as it turned out, they have no strings marked for translation (start with "_("). Squashed with: * Just force LC_COLLATE=C and commit POTFILES.in changes required to make this happen. Don't know how to repro CI's sorting locally and it's pointless as my local sort is clearly wrong. See traderecv.cpp's position for why. * The correct locale variable to set should be LC_COLLATE, which is probably set by LANG on all platforms and so this will fail, again. * sort is still not preserving the order of files :/ * Ensure the order of files remains the same regardless of platform. * POTFILES update to pass CI :) **** mana/plus!133
2025-02-24added manaverse' copyright line to src/jak132-0/+32
Split from mana/plus!28 and rebased on master by specing. **** mana/plus!131
2025-02-24updated copyright -2020 for manaplusjak132-32/+32
In theory split out from mana/plus!28, in practice I (specing) just ran sed myself instead of bothering with splitting out changes. **** mana/plus!130
2025-02-22Update README.md & READMEFedja Beader4-65/+66
Squashed with: * Add build instructions link * CMake is unsupported (for now) * Change IRC link to irc-only channel. * Update text-only README to match * Make the point clearer. And, Bitbucket is dead by now? * Nah, I'll leave the strange statement about licensing and bad platforms in, for now. It's got a point! * Remove strange statement about licensing and bad platforms * Update note, change in-game support text * RIP FreeNode * Fix fix + add in-game "contact" * Reorganise the support section * Remove some duplicates and reword the command help section (which should probably be removed. This is not the 1985 any more) * Comment out nonfunctional CI badges * reorder builds and CI status * Remove version info.. it's 6 years old anyways. Wait... 6 years since last release?! * Shorten the CI status badges * Update main CI status button to point to pipelines page * Try more compact form on a single line (like before) * Add more direct download links when clicking CI status buttons * Add myself to AUTHORS * Change CI link to point to TMW gitlab + remove undress from help.. players don't need that. * Fix forum link - was pointed to general player talk and not https. **** mana/plus!127
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2025-04-21 18:27:53 +0000