summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2025-02-22Set C++11 as default C++ standardFedja Beader13-59/+60
Autoconf manual states that CXXFLAGS is a user variable and should not be overriden, so I did not use AX_APPEND_COMPILE_FLAGS for this. Thus, there are no checks if the compiler supports it, but also the builder can override this flag by passing another flag that overrides it on the command line. Okay, this is now way too theoretical. Indeed, the override happens with ./configure 'CXXFLAGS=-std=c++17' (both flags in final command line) Do note: - The standard was not explicitly set for some builds (thus compiler default was used) - The default on my own box is C++17 - I'm setting C++11 as that's required by my previous change. Upgrade to C++17 is deferred to until it becomes required. - The use of CPPFLAGS could be reviewed... they may be used incorrectly (instead of CXXFLAGS). I would really like to get all the builders going before requirements are raised. - CI cleanup would be nice - wish 4144 would return. **** mana/plus!128
2025-02-20Convert navigateTo to take a Position instead of two integers.Fedja Beader7-59/+54
Tile coordinates dance in pairs, so let's pair them up. also grows exe size by about 3K, hope this will go away when the rest is converted to Position as well. Note: on my local debug build only. Not on gcc10 CI. Squashed with: * Should it be mNavigateDest or mNavigateTo? Hmm, the jury is still out there ... **** mana/plus!116
2025-02-12Fix erroneous call in find that resulted in cpplint processing only *.cc filesFedja Beader1-10/+14
https://git.themanaworld.org/mana/plus/-/jobs/183682#L81 the ORs were not groupped together in the find call, resulting in only *.cc files being processed. > Total errors found: 3463 Well, this will take a while to fix :disappointed: . Squashed with: * Trim unnecessary excludes, for there is no matching error to exclude. Fine-tune the remaining ones. * The grep below wasn't working as find exited nonzero and code that was supposed to handle that wasn't working as well as expected **** mana/plus!126
2025-02-12Fix remaining cpplint error that was introduced while trying to satisfy ↵Fedja Beader1-5/+3
line-length limits. Introduced in mana/plus!88 and exposed in mana/plus!126 Pushing directly to master from top of !126 before merging 126.
2025-02-10Upgrade cpplint to latest releaseFedja Beader2-3/+6
+Update CI job from Debian Buster to Bullseye. Buster's Py3.7 is too old for cpplint. Squashed with: * Update linters job to debian bullseye * Force use of python3 * Try upgrade to python3. Other scripts will probably break. **** mana/plus!124
2025-02-10Properly fail the nsiqcppstyle part of the linters CI jobFedja Beader3-9/+19
From updating to buster->bullseye in !124: nsiqcppstyle was silently failing, too >_> Squashed with: * I always forget newlines at end of printfs. * Add sore thumb to remind me of untreated wounds beneath bandages * nsiqcppstyle was silently failing, too >_> *Explicitly call python2 *Grep will exit non-zero if it finds nothing. *fix* **** mana/plus!125
2025-02-10Properly fail the failing cpplint.py part of linters CI jobFedja Beader2-9/+15
Squashed with: * Split out change * Let's get this to properly fail, first. put unfiltered file name into a variable and append .log to make it viewable online + direct URL for cpplint.py like before IT's LOGFILE, not ERRFILE.. sigh Nevermind, it actually is ERRFILE + add unfiltered version to init Downgrade version, py3 later Let's get unfiltered log to print if find fails Related: mana/plus!122 **** mana/plus!123
2025-02-10Fix cpplint.py part of linters CI jobFedja Beader1-2/+4
Google has removed cpplint.py three weeks ago and this has been silently failing since then. See also mana/plus!123 **** mana/plus!122
2025-02-03Fix unable to switch to another character after -D (chooseDefault) is used.Fedja Beader1-0/+1
Addendum to !89 (and !117) Amusing: putting this line before the .clear() grows the exe by 40 bytes. **** mana/plus!118
2025-02-03Typofix: mShowNavigePath -> mShowNavigatePathFedja Beader2-5/+5
**** mana/plus!119
2025-02-03Trim whitespace at end of lineFedja Beader1-1/+1
**** mana/plus!120
2025-02-03Expose exe in artifacts and report its size in logFedja Beader2-0/+14
Sometimes we're curious about the impact of a change on code size, this might satisfy us. **** mana/plus!121
2025-01-29Trim too much newliningFedja Beader2-38/+10
Pointless change, I know. **** mana/plus!115
2025-01-28Fix typo chec -> checkFedja Beader3-5/+5
**** mana/plus!113
2025-01-28Fix typo: opitons -> optionsFedja Beader4-14/+14
**** mana/plus!114
2024-10-12Add dark magic to text command magic schools listFedja Beader2-4/+10
Further idea: a lot of these models are wrappers around a string options array. Maybe convert the classes into a single template class taking an array parameter? **** mana/plus!111 Approved-by: Led Mitz <smoothshifter@tuta.io>
2024-10-11Move trade filtering setting to immidiately under trade tab & fix ↵Fedja Beader1-10/+9
description/tooltip. **** mana/plus!105
2024-10-11Introduce a kludge to deduplicate server type strings.Fedja Beader2-39/+23
**** mana/plus!104
2024-10-11Add confirmation dialog for leaving guildFedja Beader3-2/+39
Memory may not be freed properly, also code is IMO ugly. See !109 for the other way of implementing this (unrelated). Was done in socialWindow as the join confirmation is already there. **** mana/plus!110
2024-10-11Remove redundant nullptr checkFedja Beader1-1/+1
Curiously, this increases -g -O2 exe size by 96 bytes, but disassembly dump around this code is the same (redundant check was already optimised out?) **** mana/plus!106
2024-10-11Fix switchmap during switch character crash (@toevent)Fedja Beader1-1/+6
use @toevent, then switch character (and stay on character screen). Thread 1 "manaplus" received signal SIGSEGV, Segmentation fault. 0x.. in Game::getCurrentMap (this=<optimized out>) at ./game.h:108 108 { return mCurrentMap; } (gdb) bt 0x.. in Game::getCurrentMap (this=<optimized out>) at ./game.h:108 Ea::PlayerRecv::processMapMask (msg=...) at net/ea/playerrecv.cpp:242 **** mana/plus!108
2024-09-23Show MP bar below HP barewew ukek4-4/+49
Adds a light blue bar for MP below player's HP bar. It shows only if M.Atk is above 0. I didn't add a checkbox to the settings to disable this, let me know if I should. Squashed with: * Sneak in another TODO * Sneak in a TODO **** mana/plus!68 Co-authored-by: Fedja Beader <fedja@protonmail.ch>
2024-09-20Move move-specific keybinds from basic to move section of SETUPFedja Beader2-18/+18
Move to target & move to target type intentionally kept in basic's targetting section. **** mana/plus!103
2024-09-19Rename server types - Test_User spent time figuring out why herc doesen't ↵Fedja Beader1-3/+3
work for ML Squashed with: * Sync with last comment (Evol->Evol2) * Another rename, to reflect TMW->Manasource rebrand (maybe?) **** mana/plus!79
2024-09-19Horizontally extend the login screen server type selection boxFedja Beader1-1/+9
Split from mana/plus!79
2024-09-08Quote all the variable expansionsFedja Beader1-60/+60
Squashed with: * More quoting, but these are likely unnecessary [^"x]$[a-zA-Z] [^"]x$[a-zA-Z] **** mana/plus!98
2024-09-08Refactor outfit saving logicFedja Beader1-13/+23
Shaves some bytes from exe, too **** mana/plus!102
2024-09-07There is no need to first pack this into a vector and then into arrayFedja Beader1-17/+4
TODO: are all these casts actually required? SMH **** mana/plus!101
2024-08-28Fix off-by-one causing archer attack mode to approach to within attack range - 1Fedja Beader3-17/+18
**** mana/plus!96
2024-08-28Further improve skill error handling and messages.Fedja Beader1-57/+41
Squashed with: * Appease linters + more reformat * Further improve skill error handling and messages. 24751878 "Improve skill error messages." added trailing dots only on the second branch. This adds missing dots on the first one as well as compacts the logic. **** mana/plus!93
2024-08-28Remove silly msg.read* duplicationFedja Beader11-100/+46
& shaves ~5KB from debug binary. previd=""; while read -r line; do if [[ $line =~ .*"msg.read"[^\"]*"\""([^\"]*).* ]]; then id="${BASH_REMATCH[1]}"; if [[ "$id" == "$previd" ]]; then printf "%s\n" "$line"; fi; previd="$id"; fi; done < <(grep -r 'msg.read.*' src/net/) **** mana/plus!91
2024-08-28Squash gcc8 -Wformat-y2k warningFedja Beader1-1/+6
* Run gcc8 job again in this MR * Squash the %c strftime gcc warning **** mana/plus!100
2024-08-27Show mail expiry timeFedja Beader3-1/+7
Server does not communicate sent time.. or it did, until 2017 ?? See src/map/clif.c #if PACKETVER >= 20170419 The RODEX_EXPIRY constant seems not to be communicated either, preventing us from deducing send time from expiry time. **** mana/plus!90
2024-08-27Redundant. I don't think the time savings due to not calculating distance, ↵Fedja Beader1-24/+3
if any, are worth it. In fact, this might even save some time. Calculating distance may be faster than iterating through memory twice. **** mana/plus!95
2024-08-27Sunset/disable some CI jobs to reduce CI load, speed up CI and drop support ↵Fedja Beader1-4/+14
for obsolete platforms. Move some others to only master... Sunset/disable some CI jobs to reduce CI load. Move some others to only master branch as I deem them unlikely to fail if others work. gcc7 is direct replaced by gcc8 (both really obsolete these days) gcc7-default -> gcc10-default (same) gcc10 game/dyecmd only ... no need to test if these two special build options work on every ommit Some special builders are made master-only pending further review. Squashed with: * Fix: only: has to be an array or .. * Sunset/disable some CI jobs to reduce CI load. Move some others to only master branch as I deem them unlikely to fail if others work. gcc7 is direct replaced by gcc8 (both really obsolete these days) gcc7-default -> gcc10-default (same) gcc10 game/dyecmd only ... no need to test if these two special build options work on every ommit Some special builders are made master-only pending further review. **** mana/plus!99
2024-08-24Simplify itempickup codeFedja Beader1-3/+4
**** mana/plus!94
2024-08-22POSIX test does not support ==Fedja Beader1-42/+42
Reported by Skyflare **** mana/plus!97
2024-08-21Fix skill fail packet handling causing nullptr crash when switching charactersFedja Beader1-2/+6
How to reproduce: spam emote then quickly switch char Thread 1 "manaplus" received signal SIGSEGV, Segmentation fault. SkillDialog::getSkill (this=0x0, id=id@entry=1) at gui/windows/skilldialog.cpp:805 0 SkillDialog::getSkill (this=0x0, id=id@entry=1) at gui/windows/skilldialog.cpp:805 1 EAthena::SkillRecv::processSkillFailed (msg=...) at net/eathena/skillrecv.cpp:302 ... **** mana/plus!92
2024-08-18Make code more readableFedja Beader1-17/+29
g **** mana/plus!77
2024-08-17Limit shop's Max button to available carry weightFedja Beader1-1/+15
**** mana/plus!88
2024-07-05Fix cart item add failure messages [skip ci]Fedja Beader1-2/+2
2024-06-25re-integrate windows CIFedja Beader1-2/+14
- [x] integrate docker-windows-builder with or instead of the existing disabled MXE jobs - [x] fix rebranding breaking windows CI (already pushed to master) Part of #71 Squashed with: * $CI_COMMIT_BRANCH is unset in merge request pipelines * Too much text * Cleanup now that the builder branch is merged * Revert "Disable unnecessary builders" This reverts commit f4820e05439792a02601dfef0e2e2ad148615f1f. * Try depend strategy + de-hardcode stuff cleanup * Use downstream branch created for this purpose (testring only, switch to master before merging) * Multi-project pipeline, attempt #1 missing stage definition * Disable back, comment why it doesen't work Forgot to disable the broken windows builder job * Does existing MXE job even work? Kinda doubt it, but after this you can't blame me for not trying (What's the purpose of windows-docker-builder if this works?) But lets try the *32 one as well * Disable unnecessary builders **** mana/plus!87
2024-06-24evol-client.icon missing was breaking windows build after "Remove data/evol"Fedja Beader1-1/+0
2024-05-29Switch "show chat history" into a line limit field and considerablyFedja Beader4-10/+14
raise default (5->100).
2024-05-29Raise default line limit 40->100. 40 is not even a screenful.Fedja Beader1-1/+1
2024-05-29Fix paste in registration windowFedja Beader2-9/+8
Addendum to cbab9d6d "Fix for login button" See also mana/plus!67 and mana/plus#64 **** mana/plus!86
2024-05-17Fix oddity introduced by 'Download mplint release instead of recompilingFedja Beader1-3/+0
every time' No error/warning? odd.
2024-05-16Refactor loadFromLogFile calls into ChatTab contructorFedja Beader8-16/+3
This has the side effect that now #Debug history is also loaded. **** mana/plus!84
2024-05-15Merge branch 'improved_controller' into 'master'Fedja Beader8-189/+413
Controller improvements See merge request mana/plus!52
2024-05-15Rename axis tolerance to joystick dead zone + reformat as per discussionFedja Beader1-6/+6
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2025-04-24 09:52:43 +0000