Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
Fixed various issues reported by coverity
|
|
Fixes #1240
Closes #1353 as merged
|
|
Fixes several -Wsign-compare issues
Signed-off-by: Haru <haru@dotalux.com>
|
|
min_level and max_level
Fixes several -Wsign-compare issues
Signed-off-by: Haru <haru@dotalux.com>
|
|
map_session_data::change_level_3rd to int
Fixes several -Wsign-compare issues
Signed-off-by: Haru <haru@dotalux.com>
|
|
Fixes several -Wsign-compare issues
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Affected functions: pc->nextbaseex(), pc->nextjobexp(), pc->thisbaseexp(), pc->thisjobexp(), pc->readparam()
- Fixes an accidental '+=' in pc->readparam() due to copy-paste failure, detected thanks to the const enforcement (luckily it had no current ill effects, since the value was 0)
Signed-off-by: Haru <haru@dotalux.com>
|
|
const sd
Removes some FIXME (and continues a chain reaction)
Fixes some of the many -Wsign-compare warnings
Signed-off-by: Haru <haru@dotalux.com>
|
|
Fixes a possible unsigned underflow (and changes the type of some unnecessarily unsigned variables to signed, such as pc->max_level[][])
Signed-off-by: Haru <haru@dotalux.com>
|
|
Fixes a buffer overflow
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
|
|
Also improve a bit cast end functions call.
|
|
Mostly stylistic changes. Cleaned up documentation.
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
|
|
|
|
- For compliance with gettext's .po file specifications
Signed-off-by: Haru <haru@dotalux.com>
|
|
Extend with new flag sc_config.txt
|
|
They should cancel each other, not prevent the usage (like Kyrie and
Assumptio)
Closes #1222 as merged
Signed-off-by: Haru <haru@dotalux.com>
|
|
to other.
Added interface member clif->sc_continue for already started effects.
|
|
Remove hardcoded visible effects from status.c and add visible flag into sc_config.txt
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Skill DB TXT files to LibConfig + converter
|
|
The conversion of 5 skill database files -
skill_require_db.txt
skill_unit_db.txt
skill_cast_db.txt
skill_castnodex_db.txt
and skill_db.txt
to Libconfig file skill_db.conf
a PHP CLI converter is included to read from the above mentioned files and create a skill_db.conf in the same directory.
|
|
Fixes #1345
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
|
|
Also disable all known default warnings if build bot option enabled.
|
|
Follow-up to ff75470f7085c3ca23a9b16be43881b6bc953345
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
inventory.
|
|
Wrong check prevent from using custom skills with id after guild skills.
|
|
Fix EXP modifiers to match aegis modifiers calclution.
|
|
|
|
|
|
- Now Renewal Level Penalty being calculated in pc_calcexp only
- Now Guild Tax is being paid after experience modifiers and not before
- Now Experience modifiers being calculated in right way as in aegis (Race modifiers -> PK modifiers -> Premium modifiers -> Buff modifiers)
|
|
The script->get_translation_file_name() is more robust (and actually
works) now.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
format string
- Strings passed to sprintf should use the _$() macro instead of _(), to
generate the .pot translation template with a directive to correctly
handle the % sign.
- Strings passed through _() are instead explicitly marked as regular
(non format) strings if they contain '%'.
Signed-off-by: Haru <haru@dotalux.com>
|
|
well)
|
|
- The `\r` character, in a `mes` dialog, is normally represented by the
client as a hard line-break.
- Since a client may have different requirements in line lengths (for
example using a font with different size or metrics), an user might
wish to ignore hard-wraps and let the client automatically soft-wrap
instead.
- If you want to hard-wrap (official default), keep the
SCRIPT_MES_STRIP_LINEBREAK define commented out.
- If you want to let the client soft-wrap automatically (may work better
for custom clients), uncomment it.
- Imprved HULD handling of `\r` (to avoid control characters in the
generated file)
- Please note that this requires cooperation by script writers:
* Each `mes` should contain one and only one sentence, possibly
without using the '+' concatenation (but, rather, sprintf).
* Two separate sentences (where a hard-wrap is required even for
soft-wrapped text) should always go into separate `mes` commands.
* Following the above two recommendations, also produces a better
quality translations .pot file.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|