Age | Commit message (Collapse) | Author | Files | Lines |
|
- Fixed some warnings we had missed.
- Improved -W cflag detection routines.
- Only use -Wshadow if it's actually useful.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Warnings detected thanks to Xcode's compiler settings (more strict by
default) and clang, warnings mostly but not only related to data sizes
on 64 bit systems, that were silenced until now by very lax compiler
settings.
- This also decreases by a great deal the amount of warnings produced by
MSVC in x64 mode (for the adventurous ones who tried that)
- Also fixed (or silenced in case of false positives) the potential
issues pointed out by the (awesome) clang static analyzer.
- Patch co-produced with Ind, I'm merging and committing in his place!
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Added Assert_ret, Assert_retv, Assert_retb, Assert_retr, working
similarly to the corresponding nullpo_ functions.
- Moved Assert-related macros to nullpo.h, since they share some
functions.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Removed unused, nonportable nullpo checks with formatted message
(related: eAthena r15245)
- Converted nullpo_chk to a macro, to make it easier on the llvm static
analyzer.
- Added more details to the nullpo_info reports (related: eAthena
r15246)
- Ensured that the nullpo check macros evaluate their pointer argument
once and only once, so that it's safe to use with expressions that
assign values or have side-effects.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- No functional changes. That's just the correct OS X file extension for
dynamic libs.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Special Thanks to Haru!
Signed-off-by: shennetsind <ind@henn.et>
|
|
|
|
Special Thanks to Haru
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Follow-up to 44c33fda3614d588e6bf6cee1cf884e98f1531f0.
- Also fixed some incorrect va_end calls that came up while debugging.
- Special thanks to Ind for his help debugging the problem.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Enabled plugin access to mapindex interface
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
which was broken 5 years ago in 13106, special Thanks to karazu, Angelmelody and kyeme.
Signed-off-by: shennetsind <ind@henn.et>
|
|
fixed as in, it now skips the thing entirely, matching official behavior and no longer affected by job-specific modifiers.
Thanks to Yommy.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Should fixe bugreport:7888, thanks to rosfus
http://hercules.ws/board/tracker/issue-7888-some-issue-crush-my-mapserver
- Special thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Fixed a memory leak (bugreport:7885), thanks to rosfus
http://hercules.ws/board/tracker/issue-7885-memory-leaks-found-at-20131205-20h31m31s-rev-13617/
Signed-off-by: Haru <haru@dotalux.com>
|
|
guild storage would remain locked when the operation failed, now it unlocks regardless of success.
Special Thanks to GrumpyPanda
http://hercules.ws/board/tracker/issue-7879-guild-storage-bug/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
- Removed duplicate code shared between script_hp_add and
script_parse_builtin.
- Improved error handling in script_hp_add to be on par with the
script_parse_builtin version.
- Added script->add_builtin function, providing a hooking point for
plugins (i.e. text editor syntax definition generators) to obtain the
builtin commands list.
- Special thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- It is now possible to build a plugin without adding it to the
Makefile, by using 'make plugin.my_plugin_name'.
- To have it built through 'make all' or 'make plugins', it is still
necessary to add it to the Makefile, as before.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Case-sensitive AegisName and Sprite ID lookups are now optional,
controlled by the case_sensitive_aegisnames battle config flag (you
can set it to "no" to restore the case insensitive behavior.)
- Special thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Special Thanks to Megasantos, Beret.
Follows up 098dbcf672e04657553b9f1629550e6bc8771af3
http://hercules.ws/board/tracker/issue-7883-reloaditemdb/
Signed-off-by: shennetsind <ind@henn.et>
|
|
|
|
- Fixed an issue that caused the quest list not to be sent to the map
server.
- Special thanks to Beret.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
- Improved memory usage of the quest log system. (saves up to 75kB per
online character). Fixes issue #133.
- Fixed various issues with quest entries disappearing from characters
without an apparent reason, or monster kill counters getting stuck -
the issues were caused by a de-synchronization between the two
parallel questlog arrays in map_session_data.
- Added some code documentation.
- Thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Updated to use official formulas from Aegis (for both success chance
and stolen zeny amount.)
- It now shows the correct stolen zeny amount in the battle log, rather
than showing the skill level.
- Made possible thanks to Yommy and Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
replaced pc_isuseitem 90overweight error message by its official version, added invent-full check for when trying to open packages/boxes, and modified mail getAttachment to fail when over 90% weight.
Special Thanks to kyeme.
http://hercules.ws/board/tracker/issue-7542-bug-when-weight-90/
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Follow up to c6c2ad187c386d8d27d3336dcbdd5a92555493d2
- Special thanks to Ind
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
flag was discarding elegible guild mates.
Special Thanks to kyeme.
http://hercules.ws/board/tracker/issue-7336-gvg-noparty-is-missing/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
Fixed EQI_SHADOW_ACC_L ability to produce bonuses, Special Thanks to rosfus, Angelmelody.
http://hercules.ws/board/tracker/issue-7866-eqi-shadow-acc-l-missing-effect/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Fixes bugreport:7810, thanks to Wend, kyeme, evilpuncker, jaBote, and
various other people I may be forgetting to mention
http://hercules.ws/board/tracker/issue-7810-disguise-script-command
- Due to the nature of this change, I'm leaving the deprecation messages
lingering around for a while more (as errors rather than warnings), to
make sure they won't pass unnoticed, in case you haven't yet updated
your custom scripts to comply with this.
- Special thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Any scripts using the wrong case, that were throwing deprecation
warnings until now, will become invalid.
- Related to bugreport:7810.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Assignment operators would not work correctly, or at all, when
followed by an expression (as opposed as a value).
- Fixes bugreport:7864, thanks to Lelouch, Ind.
- Added associativity tests for those operators to the self-test script.
- Added total error count to the self-test script (thanks to Lighta.)
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
- improved @makehomun -1 so that if the homun data hasnt been loaded it is requested.
- instances of private types (party/guild/char) no longer create channels, however global types still does (IOT_NONE).
- Fixed an issue with party/guild instance data not being freed when either is destroyed (Special Thanks to Yommy).
Signed-off-by: shennetsind <ind@henn.et>
|
|
pc_checkitem is now triggered by @reloaditemdb to ensure modified conditions are respected, also a performance boost that causes the itemlist/cartlist/storagelist/gstoragelist lookups to only be triggered on demand instead of on every teleport.
Closes #219
Fixed ancient monster ai bug that caused mobs to consider themselves elegible targets, which would waste status_check_skilluse and battle_check_target calls.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Extended to the fix to aggregated as well, as in val: [ y,x ]/{y,x}/(x,y,...)
Signed-off-by: shennetsind <ind@henn.et>
|
|
adjustment.
Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
|
|
- The .favorite field of newly added inventory items wasn't correctly
initialized to zero, potentially causing data loss (fixes
bugreport:7854, thanks to Vincent, GrumpyPanda).
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
Special Thanks to bgamez23, kyeme.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
|
|
Modified reflect code so that each reflection source can judge whether to apply or not, necessary for mechanics such as item-bonus reflect triggers even on autoguard while reflect shield does not.
Re-added that "reflect shield" overhead display which I mistakenly removed in fdb6de1aa34086fd4d22ae127437727f556cea3c. Added code to refrain damage numbers from overlapping in the client, which would render them illegible.
Special Thanks to kyeme, Yommy.
http://hercules.ws/board/tracker/issue-7792-safety-wall-reflect-bug-body-relocation-error/
Signed-off-by: shennetsind <ind@henn.et>
|