summaryrefslogtreecommitdiff
path: root/src/map/skill.h
AgeCommit message (Collapse)AuthorFilesLines
2018-07-24Added missing parameter to init_unit_layout_unknownDastgir1-1/+1
2018-07-19Replace item id shorts to int in map server.Andrei Karas1-1/+1
2018-06-12Changed returntype of skill_check_condition_castend_unknown.Dastgir1-1/+1
skill_check_condition_castend is terminated if returntype is true
2018-05-312012-2018 !Maytichai Saowa1-1/+1
2018-04-08Allow guild skills cooldown to continue when logged outGuilherme G. Menaldo1-3/+1
2018-02-10Clean up trailing whitespace and non-indent tabsHaru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
2018-01-25Implementation of Official Clan SystemMurilo Pereti Tavares1-0/+1
All official features work including the autokick for inactive members And the system is completely customizable.
2017-12-23Replace the use of skill_reproduce_db with AllowReproduce flagAsheraf1-2/+1
2017-11-24Allow using the skill DB accessors on non-skill attacks (skill_id = 0)Haru1-1/+5
This suppresses an assertion in the skill DB accessors when called with `skill_id = 0` (such as during normal attacks). In such case, they'll now return an appropriate zero value, as it happened before 2b4bfa5d0. Fixes #1909 Signed-off-by: Haru <haru@dotalux.com>
2017-11-18Merge pull request #1903 from Asheraf/skill_scaleHaru1-0/+1
Implement skill scale packet for client versions >= 20151223.
2017-11-16Implement skill scale packet for client versions >= 20151223.Asheraf1-0/+1
2017-11-05Reduce confusion between skill IDs and skill DB indexes (part 2)Haru1-2/+1
Remove MAX_SKILL in favor of MAX_SKILL_DB, when referring to the maximum skill DB index. This is opposed to MAX_SKILL_ID, the maximum skill ID. Signed-off-by: Haru <haru@dotalux.com>
2017-11-05Reduce confusion between skill IDs and skill DB indexes (part 1)Haru1-48/+50
Rewrite skill DB accessors to clarify the difference between IDs and indexes, and to report a backtrace to the console when an invalid ID is passed. The type of the skill_id and skill_lv arguments has been changed to int. Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Clarify some Job Class vs MapID confusion (1/2)Haru1-1/+1
This commit ensures that `sd->status.class` and related variables only contain Job Classes (i.e. the client-compatible values, where High Novice 4001) and are never checked against the bitmask-based MapID values. As a rule of thumb, from now on, when a variable is named `class`, it is intended to contain a Job Class ID and not a MapID. The type of such variable shall be a signed `int16` or `int`. To ensure that related third party code is also verified when this commit is merged, the variable `struct mmo_charstatus::class_ (i.e. `sd->status.class_`) is renamed to `class`. Some issues in related lines are also fixed, including: - A wrong check in the char server would prevent the correct detection of babies in code related to the family exp sharing. - Baby Arch Bishops would not be affected by Eucharistica. - A wrong check would cause the `questinfo()` script command not to display its information for most classes (except 1-1 classes). - Map IDs and Job Classes were mixed up in `itemdb_jobid2mapid()` and `itemdb_jobmask2mapid()` for 1-1 classes (causing currently no harm, since they just happen to coincide). - The Baby Sura class would not cause parties to be marked as containing a monk type character (for SLS Team Up purposes). - Baby Geneticists would bypass the cart check when trying to equip ammunitions. - Baby Mechanics would bypass the Mado Gear check when trying to equip ammunitions. - Transcendent Shadow Chasers would lose the Stalkers' ability to clone transcendent skills. Signed-off-by: Haru <haru@dotalux.com>
2016-10-28Fixed copyright year for 2016Lemongrass31101-1/+1
2016-10-22Implemented SU_SV_ROOTTWIST Skill.Dastgir Pojee1-0/+3
Duration: (5+(2*SkillLv)) seconds. Cannot be used on Boss Monsters. Effect is cancelled when Heaven's Drive or Trample is used. Enemies trapped on roots receive poison property damage.
2016-10-22Added Summoner Skills(in DB)Dastgir Pojee1-0/+45
Added Summoner SC ID's in status.h
2016-09-03Add some missing functions in skill.c into interface.Andrei Karas1-0/+3
2016-07-19Add skill atributes for allow moving while casting skill.Andrei Karas1-15/+17
New SkillInfo attributes: FreeCastReduced - allow move while casting with slowdown FreeCastNormal - allow move while casting with normal speed
2016-07-12Add into skill.c some handling for unknown skills/skill units.Andrei Karas1-0/+5
Also improve a bit cast end functions call.
2016-07-12Fix reading skill_db.confAndrei Karas1-0/+1
2016-07-09Fixed some warnings while compiling HPMHookingHaru1-14/+14
Signed-off-by: Haru <haru@dotalux.com>
2016-07-09Merge pull request #1333 from Smokexyz/SkillDBLibHaru1-6/+19
Skill DB TXT files to LibConfig + converter
2016-07-09SkillDB TXT to Libconfig + converterSmokexyz1-6/+19
The conversion of 5 skill database files - skill_require_db.txt skill_unit_db.txt skill_cast_db.txt skill_castnodex_db.txt and skill_db.txt to Libconfig file skill_db.conf a PHP CLI converter is included to read from the above mentioned files and create a skill_db.conf in the same directory.
2016-07-05Move static methods into interface in skill.cAndrei Karas1-0/+3
2016-03-20Dropped typedef from DBMapHaru1-6/+6
Signed-off-by: Haru <haru@dotalux.com>
2016-03-20Dropped typedefs from union DBKey and struct DBDataHaru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
2016-02-24Edited skill->changematerial() and skill->elementalanalysis() to use the new ↵Haru1-2/+3
struct itemlist - The skill-side code no longer depends on the client packet data layout. - Some data validation has been added. Signed-off-by: Haru <haru@dotalux.com>
2015-12-15Added GPL-compliant header to all sources and build scriptsHaru1-4/+20
Signed-off-by: Haru <haru@dotalux.com>
2015-08-26Fixed a faulty usage of sg->unit in land skill codeHaru1-2/+5
- Changed sg->unit and sg->unit_count into an explicit vector struct, to enforce the correct access. - Related: rathena/rathena#583 Signed-off-by: Haru <haru@dotalux.com>
2015-08-15HPM compatibility improvementsHaru1-5/+3
Improved compatibility, portability and standards conformance. - Since it is not possible to portably and reliably re-use the core's symbols in plugins, symbols are no longer exported unless explicitly required, in the UNIX builds. This mimics the Windows behavior and adds HPM compatibility to OSes such as FreeBSD. Credits to Andrei Karas for making this possible. - For convenience, it is no longer necessary to call GET_SYMBOL, since the plugin will automatically import all the available symbols when it's loaded, depending on the included headers. - Plugins are now supposed to include the "common/hercules.h" header before including anything else. Incluing common/HPMi.h, common/cbasetypes.h or conf/core.h is no longer necessary, as those are guaranteed to be automatically included by hercules.h. - HPM API version bumped to 1.1. Signed-off-by: Haru <haru@dotalux.com>
2015-07-25Reduce memory usage in HPM in skill.cAndrei Karas1-12/+16
2015-06-19Removed ".." from include directivesHaru1-6/+6
- Include directives are now directory-independent. - This will allow building plugins from other directories in future. Signed-off-by: Haru <haru@dotalux.com>
2015-05-31Follow up@027f124cbb96bb99d00bc31ad51345024edadf66malufett1-0/+1
Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-05-19Fixed some issues reported by coverity scan [3/3]Haru1-0/+2
- Automatically zeroed variables are now zeroed in the correct size, regardless of padding. - Special thanks to Ind. Signed-off-by: Haru <haru@dotalux.com>
2015-02-13Fixed Bug#8529malufett1-1/+1
-http://hercules.ws/board/tracker/issue-8529-npc-earthquake-damage-calculation-bugged-and-possibly-wrong/?gopid=24559#entry24559 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-01-12Fix uninitialized warning in skill.c.Andrei Karas1-1/+1
2015-01-12fix skills issue introduced in commit 5cdb3d12c4236e0c3a682e30fed96192d2c58188.Andrei Karas1-1/+1
2015-01-12Blocked compilation of plugins that use unavailable functionsHaru1-0/+2
- Rather than failing at runtime, plugins that try to access non-interfaced, unavailable functions or variables, will now show an error at compile-time. Signed-off-by: Haru <haru@dotalux.com>
2015-01-12Fixed Bug where skill timer is not properly terminated/clear when the caster ↵malufett1-1/+1
dies. -Thanks to GM Nihad. Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-01-10Extend skills.c for using custom skills from plugins.Andrei Karas1-0/+35
2014-11-16Whitespace cleanup (no code changes)Haru1-82/+82
This includes, and is not limited to: mixed or wrong indentation, excess whitespace (horizontal and vertical), misalignment, trailing spaces. Signed-off-by: Haru <haru@dotalux.com>
2014-10-18Fix bug:7454Michieru1-1/+0
* Official Icewall implementation and other fixes - Reverted all the icewall-related changes done in SVN r15777 and following as testing shows they aren't official and are actually pretty exploitable (bugreport:7412) - Instead implemented the official icewall characteristic that monsters can only leave an icewall cell to the west or south, the changes include: * The "sight" path check no longer checks for the current cell so standing on an icewall allows you to see/attack into any direction * The path finding will still ignore the current cell as before but the walk routine will not allow to walk east or north while standing on an icewall cell * This leads monsters in the situation where they go through an AI loop not allowing them to escape the icewall (if their target is north or east of them) * Monster in this situation will use idle skills and if they get attacked will use their rudeattacked skills if available, similar to traps like Spiderweb * Added a configuration icewall_walk_block that allows to configure how long a monster should go through the AI loop before the server allows it any movement, this "safety" system is official and seems to equal about 75 AI loops; if you want to disable the whole icewall system so that monsters don't get stuck in icewall at all, just set this to 0 * Here are videos from jRO showing how this system works: http://ragdo.blog56.fc2.com/blog-entry-763.html - Implemented the official calculation for "direction"; now you will be considered horizontal/vertical/diagonally aligned with a target cell in the exact same way as on official servers, this is for example used to determine whether an icewall or a firewall should be horizontal, vertical or diagonal; the only thing that is still unofficial is the default direction (officially always "west"); effectively now there are more situations considered diagonal than before - Further cleanups on the idle skill use code for immobile monsters and monsters near a player but without a target (now skill using will always go via mob_unlocktarget) * This also fixes that monsters switched to idle mode and start to use idle skills one second too late Mega thanks to Playtester (rathena 5540d89cb0e)
2014-08-06- Fix 3rd class skills on pre-renewal.Michieru1-0/+1
- When under Mind Break Matk Effect and Mdef reduction should not show on ALT Q(bug:7915) - Plagiarism should not copy New 3rd class skills. Thanks to OmegaRed (bug:8118) - Update Runstone Lux Anima to official formula (bug:8285) - Add official formula for Demonic Fire - Update damage formula for Unlimit, apply Def and Mdef to 1 during the skill and adjust the cooldown to official. (bug:8227) - Flash Combo should not consume hp-sp and the skill not ignore the distance. - Fix a bug with Full Throttle that not consuming sp correctly and adjust the cooldown to official. - All WoE items are inactive outside WoE or PVP - Add bonus3 bSPVanishRate for Vellum Items. - Script Vellum Items. - Add 2 new bonus bSetDefRace and bSetMDefRace for the Vellum Items. (rAthena c046668034) - Fixed Bowling Bash, Brandish Spear, Grand Darkness and Meteor Assault reducing def during cast; the only skill that does this officially is Grand Cross (rAthena 694719048e) - Implemented official Bowling Bash with all its special behaviors including the gutter line * As many servers probably want to remove the gutter line problem, it is configurable; just adjust the bowling_bash_area setting in skill.conf (Bug:4209) - Sonic Blow now has a fixed range of 1, even for monsters; a monster can't use this skill if you tank it from farther away (rAthena a15cee063d)
2014-07-12Updated SR_FLASHCOMBO behaviourpanikon1-65/+90
- Added SC_FLASHCOMBO Relocated some code related to SC_ALL_RIDING Updated SI table and skill table according to 3CeAM, special thanks to Rytech
2014-07-11Fixed reserved __identifier violationsHaru1-3/+3
- Complies with CERT DCL37-C - Fixes issue #293 (special thanks to elfring) Signed-off-by: Haru <haru@dotalux.com>
2014-05-21Corrected a nullpo report in 4c8d773d72ae134f7cc4d43861104ecd9f4ae134Haru1-2/+2
Special thanks to ossi0110 Signed-off-by: Haru <haru@dotalux.com>
2014-05-19Fixed issue 8182panikon1-0/+2
http://hercules.ws/board/tracker/issue-8182-cloaking-on-ice-wall/ Fixed minor typo on script_commands
2014-05-13Removed trailing whitespace (sources)Haru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
2014-05-10Re-commit of "Fixed order of includes in all source files"Haru1-5/+9
This reverts commit 94657284973f4037596bae468ebfbee5c217e02b.
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-11-01 04:17:18 +0000