summaryrefslogtreecommitdiff
path: root/src/map/skill.c
AgeCommit message (Collapse)AuthorFilesLines
2015-01-20Minor fixes and tweaks suggested by cppcheckHaru1-199/+189
- Variable scopes reduced - Parenthesized ambiguous expressions - Removed or added NULL checks where (un)necessary - Corrected format strings - Fixed typos potentially leading to bugs Signed-off-by: Haru <haru@dotalux.com>
2015-01-18Fixes direction in AOE skillscsnv1-2/+2
2015-01-18For bug report 8367shennetsind1-4/+22
While unable to reproduce, I implemented a countermeasure to the issue in question (settick failing, which'd cause blockskill[] not to be filled). Hopefully someone who can reproduce is able to shed some light on the conditions required, allowing for a proper fix to be made. http://hercules.ws/board/tracker/issue-8367-timer-settick-issue/ Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Fixed Bug 8441shennetsind1-1/+2
Magnifier item no longer consumes sp http://hercules.ws/board/tracker/issue-8441-item-magnifier-is-consuming-sp/ Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Replacing rand leftovers with the mt19937arshennetsind1-4/+4
Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Fixing 38 issuesshennetsind1-9/+21
Addressing out of bounds read/write, pointless null checks on already deferenced variables, dead code. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-1727 Fixesshennetsind1-18/+21
Addressing out of bounds read/write, pointless null checks on already deferenced variables. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-17Another ~10 Fixesshennetsind1-1/+2
Addressing out of bounds read/write. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-1710 Distinct fixesshennetsind1-1/+2
Addressing out of bounds read-write. Special Thanks to 4144, Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-12Fix uninitialized warning in skill.c.Andrei Karas1-2/+2
2015-01-12fix skills issue introduced in commit 5cdb3d12c4236e0c3a682e30fed96192d2c58188.Andrei Karas1-2/+2
2015-01-12Fixed an uninitialized variable in skill.cHaru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
2015-01-12Fixed Bug where skill timer is not properly terminated/clear when the caster ↵malufett1-5/+5
dies. -Thanks to GM Nihad. Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-01-11Fixed direction problem with self targeted skills. Thanks to Harunacsnv1-1/+2
2015-01-11Merge pull request #435 from 4144/skillextHaruna1-42/+302
Extend skills for using custom skills from plugins.
2015-01-11Merge pull request #434 from csnv/minfixesHaruna1-4/+11
INF2_NOLP update. BL direction fixes. Combo minimum time increased.
2015-01-11Corrected comments and INF2_NOLPcsnv1-2/+4
2015-01-10Extend skills.c for using custom skills from plugins.Andrei Karas1-42/+302
2015-01-10HPM Hooks UpdateHercules.ws1-19073/+19073
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
2015-01-10Add new eclage skills used in itemsMichieru1-19032/+19073
Update item_db to episode 14.2 Update eclage mobs spawn to official Update eclage mobs to official
2015-01-03Increased minimum combo time to that of amotion.csnv1-1/+1
2015-01-03Fixes the direction of an object (char, mob, etc) when it faces a target ↵csnv1-0/+5
after an action (skill, attack)
2015-01-03Corrected flag INF2_NOLP to actually work as intendedcsnv1-1/+1
2014-12-31Add some missing null pointer checks after automatic checks.Andrei Karas1-1/+2
2014-12-28Merge pull request #427 from csnv/skillsworkHaruna1-2/+2
PR_KYRIE Visual fix, EDP corrections. Preliminary fix Maya Purple Hack update position.
2014-12-28Fixed offensive skill formulas of KG/OB to official.malufett1-17/+16
Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-12-27Merge pull request #421 from csnv/songredoHaruna1-4/+25
Songs aegis behavior updated. Bonus correction
2014-12-26Disable text over target of PR_KYRIE. Bug report 8434: ↵csnv1-2/+2
http://hercules.ws/board/tracker/issue-8434-kyrie-eleison/?gopid=24099
2014-12-26Fixes song affecting caster without linkcsnv1-2/+8
2014-12-26Fix compilation errors and possible server crash from previous commits.Andrei Karas1-2/+4
2014-12-26Follow up@6dd08befa6064a652d0d98e7cb85f0e353992dd5malufett1-7/+15
Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-12-26Updated KG/OB Spirit Charms to official behaviormalufett1-13/+13
-http://hercules.ws/board/tracker/issue-8170-oborokagerou-charm/ -http://hercules.ws/board/tracker/issue-8274-ninja-charms-not-giving-proper-bonuses/ Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-12-24Songs aegis behavior updated. Bonus correctioncsnv1-4/+19
- Fixed bug 8412 http://hercules.ws/board/tracker/issue-8412-songs/ Now songs auto-refreshes every 3 seconds. - Musical Lesson bonus rounded down for BA_ASSASSINCROSS.
2014-12-14Merge branch 'master' of https://github.com/HerculesWS/Herculesmalufett1-1/+1
2014-12-14Fixed Bug#8456malufett1-3/+5
-http://hercules.ws/board/tracker/issue-8456-map-crash-skill-cell-overlap/?gopid=24193 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-12-10Add missing interface usage.Andrei Karas1-1/+1
2014-12-10RENEWAL Updates:malufett1-1/+1
-Homunculus Official Statuses -Updated RE @mobinfo to show proper status data.(Follow up 28a8b0f7b06a6af86aff6ececf7d9541d457e297) -Some official behaviors. Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-11-26Update Fire Expansion to official formula for all levelMichieru1-7/+12
Fix Full Throttle Order of Calculations For Stat Increase/Decrease By Status's Mega Thanks to Rytech
2014-11-24Correction, safetywall still consumes sp when cast on LP.GrumpyLittlePanda1-1/+6
2014-11-24* 1st Transcendent Spirit, monster position lag fixesMichieru1-3/+8
- 1st Transcendent Spirit will now work as on official servers (#116) * The max total stat that is granted by the skill is now BaseLevel-10 with a maximum of 50 instead of always 50 * It will now work as Marionette Control and calculate the bonus at cast time rather than overwrite all existing bonuses * Agi Up and Blessing will now cancel the soul link - Fixed various problems that caused position lags on the client (#118) * Added a define ACTIVEPATHSEARCH in mob.c; if active (default and official), monsters will only grab targets if the walk path to the target is shorter or equal their search range; search range depends on whether the monster is moving or not (range2 for standing monsters and range3 for walking monsters); this requires a lot of CPU load, if it causes trouble, just comment the define for old behavior * Fixed a bug that made monsters display "irregular movement with position lag" continuously when a status change ended that changed their walk speed * OFFICIAL_WALKPATH now also applies to monsters * If the path search fails while a unit is already moving, we will now issue of fixpos packet so that the unit does not only stop moving on the server, but also on the client * Direction fixes - Updated the config setting attack_direction_change from 15 to 0 (official value); that means that a unit's direction will no longer change when it attacks; knock-back effects from e.g. Firewall will depend on the last direction the target walked into instead (bugreport:1322) - Ensured that the default direction of a monster is always "north", so that immobile monsters will now always be knocked back to the south by e.g. Firewall on default settings, unless a skill like e.g. Backstab changes their direction (bugreport:1322) - Fixed a bug that stopped characters server-sided and caused position lag when closing a skill menu * Magnum Break damage fixed - Targets two cells away will now only take 100%+10%*level damage (#108)
2014-11-17(Bugs 5237 and 7979)GrumpyLittlePanda1-9/+13
- Land Protector now behaves more like on official servers * Land Protector now protects from units being placed on it, no matter if they have splash range or not * Land Protector no longer protects from damage from units not outside Land Protector that splash inside * Meteor Storm no longer shows meteors falling if they would land on Land Protector * Pneuma can no longer be placed next to Land Protector * Safety wall no longer consumes gem if cast on LP. * Also cleaned up the code a bit, so the checks are done where they should be done - Ground skill splash ranges updated to their official values * Lord of Vermilion places units in a 11x11 area with 3x3 splash range each * Storm Gust places units in a 9x9 area with 3x3 splash range each * Heaven's Drive places units in a 5x5 area with no splash range * Venom Dust now has a splash range of 3x3 and is consequently larger than before - Storm Gust's knock-back behavior updated to official * Each of Storm Gust's units will knock back "Away from center" * As units in the south-west are processed first, the knock-back direction will usually be north-east * At the edges the knock-back direction will be "to the outside" * Land Protector and Ganbantein will influence the knock-back behavior strongly, e.g. if Storm Gust has a hole in the middle, it will have a "suck in" effect * Added a config option for those who want the old "random direction" behavior from eAthena
2014-11-16Whitespace cleanup (no code changes)Haru1-341/+490
This includes, and is not limited to: mixed or wrong indentation, excess whitespace (horizontal and vertical), misalignment, trailing spaces. Signed-off-by: Haru <haru@dotalux.com>
2014-11-10Fix interfaces methods usage.Andrei Karas1-6/+6
In some places was used direct methods.
2014-11-03Merge pull request #363 from EPuncker/masterMichieru1-0/+3
Added 4 new permissions
2014-11-03* No cell stacking implemented (official version)Michieru1-3/+3
- Split config cell_stack_limit into custom_cell_stack_limit (previous feature) and official_cell_stack_limit (see below) - Expanded map_count_oncell by a flag parameter, currently only one flag is supported: only count standing units (needed for official cell stack feature) - Added a new function map_closest_freecell that will return the closest free cell using the same order that official servers use - Monsters will now actively search for a free cell when starting to walk randomly and when unlocking target - When any unit finishes walking (regularly) and is not on a free cell, it will now actively search for a free cell - Step actions will be delayed until a suitable cell was found, they will even be executed when the player walked slightly out of attack range - Monsters will now stop instantly if their target is completely non-existent * This is mainly for looters that had their loot taken * Hide and most other situations still use the configuration setting monster_chase_refresh Mega Thanks to Playtester
2014-11-03Merge branch 'master' of github.com:HerculesWS/Herculesshennetsind1-20/+14
Signed-off-by: shennetsind <ind@henn.et> Conflicts: src/map/battle.c
2014-11-03Added missing type check to skill_delunitgroupshennetsind1-1/+1
Signed-off-by: shennetsind <ind@henn.et>
2014-11-01Fix clearance, should work only on mob, party or self and skill can't be ↵Michieru1-12/+1
cast on all players that are not in the party (bug:7050)
2014-10-31- If you now cast Icewall on an existing ice wall cell, the duration (HP) ↵Michieru1-2/+3
will no longer be refreshed Thanks to Playtester
2014-10-30Fixed Bug#8012malufett1-2/+1
-http://hercules.ws/board/tracker/issue-8012-bonus-bvariablecastrate-and-bfixedcastrate-not-working-properly/?gopid=21893#entry21893 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>