Age | Commit message (Collapse) | Author | Files | Lines |
|
Upon death attached (if any) script's execution only terminates if there is a open dialog, allowing silent npcs to remain running.
Special Thanks to Haru, AnnieRuru!
http://hercules.ws/board/tracker/issue-8062-when-player-died-the-script-execution-stops/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Fixed issue 8087
http://hercules.ws/board/tracker/issue-8087-excrescent-blank-line-in-pcc/
|
|
disabling rental items with zones would cause such rental items to be deleted when the item_restricted_consumption_type setting was enabled, this has been fixed in this commit.
Special Thanks to Tepoo.
http://hercules.ws/board/tracker/issue-8081-map-zone-dbconf-item-dissabled-issues/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Added simple overflow check in pc_heal to fix issue: 8082
http://hercules.ws/board/tracker/issue-8082-itemheal-kills-with-high-rand-value/
|
|
Special Thanks to kyeme, Haruna
http://hercules.ws/board/tracker/issue-8072-map-crash-autotrade/
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Updated several functions to properly use the data structures defined
in parts 1 and 2.
- Special thanks to Ind for his help on this, as well as the previous
two parts.
- Fixes some crashes related to variable references passed back and
forth between nested callfunc/callsub scopes (related: 2669e9a,
3259f89, 4f2de07)
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Reorganized regs var/array DBMaps into a specific reg_db structure
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Removed some unused messages.
- Re-mapped some duplicate IDs - fixes bugreport:8057, thanks to
AnnieRuru http://hercules.ws/board/tracker/issue-8057-jobname-with-invalid-id-return-tomb/
- Fixed some issues with the message range loaded by the char server.
- Reworded some messages, fixed typos in others.
Note for translation users: some messages have been remapped to new IDs.
You'll need to remap them in your custom translations as well. The list
of changes is as follows:
- Removed messages (you can safely remove them from your translations):
15, 26-27, 35, 48-52, 57-58, 65-69, 82-83, 86-87, 91, 101, 140-142,
164, 189-194, 199-200, 202-203, 209-211, 215-218, 267-268, 275,
289-290, 380-385, 387-388, 401, 497, 499, 535-537, 922, 995, 1063,
1079, 1291-1294
- New messages (you need to add them to your translations): 15
- Moved messages (you need to change their IDs in your translations file):
* [Unknown Job] 656 -> 620,
* [Job names] 681~693 -> 656~668
* [Tombstone related] 656~661 -> 856~861
* [Etc messages] 662~680 -> 862~880
* [@version] 1436 -> 1294
* [Hercules Chat] 1475 -> 1436
Signed-off-by: Haru <haru@dotalux.com>
|
|
Changed types in clif.c:
bool clif_setip -> map:ip_set, map: char_ip_set changed as well
bool clif_setbindip
bool clif_send
bool clif_spawn
void clif_homskillinfoblock
bool clif_sub_guild_invite
Note that return values of those types have changed, so if any modification uses their return values
it should be changed.
clif_disp_onlyself replaced as a macro
clif_viewequip_fail replaced as a macro
Merged clif_skillup and clif_guild_skillup as they were using the same packet
Added packet_len() values in clif_updatestatus
|
|
Signed-off-by: shennetsind <ind@henn.et>
|
|
- More info on the forums, at
http://hercules.ws/board/topic/4428-michierus-renewal-update/
Signed-off-by: Haru <haru@dotalux.com>
|
|
Shadow Accs and Dual-Wielding fix, thanks to bgamez23
http://hercules.ws/board/tracker/issue-7993-shadow-system-bug-for-accessories/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Issue with combos reapplying themselves upon removal of a duplicate item present (e.g. 2x gloves of a glove that combos with a shield), since 524291493e64
Thanks to Angelmelody
http://hercules.ws/board/tracker/issue-7949-item-combo-bug/
Signed-off-by: shennetsind <ind@henn.et>
|
|
-http://hercules.ws/board/tracker/issue-7988-royal-guard-exceed-break-causes-map-server-crash/
Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
|
|
Consumables with expire item no longer stack with those without expire time
Thanks to kyeme.
http://hercules.ws/board/tracker/issue-7978-rental-item-stackable/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Thanks to Haruna
Signed-off-by: shennetsind <ind@henn.et>
|
|
Thanks to Michieru
Signed-off-by: shennetsind <ind@henn.et>
|
|
|
|
- Fixes /str+, /agi+ and the likes, only being able to increase stats by
1 point on 2013-12 and newer clients.
- As a bonus, on those clients, processing of the /stat+ commands will
be much faster, and the requested points will be added instantly and
all at once rather than one at a time like in older clients.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Special Thanks to Mhalicot!
Also improves the overall memory usage of the item combo feature
Signed-off-by: shennetsind <ind@henn.et>
|
|
We designed this one with having as little changes required elsewhere in mind, thus the way most socket-related things are called has not changed.
Plugins may now take a greater advantage of the socket features.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Ready for plugin use.
Thanks to Haruna
Signed-off-by: shennetsind <ind@henn.et>
|
|
Thanks to Mhalicot!
Signed-off-by: shennetsind <ind@henn.et>
|
|
temporary pc regs (@) were being misflagged.
http://hercules.ws/board/tracker/issue-7967-scriptc-leaks/
Signed-off-by: shennetsind <ind@henn.et>
|
|
From some notes I took while working on the megapatch:
- Dropped unused char_dat variable in chrif's auth_node
- Fixed DB/BB/PB Logging, which could create false logs due to where it was placed.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Enforcing cache to match the option condition in order for it to be shared. Special Thanks to Haruna!
Signed-off-by: shennetsind <ind@henn.et>
|
|
http://hercules.ws/board/topic/3886-hercules-1st-2014-megapatch/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Aka autotrading merchants survive server restarts.
Originally sekai's (aka me).
Special Thanks to Haruna, Michieru.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Item database bug fixes.
|
|
equivalent macros
Because 2/3 jumps to perform such a operation is just awful
Signed-off-by: shennetsind <ind@henn.et>
|
|
Because 2 jumps to get a single value is just awful.
Signed-off-by: shennetsind <ind@henn.et>
|
|
|
|
- Warnings detected thanks to Xcode's compiler settings (more strict by
default) and clang, warnings mostly but not only related to data sizes
on 64 bit systems, that were silenced until now by very lax compiler
settings.
- This also decreases by a great deal the amount of warnings produced by
MSVC in x64 mode (for the adventurous ones who tried that)
- Also fixed (or silenced in case of false positives) the potential
issues pointed out by the (awesome) clang static analyzer.
- Patch co-produced with Ind, I'm merging and committing in his place!
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Special Thanks to Haru
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: shennetsind <ind@henn.et>
|
|
|
|
- Improved memory usage of the quest log system. (saves up to 75kB per
online character). Fixes issue #133.
- Fixed various issues with quest entries disappearing from characters
without an apparent reason, or monster kill counters getting stuck -
the issues were caused by a de-synchronization between the two
parallel questlog arrays in map_session_data.
- Added some code documentation.
- Thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Updated to use official formulas from Aegis (for both success chance
and stolen zeny amount.)
- It now shows the correct stolen zeny amount in the battle log, rather
than showing the skill level.
- Made possible thanks to Yommy and Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
replaced pc_isuseitem 90overweight error message by its official version, added invent-full check for when trying to open packages/boxes, and modified mail getAttachment to fail when over 90% weight.
Special Thanks to kyeme.
http://hercules.ws/board/tracker/issue-7542-bug-when-weight-90/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Fixed EQI_SHADOW_ACC_L ability to produce bonuses, Special Thanks to rosfus, Angelmelody.
http://hercules.ws/board/tracker/issue-7866-eqi-shadow-acc-l-missing-effect/
Signed-off-by: shennetsind <ind@henn.et>
|
|
|
|
pc_checkitem is now triggered by @reloaditemdb to ensure modified conditions are respected, also a performance boost that causes the itemlist/cartlist/storagelist/gstoragelist lookups to only be triggered on demand instead of on every teleport.
Closes #219
Fixed ancient monster ai bug that caused mobs to consider themselves elegible targets, which would waste status_check_skilluse and battle_check_target calls.
Signed-off-by: shennetsind <ind@henn.et>
|
|
adjustment.
Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
|
|
- The .favorite field of newly added inventory items wasn't correctly
initialized to zero, potentially causing data loss (fixes
bugreport:7854, thanks to Vincent, GrumpyPanda).
Signed-off-by: Haru <haru@dotalux.com>
|
|
warping (e.g. @recall) of autotrade characters no longer leaves them in memory limbo, the trigger that'd be expected from the client is now called for autotrade units so that they complete the warp procedure in full, vendings are loaded properly as well.
http://hercules.ws/board/tracker/issue-7495-autotrade/
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Follow-up to ed72a947a6c97804c1eef5b80bfa49d99f7d7586
- Max EquipLv is now observed, rather than ignored, in pre-renewal mode.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- This makes it harder to get the item IDs wrong in the code.
- Fixes item 'Slot_Coupon' being incorrectly considered a Spell Book due
to an oversight (wrong item nameid) when the check was introduced.
Signed-off-by: Haru <haru@dotalux.com>
|
|
I'm committing on malufett's behalf.
Signed-off-by: shennetsind <ind@henn.et>
|
|
As brought up in http://hercules.ws/board/topic/2225-paid-server/
Special Thanks to Haruna for all the help!
Thanks to Beret, Ai4rei for information
Signed-off-by: shennetsind <ind@henn.et>
|