Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Improved compatibility, portability and standards conformance.
- Since it is not possible to portably and reliably re-use the core's
symbols in plugins, symbols are no longer exported unless explicitly
required, in the UNIX builds. This mimics the Windows behavior and
adds HPM compatibility to OSes such as FreeBSD. Credits to Andrei Karas
for making this possible.
- For convenience, it is no longer necessary to call GET_SYMBOL, since
the plugin will automatically import all the available symbols when
it's loaded, depending on the included headers.
- Plugins are now supposed to include the "common/hercules.h" header
before including anything else. Incluing common/HPMi.h,
common/cbasetypes.h or conf/core.h is no longer necessary, as those
are guaranteed to be automatically included by hercules.h.
- HPM API version bumped to 1.1.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Follow-up to 5090bdf750017f0d631401edd563c452bd10ec24,
84e02ac28fbb15c58d0a0f8a916b49663198b05b
Signed-off-by: Haru <haru@dotalux.com>
|
|
It’ll now return the first result, rather than the last due to item2
being overwritten as it searches through the array.
|
|
This fixes the script loading issue mentioned here -> http://herc.ws/board/topic/10249-issue-with-item-db-after-update/
|
|
include stackable ones.
Implement ForceSerial option in Package Item Database to force serial for
any item.
Implement ForceSerial option in item database to force serial for any item.
Implement Merge Client interface to merge stackable items with serial numbers ( check npc/other/item_merge.txt ).
|
|
- Include directives are now directory-independent.
- This will allow building plugins from other directories in future.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Since there (currently and in future) is no difference between the
table structure for renewal and pre-renewal databases, it makes no
sense to have extra code that makes a distinction between their names.
A server will always use either one or the other, never both at the
same time.
- If you have a mob_db_re, mob_skill_db_re and/or item_db_re table,
please rename it to mob_db, mob_skill_db and/or item_db_re,
respectively.
- No upgrade script provided. I'd like to remind everyone that these
tables are optional (and deprecated), and they are only offered for
convenience for those who need them for web control panels and similar
software.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Variable scopes reduced
- Parenthesized ambiguous expressions
- Removed or added NULL checks where (un)necessary
- Corrected format strings
- Fixed typos potentially leading to bugs
Signed-off-by: Haru <haru@dotalux.com>
|
|
Addressing out of bounds read/write, pointless null checks on already deferenced variables.
Special Thanks to 4144 and Haruna!
Signed-off-by: shennetsind <ind@henn.et>
|
|
Addressing out of bounds read/write.
Special Thanks to 4144 and Haruna!
Signed-off-by: shennetsind <ind@henn.et>
|
|
|
|
|
|
|
|
This functions called after reading normal fields and after
adding item to itemdb.
|
|
|
|
New method: itemdb_is_item_usable
Can be used as: itemdb->is_item_usable(item)
|
|
New item attribute: KeepAfterUse
|
|
This includes, and is not limited to: mixed or wrong indentation, excess
whitespace (horizontal and vertical), misalignment, trailing spaces.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Details in http://hercules.ws/board/topic/7618-2014-10-22-roulette-and-per-char-gender/
Special Thanks to the all-mighty Yommy, Ziu and Haruna!
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Functions that expect a printf-style format string are now marked as
such, so that gcc/clang will emit a warning warn you if you mismatch
format string and arguments.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Values are now clamped to the [0,100] range. Removed useless
positivity check for item_usage.override (fixes a compiler warning).
- Special thanks to KeiKun, ossi0110.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Actual source edits
Signed-off-by: Haru <haru@dotalux.com>
|
|
- To be used in a follow-up item_db.conf edit.
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
This reverts commit 94657284973f4037596bae468ebfbee5c217e02b.
|
|
This reverts commit b6b3f58795288701d0e162d43fa6f0a47af913b3.
Fixes issue 8184
http://hercules.ws/board/tracker/issue-8184-cart-related/
|
|
- Changed order according to the (upcoming) code style guidelines.
- Fixes several issues caused by missing headers when their include
order is changed or in plugins.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- This affects normal execution as well as ./script-checker runs.
Signed-off-by: Haru <haru@dotalux.com>
|
|
other function which could be misleading when debugging without a debugger.
|
|
* http://hercules.ws/board/tracker/issue-8146-reloaditemdb-item-combo-db-crash/
|
|
dependency
- Removes the need for map-server to access the interreg table to store the last used ID.
- Login, char and map databases can now be hosted separately.
- Note: the unique_id structure has changed, and it now contains the generator character ID in its upper 32 bits.
- Now NSI_UNIQUE_ID System is enabled always
Special thanks to Haruna.
|
|
- Fixes bugreport:8013, thanks to Dastgir Pojee
http://hercules.ws/board/tracker/issue-8013-script-add-str-problem/
Signed-off-by: Haru <haru@dotalux.com>
|
|
Special Thanks to Mhalicot!
Also improves the overall memory usage of the item combo feature
Signed-off-by: shennetsind <ind@henn.et>
|
|
Ready for plugin use.
Thanks to Haruna
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Fixes issue 7968, thanks to Moguri
http://hercules.ws/board/tracker/issue-7968-trader-npc-not-working/
- Corrected sprite name for KO_KAGE to match latest kRO info (previouly
KO_ZANZOU, conflicting with a Kagerou/Oboro skill identifier)
- Updated self-test script to include checks for constants and for setd
and getd.
- Made possible thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Warnings detected thanks to Xcode's compiler settings (more strict by
default) and clang, warnings mostly but not only related to data sizes
on 64 bit systems, that were silenced until now by very lax compiler
settings.
- This also decreases by a great deal the amount of warnings produced by
MSVC in x64 mode (for the adventurous ones who tried that)
- Also fixed (or silenced in case of false positives) the potential
issues pointed out by the (awesome) clang static analyzer.
- Patch co-produced with Ind, I'm merging and committing in his place!
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Case-sensitive AegisName and Sprite ID lookups are now optional,
controlled by the case_sensitive_aegisnames battle config flag (you
can set it to "no" to restore the case insensitive behavior.)
- Special thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Special Thanks to Megasantos, Beret.
Follows up 098dbcf672e04657553b9f1629550e6bc8771af3
http://hercules.ws/board/tracker/issue-7883-reloaditemdb/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
pc_checkitem is now triggered by @reloaditemdb to ensure modified conditions are respected, also a performance boost that causes the itemlist/cartlist/storagelist/gstoragelist lookups to only be triggered on demand instead of on every teleport.
Closes #219
Fixed ancient monster ai bug that caused mobs to consider themselves elegible targets, which would waste status_check_skilluse and battle_check_target calls.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Special Thanks to Yommy, Haruna.
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Added explicit column names in the item_db query, to ensure it will
throw a SQL error in case some are missing, rahter than silently
failing and returning incorrect data.
- Added sql upgrade file to add the bindonequip column to the item_db2
table for those who have it.
- As with all the item_db2 upgrade scripts, you need at least MySQL 5.0
in order to run it. If your version is not compatible, or if the
script fails for any reason, manual upgrade instructions are provided
within the script.
- Special thanks to Mumbles.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Added missing source documentation for the itemdb overhaul related
functions.
- Slighty refactored the readdb sql function.
- Special thanks to sevenzz23 for reporting the crash issue (topic:3029)
http://hercules.ws/board/topic/3029-ritem-data-structure-overhaul-error-msg/
and to Ind for testing.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Special thanks to Mumbles.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Implements the 'BindOnEquip' item db field which determines whether the piece of equipment should bind to the character upon being equipped.
When a character tries to equip such a item for the first time a dialog shows up asking the character to confirm whether to equip the item or not, and notifying the character that by equipping the item it will become bound to the character, and therefore unable to be used by another character.
Special Thanks to Beret for all the information, Haruna for testing.
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Special thanks to kyeme
Signed-off-by: Haru <haru@dotalux.com>
|
|
- If an item is marked as Inherit: true in item_db2, and it already
exists, in item_db, then any unspecified fields are taken from the
item_db entry rather than using their default values.
- Special thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|