summaryrefslogtreecommitdiff
path: root/src/map/atcommand.c
AgeCommit message (Collapse)AuthorFilesLines
2015-01-22Follow up 0957abd4d19b82b8dc8d7db2743008fa3daff3fashennetsind1-1/+1
Special Thanks to kyeme Signed-off-by: shennetsind <ind@henn.et>
2015-01-20Minor fixes and tweaks suggested by cppcheckHaru1-68/+75
- Variable scopes reduced - Parenthesized ambiguous expressions - Removed or added NULL checks where (un)necessary - Corrected format strings - Fixed typos potentially leading to bugs Signed-off-by: Haru <haru@dotalux.com>
2015-01-18To help pinpoint and manage the issue report in 8402shennetsind1-0/+45
@cddebug command; broken entries will be normalized immediately, to forcefully reset the cooldown write "reset" i.e. @cddebug reset, to use on others the usual #cddebug "target" http://hercules.ws/board/tracker/issue-8402-serious-problem-with-skill-that-cant-be-cast-or-used/ Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Command line arguments handling overhaulHaru1-1/+1
- login_server, char_server, map_server as well as the tools (mapcache) now have a common command line arguments handling mechanism. - All of them now accept `--help` (`-h`), `--version` (`-v`) and `--load-plugin`. - login_server now accepts `--login-config` and `--lan-config` instead of relying on positional arguments to override those files. The old syntax will no longer work, please update your custom startup scripts. - char_server now accepts `--char-config`, `--inter-config`, `--lan-config` instead of relying on positional arguments. The old syntax will no longer work, please update your custom startup scripts. - mapcache now accepts `--grf-list`, `--map-list`, `--map-cache`, `--rebuild` in place of, respectively, `-grf`, `-list`, `-cache`, `-rebuild`. - A new macro `CMDLINEARG()` is provided, to help defining new command line argument handlers (i.e. in plugins). the `addArg()` call is still required, but its syntax has changed. The `help` argument is now of type `const char *` rather than a function pointer, and it is supposed to contain the message to show in the `--help` screen. Pass `NULL` if no help message is desired. Signed-off-by: Haru <haru@dotalux.com>
2015-01-18Fixing 38 issuesshennetsind1-11/+12
Addressing out of bounds read/write, pointless null checks on already deferenced variables, dead code. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-1727 Fixesshennetsind1-1/+2
Addressing out of bounds read/write, pointless null checks on already deferenced variables. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-12Fix some compilation warnings with clang 3.6.Andrei Karas1-1/+1
2015-01-12Fixed some -Wformat-security warningsHaru1-2/+2
Signed-off-by: Haru <haru@dotalux.com>
2015-01-11Convert pcdb_checkid into function in pc interface.Andrei Karas1-1/+1
2015-01-02Add npcdb_checkid to npc interface.Andrei Karas1-3/+3
2014-12-31Improve performance a bit by removing strlen(str) > 0.Andrei Karas1-1/+2
2014-12-31Remove useless checks.Andrei Karas1-2/+2
2014-12-31Add some missing null pointer checks after automatic checks.Andrei Karas1-7/+5
2014-12-10RENEWAL Updates:malufett1-0/+6
-Homunculus Official Statuses -Updated RE @mobinfo to show proper status data.(Follow up 28a8b0f7b06a6af86aff6ececf7d9541d457e297) -Some official behaviors. Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-12-06add channels config into clif interface.Andrei Karas1-26/+26
2014-11-16Whitespace cleanup (no code changes)Haru1-1177/+1112
This includes, and is not limited to: mixed or wrong indentation, excess whitespace (horizontal and vertical), misalignment, trailing spaces. Signed-off-by: Haru <haru@dotalux.com>
2014-11-10Fix interfaces methods usage.Andrei Karas1-3/+3
In some places was used direct methods.
2014-10-24Renamed ismounting, setmounting, @mount2Haru1-3/+4
To avoid ambiguity: - The script command ismounting is now hascashmount - The script command setmounting is now setcashmount - The at-command @mount2 is now @cashmount Signed-off-by: Haru <haru@dotalux.com>
2014-10-24pc_isriding* / pc_setriding* cleanupHaru1-18/+17
- pc_isriding is now renamed to pc_isridingpeco, since that's what it checks (to avoid confusion). - pc_hasmount is added, to check for any of Peco, Dragon, Mado Gear, Wug Rider. - pc->setridingdragon is added. - pc->setridingwug is added. - pc->setfalcon type is changed. - pc->setmadogear type is changed. - pc->setridign is changed to pc->setridingpeco to avoid confusion. - Changed direct accesses to sd->sd.option to the proper pc_is* accessors, where applicable. - Special thanks to Kisuka. Signed-off-by: Haru <haru@dotalux.com>
2014-10-05Follow up a46b190764df4cce0b378bc691218ac0814a5673shennetsind1-1/+1
Dropped id2storage entirely, replaced with idb_get (1) it was redundant 2) the rename on a46b190764df4cce0b378bc691218ac0814a5673 was a very poor choice as plugins using the previous version would be calling the other). Signed-off-by: shennetsind <ind@henn.et>
2014-10-05Follow up b9b32ac7609eshennetsind1-1/+1
Fixes issue where kicking a online guild member (on a server with GP_BOUND_ITEMS defined) would render the guilds storage (if not previously loaded during the servers lifespan (since boot)) to be wiped. Special Thanks to Xgear! Signed-off-by: shennetsind <ind@henn.et>
2014-09-20Fixed bug 8186 (@who3)shennetsind1-1/+1
Issue where certain name patterns could cause the game client to crash, solved by changing the packet. Special Thanks to kyeme! http://hercules.ws/board/tracker/issue-8186-client-crashes-in-disguise-and-who/ Signed-off-by: shennetsind <ind@henn.et>
2014-09-20Fixed Bug 8138shennetsind1-0/+1
@at persistency no longer sends characters to save point when starting autotrade on a nosave location. http://hercules.ws/board/tracker/issue-8138-autotrade-teleports-char-to-the-savepoint/ Signed-off-by: shennetsind <ind@henn.et>
2014-09-20Fixed @at with buyingstore issueshennetsind1-8/+4
Where it'd not leave channels upon starting autotrade (for buying stores only), no report to link -- noticed while working on a different report. Signed-off-by: shennetsind <ind@henn.et>
2014-09-20Fixed Bug 8318shennetsind1-2/+1
Fixed @at crash as described in 8318. Related to 4147d9f7966e Special Thanks to Haruna! <3 http://hercules.ws/board/tracker/issue-8318-something-crash-with-autotrade/ Signed-off-by: shennetsind <ind@henn.et>
2014-09-20Replaced hardcoded values with constants for status_change_start's flagHaru1-1/+2
- Please use the values from enum scstart_flag when calling status_change_start or related functions. - This also applies to the sc_start script commands. Signed-off-by: Haru <haru@dotalux.com>
2014-09-19Update official Homunculus renewal stats (bug:6970) ↵Michieru1-2/+2
http://hercules.ws/board/tracker/issue-6970-homunculus-renewal-stats/ Follow up (bug 8348): https://github.com/HerculesWS/Hercules/commit/ddc52570a9bf694cdba6445bc02350a94856a583 Update official overbrand damage (special thanks to Rytech) The skill damage is no longer affected by your base level. It is now affected by the enemy's base level (special thanks to Rytech) Updated the list of skills usable while mounted on a mado. (special thanks to Rytech)
2014-09-16Follow: ↵Michieru1-9/+9
https://github.com/HerculesWS/Hercules/commit/8ab61745b81d1cf0602c7998f590aac8749187da This fixed all mob size problem :) Fix estin estun not working properly (bug:7891)
2014-08-20Follow-up to b294026e6614a652c23bb0cea8a0d4dc69d8b125Haru1-2/+1
- Added documentation for the pc->search_item function and formalized its return values. If the searched item is not found, now it returns the newly introduced constant INDEX_NOT_FOUND. - Updated pc->search_item checks to make use of INDEX_NOT_FOUND. - Fixed an issue with anvils not detected by the weapon forginc code, if they were in the first position of the inventory. - Added ITEMID constants for the four anvil types. Signed-off-by: Haru <haru@dotalux.com>
2014-08-07Corrected several format-string errors through the codeHaru1-99/+113
- Functions that expect a printf-style format string are now marked as such, so that gcc/clang will emit a warning warn you if you mismatch format string and arguments. Signed-off-by: Haru <haru@dotalux.com>
2014-07-11Fixed reserved __identifier violationsHaru1-1/+1
- Complies with CERT DCL37-C - Fixes issue #293 (special thanks to elfring) Signed-off-by: Haru <haru@dotalux.com>
2014-07-10Corrected some SC behaviour, special thanks to Rytechpanikon1-1/+1
- Extracted some methods to check SC blocks - Fixed issue that when players couldn't attack they couldn't talk to NPCs with mob view id either Follow up to ec51176326c6028630835538db67826281d34ffe, fixed minor typo
2014-07-09Fixed issue with [AT]mount, it wasn't displaying the expected messages, all ↵panikon1-15/+27
errors would simply display "You can not mount a Peco Peco with your current job.", now it's displaying a different message for each possible error
2014-07-02Fixed issue that when players used [at]fakename when disguised their names ↵panikon1-0/+4
wouldn't be updated for them
2014-05-30Fixed typos inside src/Shido1-33/+33
2014-05-20Improved @go commandHaru1-137/+84
- Corrected checks to correctly display the help message when an invalid map name is requested (rather than warping to Prontera) - Removed huge list of hardcoded town names (special thanks to KeiKun). Signed-off-by: Haru <haru@dotalux.com>
2014-05-16Follow-up to b6b3f58795288701d0e162d43fa6f0a47af913b3Haru1-1/+1
- Includes in some files weren't sorted alphabetically. Special thanks to KeiKun. Signed-off-by: Haru <haru@dotalux.com>
2014-05-13Removed trailing whitespace (sources)Haru1-6/+6
Signed-off-by: Haru <haru@dotalux.com>
2014-05-10Moved MAX_CARTS and NEW_CARTS defines into common/mmo.hHaru1-2/+2
- Fixes bugreport:8184, allowing re-commit of 94657284973f4037596bae468ebfbee5c217e02b Signed-off-by: Haru <haru@dotalux.com>
2014-05-10Re-commit of "Fixed order of includes in all source files"Haru1-32/+35
This reverts commit 94657284973f4037596bae468ebfbee5c217e02b.
2014-05-10Revert "Fixed order of includes in all source files"panikon1-35/+32
This reverts commit b6b3f58795288701d0e162d43fa6f0a47af913b3. Fixes issue 8184 http://hercules.ws/board/tracker/issue-8184-cart-related/
2014-05-09Fixed order of includes in all source filesHaru1-32/+35
- Changed order according to the (upcoming) code style guidelines. - Fixes several issues caused by missing headers when their include order is changed or in plugins. Signed-off-by: Haru <haru@dotalux.com>
2014-04-19Corrected some issues in 69ca0aa and 446ce4aHaru1-12/+7
Signed-off-by: Haru <haru@dotalux.com>
2014-04-18# Several minor changes in atcommandspanikon1-20/+58
1. Reallocated and added checks in @jumpto, @jump, @mapmove in order to increase performance * Checks are now made to avoid unnecessary lookups and unnecessary warps 2. Corrected return failure values of @zeny 3. Added messages to * ATclearcart > Warns that it's not possible to clean a cart while vending * ATshowmobs > Asks user to enter a mob name/id and warns if the mob name is invalid * ATgstorage > Warns when another guild member is using the gstorage # Fixed issue where while using storage/gstorage and then refreshing would close the storage but only for the client, the server wouldn't now and this would cause the guild storage to remain locked and the character without ability to do anything.
2014-04-17Added sysinfo (System Information) functionalitiesHaru1-12/+6
- More informative messages are displayed during startup, to make it easier to identify what system and environment Hercules is running. - Git/SVN revision detection is improved, separating the source version (cached at compile time) from the runtime version, in case the user updated their working copy without recompiling the server. Git version detection is also more reliable, in case a non-default branch is used. - The get_revision script command has been removed (as it was useless to begin with, after the switch to git). An alternative will be provided later, for feature-probing purposes. - The patch was tested under Linux (Gentoo / gcc 4.7 on i686 and x86_64, Debian 6 / gcc 4.4 on i686, Raspbian / gcc 4.6 on armv6l, CentOS 5 / gcc 4.1 on i686, CentOS 6 / gcc 4.4 on x86_64, Linux Mint 15 / gcc 4.7 on x86_64, OS X Mountain Lion / clang 5.0 and gcc 4.8 on x86_64, Cygwin-NT-5.1/gcc 4.8 on i686, FreeBSD 8 / gcc 4.2 on i386, FreeBSD 9 / gcc 4.2 on amd64, FreeBSD 10 / clang 3.3 on amd64, NetBSD 5 / gcc 4.1 on i386, NetBSD 6 / gcc 4.5 on amd64, OpenBSD 5 / gcc 4.2 on amd64, Solaris 11 / gcc 4.5 on i86pc, Windows 7 / Visual Studio 2012 on x86, Windows 8 / Visual Studio 2010 on WOW64, Windows 8.1 / Visual Studio 2013 on WOW64. Signed-off-by: Haru <haru@dotalux.com>
2014-04-09Fixed issue: 7725panikon1-0/+5
http://hercules.ws/board/tracker/issue-7725-disguise-hide-skill-bug/ Fixed issue: 8027 http://hercules.ws/board/tracker/issue-8027-when-the-storage-is-open-you-can-use-self-skills/ Fixed issue where @at showed it failed when it succeeded
2014-03-29Fixed Bug 8091shennetsind1-3/+3
@mi mvp drops now displays item slot, special thanks to Tepoo, Haru. http://hercules.ws/board/tracker/issue-8091-mi-mvp-reward-equipment-slot-information-bugged/ Signed-off-by: shennetsind <ind@henn.et>
2014-03-29Fixed Bug 8121shennetsind1-1/+8
Would reject buyingstores on @at, fixed (unlike vendings, buying stores are not able to survive restarts at this time, should be added soon) http://hercules.ws/board/tracker/issue-8121-buyingstore-use-commend-autotrade-error/ Signed-off-by: shennetsind <ind@henn.et>
2014-03-16Added --load-script commandline argumentHaru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
2014-02-27Cleaned up messages.confHaru1-48/+53
- Removed some unused messages. - Re-mapped some duplicate IDs - fixes bugreport:8057, thanks to AnnieRuru http://hercules.ws/board/tracker/issue-8057-jobname-with-invalid-id-return-tomb/ - Fixed some issues with the message range loaded by the char server. - Reworded some messages, fixed typos in others. Note for translation users: some messages have been remapped to new IDs. You'll need to remap them in your custom translations as well. The list of changes is as follows: - Removed messages (you can safely remove them from your translations): 15, 26-27, 35, 48-52, 57-58, 65-69, 82-83, 86-87, 91, 101, 140-142, 164, 189-194, 199-200, 202-203, 209-211, 215-218, 267-268, 275, 289-290, 380-385, 387-388, 401, 497, 499, 535-537, 922, 995, 1063, 1079, 1291-1294 - New messages (you need to add them to your translations): 15 - Moved messages (you need to change their IDs in your translations file): * [Unknown Job] 656 -> 620, * [Job names] 681~693 -> 656~668 * [Tombstone related] 656~661 -> 856~861 * [Etc messages] 662~680 -> 862~880 * [@version] 1436 -> 1294 * [Hercules Chat] 1475 -> 1436 Signed-off-by: Haru <haru@dotalux.com>
generated by cgit v1.2.3-60-g2f50 (git 2.42.0) at 2024-07-15 19:08:33 +0000