Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Replacements are as follows:
0 => ITEMINFO_BUYPRICE
1 => ITEMINFO_SELLPRICE
2 => ITEMINFO_TYPE
3 => ITEMINFO_MAXCHANCE
4 => ITEMINFO_SEX
5 => ITEMINFO_LOC
6 => ITEMINFO_WEIGHT
7 => ITEMINFO_ATK
8 => ITEMINFO_DEF
9 => ITEMINFO_RANGE
10 => ITEMINFO_SLOTS
11 (Subtype, for weapons and ammunitions) => ITEMINFO_SUBTYPE
11 (ViewSprite, for other item types) => ITEMINFO_VIEWSPRITE (NOT AVAILABLE YET)
12 => ITEMINFO_ELV
13 => ITEMINFO_WLV
14 => ITEMINFO_VIEWID
15 => ITEMINFO_MATK (NOT AVAILABLE YET - this was documented but never implemented)
Calls to getiteminfo() and setiteminfo() have been replaced with the
newly introduced constants. Other constants (such as W_ weapon subtypes)
in related code have been replaced as well, to improve code readability.
This fixes an issue in the Eden Tutorial script "Tutorial Goal", where
ITEMINFO_ATK was accidentally used instead of ITEMINFO_WEIGHT.
Note: calls to getiteminfo or setiteminfo with numeric type arguments in
third party scripts must be replaced with the respective constants. The
use of numeric literals is no longer recommended, and those values may
change in the future without notice. See the getiteminfo documentation
for details.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
Removed the usage of deprecated command goto from npc scripts (except custom folder)
|
|
folder).
Signed-off-by: Ragno <ragno@atlantis-ro.net>
|
|
Update Eden Quest script
|
|
This removes the remaining unsupported symbols (despite they being
official names) in AegisNames: The apostrophe (`'`) sign is suppressed.
The full replacement rules (cumulative with the step 1 commit) are thus:
- Any apostrophe is suppressed.
- Any non-`[A-Za-z0-9_]` character is replaced with an underscore (`_`).
- If the replaced symbol is at a word boundary (beginning or end of the
string, or next to another underscore), it is suppressed instead.
- If the replacement causes an AegisName conflict, underscores are
appended appropriately.
Signed-off-by: Haru <haru@dotalux.com>
|
|
This commit just propagates the AegisName changes to the pre-re database
and to the (re) scripts.
Two issues are fixed as a side-effect:
- The ghost_palace script was referring the non-existing constant(s):
Thanatos_Two-Handed_Staff == (Thanatos_Two) - (Handed_Staff) == 0.
Paired with the script engine's inability to differentiate between
constants and player variables, that produced a very subtle issue.
- The item RAG203 is sold by a NPC (Rebellion Weapon Vending). Due to a
pair of swapped AegisName constants (RAG203 and RAG203_), the slotted
version was sold by the NPC instead of hte non-slotted one (the issue
was actually fixed in the previous commit, although the description of
the fix is here - these two commits are only split for legibility
purposes but they're to be considered indivisible).
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Fix classes checking (https://github.com/HerculesWS/Hercules/issues/1173)
- Update and remove redundant script
|
|
|
|
added missing mapflags for c_tower2_ and c_tower3_
|
|
|
|
- NPC_NAME for the whole npc name including hidden part
- NPC_NAME_VISIBLE for the visible part of the npc name
- NPC_NAME_HIDDEN for the hidden part of the npc name
- NPC_NAME_UNIQUE for the npc unique name
- NPC_MAP for npc map
|
|
- added mobs and (updated) skills
- added quests_aldebaran.txt
- iro dialogues
- all items are already in available in item_db.conf
- maps are already available in mapcache, index and .conf
- Updated item effect for Pocket_Watch_ and Pocket_Watch__, and their
combo with Memorize_Book and Pocket_Watch__
Closes #1389 as merged
Signed-off-by: Haru <haru@dotalux.com>
|
|
-NPC checked for wrong quest and therefore didn't do anything on that part of the quest.
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The generated translation file now loads cleanly without encoding conversion errors
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
Script CleanUp Phase 2
|
|
Eden Quest will now give EXP for JobLevel < 50 and JobLevel > 69
|
|
|
|
Eden quest were giving wrong equipments.
|
|
Removed some comments from eden quests
|
|
Fixed #1084
|
|
Update some coordinates of the npc's in morroc.
Added Marrol Battle Recruiter and Mr. Smile npc in morroc town.
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
replace using Notepad++
|
|
Follow-up to dbe5f2237cada6a261e297b60857dc305860a88d
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
- Now including GPL-compliant license/copyright info
- Restored some missing copyrights
- Quest scripts folders
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
- Follow-up to 3bd77ffc0daca508352834add828766490075aee
- The names were too generic (not namespaced), and were easily clashing
with custom (and potential future official) constants or variables.
- Constants are now prefixed with a 'GETTIME_' namespace:
- GETTIME_SECOND
- GETTIME_MINUTE
- GETTIME_HOUR
- GETTIME_WEEKDAY
- GETTIME_DAYOFMONTH
- GETTIME_MONTH
- GETTIME_YEAR
- GETTIME_DAYOFYEAR
- Fixed some excessive (and some times incorrect) parentheses in
various scripts using gettime().
- Updated documentation.
Signed-off-by: Haru <haru@dotalux.com>
|
|
constant for gettime( <type> )
constant for Weekday and Month.
|
|
Changed NPC id->constant in eden_iro.txt
Fixed case warning errors on may_hats.txt and mushroom_event.txt
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Added missing Energy Crystal Book item_db.
Removed wrong equipments list for exchange.
Based on http://irowiki.org/wiki/Eden_Group_Crystal_Synthesis
|
|
|
|
- Replaced leftover sprite IDs with constants
- Corrected some NPC facing directions (in modulo 8)
- Follow-up to 7b50fce0f62961b0228e6919562efcfe33e7fbca
|
|
- Replaced leftover sprite IDs with constants
- Corrected some NPC facing directions (in modulo 8)
|
|
https://github.com/HerculesWS/Hercules/issues/595
|
|
Based on the rAthena version, improved and cleaned up.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Credits:rAthena
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
Fixes #538
Signed-off-by: Haru <haru@dotalux.com>
|
|
This reverts commit 9f9ec84fda9124d0927e99ca52a423a2b468c722.
Signed-off-by: Haru <haru@dotalux.com>
|