summaryrefslogtreecommitdiff
path: root/npc/jobs
AgeCommit message (Collapse)AuthorFilesLines
2018-11-13Remove type argument from buildin_getnpcid.EyesOfAHawk1-1/+1
2017-06-03convert specialeffect calls with strings to use GIDgumi1-1/+1
2017-04-23Merge pull request #1548 from AtlantisRO/goto_removalRidley1-32/+30
Removed the usage of deprecated command goto from npc scripts (except custom folder)
2017-04-05remove wrong warp in wizard job questAsheraf1-1/+0
2017-03-16Fix wrong order of dialogue at Crusader Jobchange Quest. (#1637)skyleo1-14/+22
Fix wrong order of dialogue at Crusader Jobchange Quest.
2017-03-08Removed the usage of deprecated command goto from npc scripts (except custom ↵AtlantisRO1-32/+30
folder). Signed-off-by: Ragno <ragno@atlantis-ro.net>
2016-11-20Replaced some unsupported symbols in AegisNames (step 2)Haru7-24/+24
This removes the remaining unsupported symbols (despite they being official names) in AegisNames: The apostrophe (`'`) sign is suppressed. The full replacement rules (cumulative with the step 1 commit) are thus: - Any apostrophe is suppressed. - Any non-`[A-Za-z0-9_]` character is replaced with an underscore (`_`). - If the replaced symbol is at a word boundary (beginning or end of the string, or next to another underscore), it is suppressed instead. - If the replacement causes an AegisName conflict, underscores are appended appropriately. Signed-off-by: Haru <haru@dotalux.com>
2016-10-16Change *getcharid to use constantsAsheraf1-1/+1
2016-09-02change *strcharinfo to use constantsAsheraf18-306/+306
2016-08-29*strnpcinfo now uses constantsAsheraf1-1/+1
- NPC_NAME for the whole npc name including hidden part - NPC_NAME_VISIBLE for the visible part of the npc name - NPC_NAME_HIDDEN for the hidden part of the npc name - NPC_NAME_UNIQUE for the npc unique name - NPC_MAP for npc map
2016-07-10Fixed a typo in the alchemist.txt scriptHaru1-3/+3
Signed-off-by: Haru <haru@dotalux.com>
2016-06-26Fixed a typo in the last edit of alchemist.txt (missing comma)Haru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
2016-06-25Replaced _() with _$() in scripts, where appropriateHaru1-8/+8
Signed-off-by: Haru <haru@dotalux.com>
2016-06-25Proof-of-concept best scripting practices for HULD (draft)Haru1-102/+159
- Replaced hardcoded item names with getitemname() Only the npc/jobs/2-2/alchemist.txt script was modified, as a proof of concept. Signed-off-by: Haru <haru@dotalux.com>
2016-06-25Proof-of-concept best scripting practices for HULDHaru1-676/+776
- `mes` strings are split by sentences: each string contains one and only one sentence. Line-break hints are specified with \r (and for readability the string is split in multiple lines with parse-time concatenation, without using the '+' operator) - When sentences need concatenation (variable names or values), sprintf is used, so that the generated translatable string is still one and only one. The `_()` macro is used inside sprintf, to mark the string as translatable. - `select()` / `prompt()` entries are in separate entries, separated by commas, where possible (it makes their translation easier) - This makes it easier to translate NPCs to languages with different sentence ordering (and with longer or shorter sentences). In the generated .pot, sentecnes will no longer span across several strings. Only the npc/jobs/2-2/alchemist.txt script was modified, as a proof of concept. Signed-off-by: Haru <haru@dotalux.com>
2016-04-22[Wizard Jobquest] Fixed getting stuck when failing 2nd Wave of Earth Room or ↵skyleo1-2/+2
1st Wave of Fire Room.
2016-02-29Replaced the SEX_FEMALE/SEX_MALE constants to scripts, where appropriateEmistry16-60/+66
2016-02-22Payon NPC UpdateJedzkie1-3/+3
- Change the coordinate of Taekwon Job Changer 'Phoenix' from payon to payon_in01 - Change the facing position of Repairman - Change the selling items of Tool Dealer and Pet Groomer in RENEWAL - Add PRE-RENEWAL Tool Dealer and Pet Groomer. - Change the coordinates of some warps - Change the coordinate of Guide in payon - Change the coordinate of Helm of Angel and Deviruchi Cap quest npc
2016-01-16Script Standardization: changed select format in jobs folderDastgir33-600/+600
2015-12-31Replaced leftover -1 view IDs with FAKE_NPCHaru9-563/+563
Signed-off-by: Haru <haru@dotalux.com>
2015-12-31Replace -1,{ with FAKE_NPC,{AnnieRuru9-26/+26
replace using Notepad++
2015-12-18ItemID to Constant: instances/jobs FolderDastgir20-274/+274
2015-12-15Standardized header in scripts (part 5)Haru33-941/+1252
- Now including GPL-compliant license/copyright info - Restored some missing copyrights - Jobs scripts folders Signed-off-by: Haru <haru@dotalux.com>
2015-09-25More aggressive whitespace cleanup. Follow up to 51329e6Haru7-9/+2
Signed-off-by: Haru <haru@dotalux.com>
2015-07-05Removed blank text contents in NPC scripts.Emistry2-6/+6
http://herc.ws/board/tracker/issue-8677-lots-of-blank-things-in-scripts/
2015-06-25Updated Blacksmith job quest with some extra conditions.Dastgir1-7/+20
Reference: rathena/rathena@1d64b8f9e1d95f40778a625c10735a10d9e6f5db (part) Signed-off-by: Haru <haru@dotalux.com>
2015-05-08Replaced checkre() calls with constantsHaru5-42/+32
Signed-off-by: Haru <haru@dotalux.com>
2015-04-19Added Kagero / Oboro Quest.Taylor Locke1-3/+4
2014-11-02Replaced 'set' with direct assignment where applicable (common folder)Haru32-925/+925
Signed-off-by: Haru <haru@dotalux.com>
2014-10-30Deprecated checkriding and setriding commandsHaru1-1/+1
Replaced their use in scripts with checkmount and setmount, respectively. Signed-off-by: Haru <haru@dotalux.com>
2014-10-28Removed use of 'checkquest' from scripts (common folder)Haru14-66/+68
Signed-off-by: Haru <haru@dotalux.com>
2014-10-24Renamed ismounting, setmounting, @mount2Haru1-1/+1
To avoid ambiguity: - The script command ismounting is now hascashmount - The script command setmounting is now setcashmount - The at-command @mount2 is now @cashmount Signed-off-by: Haru <haru@dotalux.com>
2014-08-23change rand(1) to rand(2)TungSinpei2-2/+2
2014-06-23Fixed issue with Biochemist that resulted in never regaining Bioethics.Taylor Locke1-4/+5
2014-05-20Corrected Bioethics quest checks in the Biochemist NPCHaru1-58/+53
- As of 4ea6d474 (almost 7 years ago!) the correct check is bioeth==13, rather than MISC_QUEST&64. Special thanks to ossi0110. - Minor tweaks to the script to match Hercules standards. Signed-off-by: Haru <haru@dotalux.com>
2014-05-17Added missing changequest commands on Alchemist Job Change Quest.Taylor Locke1-2/+7
2014-05-13Removed trailing whitespace (scripts)Haru12-37/+37
Signed-off-by: Haru <haru@dotalux.com>
2014-05-13Fixed some charset issuesHaru1-0/+2
- Fixed files with mixed character set or invalid CP949 characters. - Uncommented '#music' script in the_sign_quest.txt (now the soundeffect filename should be fixed). - Added a note to the header of CP949 files not to read or save them as UTF8, since it'd break their encoding. It should be safe enough to read them as EUC-KR if your text editor doesn't offer CP949 as an option. - Added FIXME notes about untranslated strings in assassin_skills.txt and WolfchevLaboratory.txt. Signed-off-by: Haru <haru@dotalux.com>
2013-12-07Fixed several incorrect script labels and eventsHaru3-5/+5
Signed-off-by: Haru <haru@dotalux.com>
2013-12-01Corrected some accidentally renamed NPCsHaru1-1/+1
- Fixes bugreport:7860, thanks to SSky http://hercules.ws/board/tracker/issue-7860-eden-mission-board-npc-name/ - Follow-up to 6309eba Signed-off-by: Haru <haru@dotalux.com>
2013-11-30Re-commit of 4faa0ec9df7067cee3eb1c1953fccc6c2f842179Taylor Locke8-11/+11
Cleaned up Zeny manipulation in scripts. - It is now finally safe to re-commit. - Removed some unwanted parts of the original commit, that broke the character set in some scripts. [Haru] - Corrected spacing in some edited lines. [Haru]
2013-11-28Revert "Cleaned up Zeny manipulation in scripts."Haru8-11/+11
Reverted due to a serious regression. I'll commit this again once I fixed the issue in the script engine. Sorry for the inconvenience. This reverts commit 4faa0ec9df7067cee3eb1c1953fccc6c2f842179. Signed-off-by: Haru <haru@dotalux.com>
2013-11-25Cleaned up Zeny manipulation in scripts.Taylor Locke8-11/+11
2013-11-10Follow-up to 857bdc4f98be6cd1e185a24565d6b6b54752b9b4Haru5-20/+20
- Consolidated case in variables, labels, constants. Signed-off-by: Haru <haru@dotalux.com>
2013-11-09Consolidated commands called in scripts to their lowercase versionHaru1-2/+2
- Added a note about variables and command scripts case sensitivity. Even though the engine still accepts variable, function and command names in a case insensitive way, it is discouraged to rely on such behavior. Please update your custom scripts as soon as possible. Signed-off-by: Haru <haru@dotalux.com>
2013-11-08Added support for monster spritename constantsHaru1-3/+3
- Follow-up to 124ab2a1cdb344f24170a4d91f7000ebabf39b40 - Replaced numeric IDs in NPC definitions and setnpcdisplay calls with the appropriate constants - Made possible thanks to Ind Signed-off-by: Haru <haru@dotalux.com>
2013-10-28Added ability to use constants instead of sprite IDs for NPCs. Converted all ↵Kisuka33-176/+176
npcs to use this.
2013-10-24Update to last rAthena npc.Michieru33-557/+526
Fix some typos change sc_bleeding to -> sc_blooding Updated RE EXP for quests_brasilis.txt
2013-03-20-Part 2 of 'the great commit', all credits to L0ne_W0lfStreusel1-3/+12
-NPC updates mostly Izlude related
2013-02-04Merged some commits from rAthena.Matheus Macabu1-0/+1