Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Replacements are as follows:
0 => ITEMINFO_BUYPRICE
1 => ITEMINFO_SELLPRICE
2 => ITEMINFO_TYPE
3 => ITEMINFO_MAXCHANCE
4 => ITEMINFO_SEX
5 => ITEMINFO_LOC
6 => ITEMINFO_WEIGHT
7 => ITEMINFO_ATK
8 => ITEMINFO_DEF
9 => ITEMINFO_RANGE
10 => ITEMINFO_SLOTS
11 (Subtype, for weapons and ammunitions) => ITEMINFO_SUBTYPE
11 (ViewSprite, for other item types) => ITEMINFO_VIEWSPRITE (NOT AVAILABLE YET)
12 => ITEMINFO_ELV
13 => ITEMINFO_WLV
14 => ITEMINFO_VIEWID
15 => ITEMINFO_MATK (NOT AVAILABLE YET - this was documented but never implemented)
Calls to getiteminfo() and setiteminfo() have been replaced with the
newly introduced constants. Other constants (such as W_ weapon subtypes)
in related code have been replaced as well, to improve code readability.
This fixes an issue in the Eden Tutorial script "Tutorial Goal", where
ITEMINFO_ATK was accidentally used instead of ITEMINFO_WEIGHT.
Note: calls to getiteminfo or setiteminfo with numeric type arguments in
third party scripts must be replaced with the respective constants. The
use of numeric literals is no longer recommended, and those values may
change in the future without notice. See the getiteminfo documentation
for details.
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
|
|
|
|
This removes the remaining unsupported symbols (despite they being
official names) in AegisNames: The apostrophe (`'`) sign is suppressed.
The full replacement rules (cumulative with the step 1 commit) are thus:
- Any apostrophe is suppressed.
- Any non-`[A-Za-z0-9_]` character is replaced with an underscore (`_`).
- If the replaced symbol is at a word boundary (beginning or end of the
string, or next to another underscore), it is suppressed instead.
- If the replacement causes an AegisName conflict, underscores are
appended appropriately.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Fix cases were player were executed
|
|
On Aegis players set their HP to 0 by script are still alive. Since we don't want to copy this, scripts that set HP to 0 and expects the player to stay alive are changed.
Additionally some scripts where changed where the HP were set to 1% instead to 1 HP and also the percentheal -100 with intended death set into close2. In megingard_seal.txt a end; was missing.
|
|
|
|
|
|
- NPC_NAME for the whole npc name including hidden part
- NPC_NAME_VISIBLE for the visible part of the npc name
- NPC_NAME_HIDDEN for the hidden part of the npc name
- NPC_NAME_UNIQUE for the npc unique name
- NPC_MAP for npc map
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
Script CleanUp Phase 2
|
|
|
|
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
replace using Notepad++
|
|
Follow-up to dbe5f2237cada6a261e297b60857dc305860a88d
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
|
|
- Follow-up to 3bd77ffc0daca508352834add828766490075aee
- The names were too generic (not namespaced), and were easily clashing
with custom (and potential future official) constants or variables.
- Constants are now prefixed with a 'GETTIME_' namespace:
- GETTIME_SECOND
- GETTIME_MINUTE
- GETTIME_HOUR
- GETTIME_WEEKDAY
- GETTIME_DAYOFMONTH
- GETTIME_MONTH
- GETTIME_YEAR
- GETTIME_DAYOFYEAR
- Fixed some excessive (and some times incorrect) parentheses in
various scripts using gettime().
- Updated documentation.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The commands queueadd, queueremove, queueopt, queuedel and qiclear
now all return true (success) or false (failure). - Taken/extended
from AnnieRuru's PR #847.
- The constants HQO_OnDeath, HQO_OnLogOut, HQO_OnMapChange were renamed
to QUEUEOPT_DEATH, QUEUEOPT_LOGOUT, QUEUEOPT_MAPCHANGE respectively.
- The name of the variable @QMapChangeTo$ used during the
QUEUEOPT_MAPCHANGE event has been renamed to @Queue_Destination_Map$.
Signed-off-by: Haru <haru@dotalux.com>
|
|
constant for gettime( <type> )
constant for Weekday and Month.
|
|
Changed NPC id->constant in eden_iro.txt
Fixed case warning errors on may_hats.txt and mushroom_event.txt
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
Updated warper. Changed close; to end;
|
|
|
|
window a close; is not needed
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Prevent the NPC to show rental items when players try to bind an items.
|
|
|
|
|
|
Special thanks to Ridley8819
Signed-off-by: Haru <haru@dotalux.com>
|
|
Replaced their use in scripts with checkmount and setmount,
respectively.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Replaced their use in scripts with checkmount and setmount,
respectively.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Replaced their use in scripts with checkmount and setmount,
respectively.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
To avoid ambiguity:
- The script command ismounting is now hascashmount
- The script command setmounting is now setcashmount
- The at-command @mount2 is now @cashmount
Signed-off-by: Haru <haru@dotalux.com>
|
|
* Disguise Event was having Renewal and Pre-Renewal Monster Constant in an array without any checks
|
|
there is a well known bug of this script (I've known this since eathena actually)
when you are certainly going to lose the bet, log out immediately while the card are still dealt
and you don't get zeny deletion
thx to Holiness to bring this up again
|
|
deletion bug
https://github.com/rathena/rathena/commit/3c24f45
|
|
http://hercules.ws/board/tracker/issue-8248-job-master-bug/
- Job Master now properly resets Novice Basic Skill upon job change into Baby Novice.
- Sparkles and thanks to @Ridley8819 for pointing out the issue.
|
|
- Improved legibility (renamed variables, replaced numbers with
constants.
- Changed syntax to match Hercules standards.
- Fixed status point exploit upon Baby Novice job change.
- Special thanks to bgamez23.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|