Age | Commit message (Collapse) | Author | Files | Lines |
|
Item database bug fixes.
|
|
http://hercules.ws/board/tracker/issue-7906-compiling-error-latest/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
|
|
Made Possible Thanks to the Woonderful Haruna! <3
Commit also fixes an inconsistency in the ERS, where it'd start with clear memory but would use garbage upon resizing, also implements a new ERS option that clears entries as soon as pass by ers_free, so that they'll be all shinny for when ers_alloc reuses them.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Thanks to Haruna! <3
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Fixes a series of "left-hand operand of comma expression has no
effect" in nullpo checks.
- Special thanks to ossi0110.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
This adds an Xcode project file (for those who develop on OS X) and fixes several - potential or real - issues we detected thanks to its more strict warnings settings. It also updates the unix build script with similar warning settings.
|
|
- Fixed some warnings we had missed.
- Improved -W cflag detection routines.
- Only use -Wshadow if it's actually useful.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- They are now on par with the Xcode project (and similar to the MSVC
ones) - this will make it easier to notice issues before committing in
future.
- If this causes, on your system, warnings that we didn't detect, please
let us know!
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Warnings detected thanks to Xcode's compiler settings (more strict by
default) and clang, warnings mostly but not only related to data sizes
on 64 bit systems, that were silenced until now by very lax compiler
settings.
- This also decreases by a great deal the amount of warnings produced by
MSVC in x64 mode (for the adventurous ones who tried that)
- Also fixed (or silenced in case of false positives) the potential
issues pointed out by the (awesome) clang static analyzer.
- Patch co-produced with Ind, I'm merging and committing in his place!
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Added Assert_ret, Assert_retv, Assert_retb, Assert_retr, working
similarly to the corresponding nullpo_ functions.
- Moved Assert-related macros to nullpo.h, since they share some
functions.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Removed unused, nonportable nullpo checks with formatted message
(related: eAthena r15245)
- Converted nullpo_chk to a macro, to make it easier on the llvm static
analyzer.
- Added more details to the nullpo_info reports (related: eAthena
r15246)
- Ensured that the nullpo check macros evaluate their pointer argument
once and only once, so that it's safe to use with expressions that
assign values or have side-effects.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- No functional changes. That's just the correct OS X file extension for
dynamic libs.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Special Thanks to Mhalicot.
Signed-off-by: shennetsind <ind@henn.et>
|
|
equivalent macros
Because 2/3 jumps to perform such a operation is just awful
Signed-off-by: shennetsind <ind@henn.et>
|
|
Because 2 jumps to get a single value is just awful.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Fixed couple intif.c interface members being called outside the interface
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: shennetsind <ind@henn.et>
|
|
|
|
#5608: Proper groups for Lotto Boxes
#5625: Missing function for Dungeon Teleport Scroll II
#5612: Missing skills
|
|
and thus doesn't cause confusion (and it wasn't loop-related anyway).
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Special Thanks to Haru!
Signed-off-by: shennetsind <ind@henn.et>
|
|
|
|
Special Thanks to Haru
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Follow-up to 44c33fda3614d588e6bf6cee1cf884e98f1531f0.
- Also fixed some incorrect va_end calls that came up while debugging.
- Special thanks to Ind for his help debugging the problem.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Enabled plugin access to mapindex interface
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
|
|
which was broken 5 years ago in 13106, special Thanks to karazu, Angelmelody and kyeme.
Signed-off-by: shennetsind <ind@henn.et>
|
|
fixed as in, it now skips the thing entirely, matching official behavior and no longer affected by job-specific modifiers.
Thanks to Yommy.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Should fixe bugreport:7888, thanks to rosfus
http://hercules.ws/board/tracker/issue-7888-some-issue-crush-my-mapserver
- Special thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Fixed a memory leak (bugreport:7885), thanks to rosfus
http://hercules.ws/board/tracker/issue-7885-memory-leaks-found-at-20131205-20h31m31s-rev-13617/
Signed-off-by: Haru <haru@dotalux.com>
|
|
guild storage would remain locked when the operation failed, now it unlocks regardless of success.
Special Thanks to GrumpyPanda
http://hercules.ws/board/tracker/issue-7879-guild-storage-bug/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
- Removed duplicate code shared between script_hp_add and
script_parse_builtin.
- Improved error handling in script_hp_add to be on par with the
script_parse_builtin version.
- Added script->add_builtin function, providing a hooking point for
plugins (i.e. text editor syntax definition generators) to obtain the
builtin commands list.
- Special thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- It is now possible to build a plugin without adding it to the
Makefile, by using 'make plugin.my_plugin_name'.
- To have it built through 'make all' or 'make plugins', it is still
necessary to add it to the Makefile, as before.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Fix part 2 of issue 7841
|
|
- Case-sensitive AegisName and Sprite ID lookups are now optional,
controlled by the case_sensitive_aegisnames battle config flag (you
can set it to "no" to restore the case insensitive behavior.)
- Special thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Special Thanks to Megasantos, Beret.
Follows up 098dbcf672e04657553b9f1629550e6bc8771af3
http://hercules.ws/board/tracker/issue-7883-reloaditemdb/
Signed-off-by: shennetsind <ind@henn.et>
|
|
|