Replaced some of the hardcoded values with constants (misc)

- Replaced several hardcoded values with the appropriate enums.
- Added documentation for some hardcoded values that haven't been
  replaced by enums (yet)
- Minor code legibility improvements.

Signed-off-by: Haru <haru@dotalux.com>

1 files changed, 41 insertions, 44 deletions

diff --git a/src/common/showmsg.h b/src/common/showmsg.h
index 48e763c25..0624f1786 100644
--- a/src/common/showmsg.h
+++ b/src/common/showmsg.h
@@ -23,58 +23,55 @@
 // \033[0m : reset color parameter
 // \033[1m : use bold for font
 
-#define CL_RESET	"\033[0m"
-#define CL_CLS		"\033[2J"
-#define CL_CLL		"\033[K"
+#define CL_RESET      "\033[0m"
+#define CL_CLS        "\033[2J"
+#define CL_CLL        "\033[K"
 
 // font settings
-#define CL_BOLD		"\033[1m"
-#define CL_NORM		CL_RESET
-#define CL_NORMAL	CL_RESET
-#define CL_NONE		CL_RESET
-// foreground color and bold font (bright color on windows)
-#define CL_WHITE	"\033[1;37m"
-#define CL_GRAY		"\033[1;30m"
-#define CL_RED		"\033[1;31m"
-#define CL_GREEN	"\033[1;32m"
-#define CL_YELLOW	"\033[1;33m"
-#define CL_BLUE		"\033[1;34m"
-#define CL_MAGENTA	"\033[1;35m"
-#define CL_CYAN		"\033[1;36m"
+#define CL_BOLD       "\033[1m"
+#define CL_NORM       CL_RESET
+#define CL_NORMAL     CL_RESET
+#define CL_NONE       CL_RESET
 
 // background color
-#define CL_BG_BLACK		"\033[40m"
-#define CL_BG_RED		"\033[41m"
-#define CL_BG_GREEN		"\033[42m"
-#define CL_BG_YELLOW	"\033[43m"
-#define CL_BG_BLUE		"\033[44m"
-#define CL_BG_MAGENTA	"\033[45m"
-#define CL_BG_CYAN		"\033[46m"
-#define CL_BG_WHITE		"\033[47m"
+#define CL_BG_BLACK   "\033[40m"
+#define CL_BG_RED     "\033[41m"
+#define CL_BG_GREEN   "\033[42m"
+#define CL_BG_YELLOW  "\033[43m"
+#define CL_BG_BLUE    "\033[44m"
+#define CL_BG_MAGENTA "\033[45m"
+#define CL_BG_CYAN    "\033[46m"
+#define CL_BG_WHITE   "\033[47m"
 // foreground color and normal font (normal color on windows)
-#define CL_LT_BLACK		"\033[0;30m"
-#define CL_LT_RED		"\033[0;31m"
-#define CL_LT_GREEN		"\033[0;32m"
-#define CL_LT_YELLOW	"\033[0;33m"
-#define CL_LT_BLUE		"\033[0;34m"
-#define CL_LT_MAGENTA	"\033[0;35m"
-#define CL_LT_CYAN		"\033[0;36m"
-#define CL_LT_WHITE		"\033[0;37m"
+#define CL_LT_BLACK   "\033[0;30m"
+#define CL_LT_RED     "\033[0;31m"
+#define CL_LT_GREEN   "\033[0;32m"
+#define CL_LT_YELLOW  "\033[0;33m"
+#define CL_LT_BLUE    "\033[0;34m"
+#define CL_LT_MAGENTA "\033[0;35m"
+#define CL_LT_CYAN    "\033[0;36m"
+#define CL_LT_WHITE   "\033[0;37m"
 // foreground color and bold font (bright color on windows)
-#define CL_BT_BLACK		"\033[1;30m"
-#define CL_BT_RED		"\033[1;31m"
-#define CL_BT_GREEN		"\033[1;32m"
-#define CL_BT_YELLOW	"\033[1;33m"
-#define CL_BT_BLUE		"\033[1;34m"
-#define CL_BT_MAGENTA	"\033[1;35m"
-#define CL_BT_CYAN		"\033[1;36m"
-#define CL_BT_WHITE		"\033[1;37m"
+#define CL_BT_BLACK   "\033[1;30m"
+#define CL_BT_RED     "\033[1;31m"
+#define CL_BT_GREEN   "\033[1;32m"
+#define CL_BT_YELLOW  "\033[1;33m"
+#define CL_BT_BLUE    "\033[1;34m"
+#define CL_BT_MAGENTA "\033[1;35m"
+#define CL_BT_CYAN    "\033[1;36m"
+#define CL_BT_WHITE   "\033[1;37m"
 
-#define CL_WTBL			"\033[37;44m"	// white on blue
-#define CL_XXBL			"\033[0;44m"	// default on blue
-#define CL_PASS			"\033[0;32;42m"	// green on green
+// foreground color and bold font (bright color on windows)
+#define CL_WHITE   CL_BT_WHITE
+#define CL_GRAY    CL_BT_BLACK
+#define CL_RED     CL_BT_RED
+#define CL_GREEN   CL_BT_GREEN
+#define CL_YELLOW  CL_BT_YELLOW
+#define CL_BLUE    CL_BT_BLUE
+#define CL_MAGENTA CL_BT_MAGENTA
+#define CL_CYAN    CL_BT_CYAN
 
-#define CL_SPACE		"           "	// space equivalent of the print messages
+#define CL_SPACE   "           "   // space aquivalent of the print messages
 
 enum msg_type {
 	MSG_NONE,