diff options
| -rw-r--r-- | src/resources/iteminfo.cpp | 6 | ||||
| -rw-r--r-- | src/resources/iteminfo.h | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/resources/iteminfo.cpp b/src/resources/iteminfo.cpp index 92df520ea..4ec5d81f9 100644 --- a/src/resources/iteminfo.cpp +++ b/src/resources/iteminfo.cpp @@ -84,7 +84,7 @@ const std::string &ItemInfo::getSprite(const Gender gender, } else { - static const std::string empty(""); + static const std::string empty; std::map<int, std::string>::const_iterator i = mAnimationFiles.find(static_cast<int>(gender) + race * 4); @@ -97,7 +97,7 @@ const std::string &ItemInfo::getSprite(const Gender gender, } } -void ItemInfo::setAttackAction(std::string attackAction) +void ItemInfo::setAttackAction(const std::string &attackAction) { if (attackAction.empty()) mAttackAction = SpriteAction::ATTACK; // (Equal to unarmed animation) @@ -148,7 +148,7 @@ std::map<int, int> *ItemInfo::addReplaceSprite(const int sprite, return &it->second; } -void ItemInfo::setColorsList(std::string name) +void ItemInfo::setColorsList(const std::string &name) { if (name.empty()) { diff --git a/src/resources/iteminfo.h b/src/resources/iteminfo.h index 380624b7b..e5b6f96b8 100644 --- a/src/resources/iteminfo.h +++ b/src/resources/iteminfo.h @@ -178,7 +178,7 @@ class ItemInfo final const std::string &getSprite(const Gender gender, const int race) const A_WARN_UNUSED; - void setAttackAction(std::string attackAction); + void setAttackAction(const std::string &attackAction); // Handlers for seting and getting the string // used for particles when attacking @@ -275,7 +275,7 @@ class ItemInfo final std::string getDyeColorsString(const int color) const A_WARN_UNUSED; - void setColorsList(std::string name); + void setColorsList(const std::string &name); bool isHaveColors() const A_WARN_UNUSED { return !mColorList.empty(); } |