Return a const & from NameMap to avoid potential deep copies

When I introduced NameMap it was only used with pointers, but now it is
also used with std::string so it probably makes sense to keep a default-
constructed value around so that a reference can be returned rather than
a copy.

NameMap::find was renamed to NameMap::value to make it more clear that
it doesn't return an iterator, like std::map::find.

Reviewed-by: Yohann Ferreira
Reviewed-by: Ben Longbons

1 files changed, 1 insertions, 1 deletions

diff --git a/src/game-server/skillmanager.cpp b/src/game-server/skillmanager.cpp
index be6eef4b..0ed327b1 100644
--- a/src/game-server/skillmanager.cpp
+++ b/src/game-server/skillmanager.cpp
@@ -171,7 +171,7 @@ unsigned int SkillManager::getId(const std::string& set,
                                         const std::string &name) const
 {
     std::string key = utils::toLower(set) + "_" + utils::toLower(name);
-    SkillInfo *skillInfo = mNamedSkillsInfo.find(key);
+    SkillInfo *skillInfo = mNamedSkillsInfo.value(key);
     return skillInfo ? skillInfo->id : 0;
 }