diff options
| author | Thorbjørn Lindeijer <thorbjorn@lindeijer.nl> | 2011-03-17 00:42:38 +0100 |
|---|---|---|
| committer | Thorbjørn Lindeijer <thorbjorn@lindeijer.nl> | 2011-03-17 00:57:16 +0100 |
| commit | 9344a79233882ac278b3812b91b6edf874ef5d16 (patch) | |
| tree | e5bd324104a9d8dcf1839de8a880845f8739a37a /src/game-server/attributemanager.cpp | |
| parent | 0e24b15a386d45f43cea76c1b8ad744728a3190e (diff) | |
| download | manaserv-9344a79233882ac278b3812b91b6edf874ef5d16.tar.gz manaserv-9344a79233882ac278b3812b91b6edf874ef5d16.tar.bz2 manaserv-9344a79233882ac278b3812b91b6edf874ef5d16.tar.xz manaserv-9344a79233882ac278b3812b91b6edf874ef5d16.zip | |
Micro-optimizations related to std::string
* Rely on the fact that a std::string is empty by default
* Use std::string::empty() rather than comparing to ""
* Construct with std::string() rather than from ""
Reviewed-by: Bertram
Diffstat (limited to 'src/game-server/attributemanager.cpp')
| -rw-r--r-- | src/game-server/attributemanager.cpp | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/game-server/attributemanager.cpp b/src/game-server/attributemanager.cpp index d590a951..d6cdeae1 100644 --- a/src/game-server/attributemanager.cpp +++ b/src/game-server/attributemanager.cpp @@ -79,11 +79,14 @@ void AttributeManager::reload() if (xmlStrEqual(subnode->name, BAD_CAST "modifier")) { std::string sType = utils::toUpper( - XML::getProperty(subnode, "stacktype", "")); + XML::getProperty(subnode, "stacktype", + std::string())); std::string eType = utils::toUpper( - XML::getProperty(subnode, "modtype", "")); + XML::getProperty(subnode, "modtype", + std::string())); std::string tag = utils::toUpper( - XML::getProperty(subnode, "tag", "")); + XML::getProperty(subnode, "tag", + std::string())); AT_TY pSType; AME_TY pEType; if (!sType.empty()) @@ -124,7 +127,7 @@ void AttributeManager::reload() mAttributeMap[id].second.push_back( AttributeInfoType(pSType, pEType)); std::string tag = XML::getProperty( - subnode, "tag", ""); + subnode, "tag", std::string()); if (!tag.empty()) mTagMap.insert( |