Age | Commit message (Collapse) | Author | Files | Lines |
|
Reviewed-by: o11c, bjorn, Bertram.
|
|
|
|
When including a file that already is included the client won't try to load it
again and end in an endless loop but stops parsing and logs and warning.
Reviewed-by: bjorn.
|
|
The background images are auto-centered.
Also, for Manaserv, a new background parameter has been
added in the box node of the equip.xml file
to specify the background image.
Note that the filename is relative to the gui theme
folder.
Reviewed-by: Thorbjorn Lindeijer
Resolves: TMW-Mantis #769.
|
|
The text is never set to an empty string,
especially not while the mouse is over the button.
The popup will be updated or hidden by mouseMoved anyway.
Reviewed-by: Thorbjorn Lindeijer
|
|
* Channel always has a ChannelTab, so need to check it for null
* Removed duplicate handling of 'topic' command
* No need to set Channel::mTab twice
Reviewed-by: Yohann Ferreira
|
|
This was due to a small logic error when setting the popup text.
Reviewed-by: Erik Schilling
|
|
Reviewed-by: Erik Schilling
|
|
Conflicts:
src/localplayer.cpp
src/net/manaserv/beinghandler.cpp
src/net/manaserv/charhandler.cpp
|
|
enforced by -std=c++0x
Reviewed-by: Thorbjørn Lindeijer
|
|
All cases of documentation for non-existing parameters are now fixed.
Also marked a few getters as 'const', removed some superfluous 'inline'
keywords and removed the unused 'forceQuantity' option from
ItemContainer.
Reviewed-by: Yohann Ferreira
|
|
Reviewed-by: bjorn.
|
|
This used to have an associated issue
but I just can't find it anymore.
Reviewed-by: Thorbjorn.
|
|
|
|
|
|
|
|
This reverts commit 06fff57500242c37890459ceffdfff2bdf19f6d6.
At least I tried :)
I'd like to have a clear discussion about how we could initialize
the skill and attributes values, without spamming the user.
|
|
This also happened when trying to reach a monster.
I didn't fix the pick up once the destination is reached
as the fix will be a little more complex.
|
|
This used to have an issue but i just can't find it anymore.
|
|
Resolves: Mana-Mantis #158.
|
|
|
|
|
|
|
|
Reviewed-by: Bertram.
|
|
Most noticeably I added the shortcut in a popup, even when
there are no images to the image buttons in the windowmenu.
|
|
|
|
|
|
|
|
|
|
This a good example of use for the new graphics and button
functionalities.
|
|
This to avoid cluttering the gui until Crush has the time
to fulfill his issue about those.
|
|
This is not updated once the keys are reassigned but it will
do the trick for now.
|
|
I had to adapt a bit the images given by Enchilado
to do that.
|
|
And falls back to the text based caption otherwise.
|
|
|
|
I also made the client able to keep the old behaviour,
and i changed the button api to not require the icon frames size
as it could easily guess them.
|
|
I added a use of it to the menu buttons.
|
|
Most noticeably i added the shortcut in a popup, even when
there are no images to the image buttons in the windowmenu.
|
|
|
|
Conflicts:
src/equipment.h
src/net/tmwa/inventoryhandler.h
|
|
|
|
* Use a symbol, VAR, instead of -1 for variable-length packets.
* Also change it's value to 1, so the length can be properly unsigned.
Note: A packet can't actually have length 1, since packet ID is 2 bytes.
* Use correct type (uint16_t) for packet id and length in more places.
* Avoid reading beyond the length of the array.
* Immediately parse variable length packets with length 4 (i.e. no body)
instead of waiting for another byte to arrive first.
Reviewed-by: Thorbjørn Lindeijer <thorbjorn@lindeijer.nl>
|
|
There was a bug here, which wouldn't surface if the copy was elided.
Fixed by using a move constructor.
Reviewed-by: Thorbjørn Lindeijer <thorbjorn@lindeijer.nl>
|
|
Reviewed-by: Thorbjørn Lindeijer <thorbjorn@lindeijer.nl>
|
|
Their name is a bit more clear with DEBUG prefix rather than MAP
prefix. They're already scoped in the Map class anyway.
MAP_NORMAL was changed to DEBUG_NONE to represent no debug flags.
Acked-by: Bertram
|
|
* Use a symbol, VAR, instead of -1 for variable-length packets.
* Also change it's value to 1, so the length can be properly unsigned.
Note: A packet can't actually have length 1, since packet ID is 2 bytes.
* Use correct type (uint16_t) for packet id and length in more places.
* Avoid reading beyond the length of the array.
* Immediately parse variable length packets with length 4 (i.e. no body)
instead of waiting for another byte to arrive first.
Reviewed-by: Thorbjørn Lindeijer <thorbjorn@lindeijer.nl>
|
|
There was a bug here, which wouldn't surface if the copy was elided.
Fixed by using a move constructor.
Reviewed-by: Thorbjørn Lindeijer <thorbjorn@lindeijer.nl>
|
|
Reviewed-by: Thorbjørn Lindeijer <thorbjorn@lindeijer.nl>
|
|
It has been fixed and be made adapted
to the being movement speed.
Now, for instance, the client sends 3x times less move calls
to the tA server, and roughly 20x times for the Manaserv's one.
Resolves: Mana-Mantis #346.
Reviewed-by: o11c.
|
|
Their name is a bit more clear with DEBUG prefix rather than MAP
prefix. They're already scoped in the Map class anyway.
MAP_NORMAL was changed to DEBUG_NONE to represent no debug flags.
Acked-by: Bertram
|