Fixed the memory issues with the pointers to item stat modifiers

It was a list of pointers to Stat instances that had long been popped
off the stack and deleted.

1 files changed, 7 insertions, 14 deletions

diff --git a/src/net/ea/generalhandler.cpp b/src/net/ea/generalhandler.cpp
index 477caf94..f9387184 100644
--- a/src/net/ea/generalhandler.cpp
+++ b/src/net/ea/generalhandler.cpp
@@ -59,7 +59,6 @@
 #include <list>
 
 Net::GeneralHandler *generalHandler;
-std::list<ItemDB::Stat*> stats;
 
 namespace EAthena {
 
@@ -88,19 +87,13 @@ GeneralHandler::GeneralHandler():
     handledMessages = _messages;
     generalHandler = this;
 
-    ItemDB::Stat stat;
-    stat.tag = "str"; stat.format = N_("Strength: %d");
-    stats.push_back(&stat);
-    stat.tag = "agi"; stat.format = N_("Agility: %d");
-    stats.push_back(&stat);
-    stat.tag = "vit"; stat.format = N_("Vitality: %d");
-    stats.push_back(&stat);
-    stat.tag = "int"; stat.format = N_("Intelligence: %d");
-    stats.push_back(&stat);
-    stat.tag = "dex"; stat.format = N_("Dexterity: %d");
-    stats.push_back(&stat);
-    stat.tag = "luck"; stat.format = N_("Luck: %d");
-    stats.push_back(&stat);
+    std::list<ItemDB::Stat> stats;
+    stats.push_back(ItemDB::Stat("str", N_("Strength: %d")));
+    stats.push_back(ItemDB::Stat("agi", N_("Agility: %d")));
+    stats.push_back(ItemDB::Stat("vit", N_("Vitality: %d")));
+    stats.push_back(ItemDB::Stat("int", N_("Intelligence: %d")));
+    stats.push_back(ItemDB::Stat("dex", N_("Dexterity: %d")));
+    stats.push_back(ItemDB::Stat("luck", N_("Luck: %d")));
 
     ItemDB::setStatsList(stats);
 }