Fixed a crash when trying to switch servers

Ownership of the charInfo global variable wasn't well defined. It was
being locked, unlocked and generally modified from a lot of places, and
somewhere in this mess it ended up crashing when switching servers.

Now the CharHandler instances, for eAthena and manaserv respectively,
own this list of characters. A new class, Net::Character wraps up the
slot index in combination with the player dummy. The list is passed on
to the CharSelectDialog each time it changes.

Both related and unrelated cleanups were made as well.

Reviewed-by: Jared Adams

1 files changed, 3 insertions, 3 deletions

diff --git a/src/localplayer.h b/src/localplayer.h
index d4aa258c..d9a56e34 100644
--- a/src/localplayer.h
+++ b/src/localplayer.h
@@ -105,7 +105,7 @@ class LocalPlayer : public Player
         /**
          * Constructor.
          */
-        LocalPlayer(int id= 65535, int job = 0, Map *map = NULL);
+        LocalPlayer(int id= 65535, int job = 0);
 
         /**
          * Destructor.
@@ -249,12 +249,12 @@ class LocalPlayer : public Player
         /**
          * Uses a character point to raise an attribute
          */
-        void raiseAttribute(size_t attr);
+        void raiseAttribute(int attr);
 
         /**
          * Uses a correction point to lower an attribute
          */
-        void lowerAttribute(size_t attr);
+        void lowerAttribute(int attr);
 
         void toggleSit();
         void emote(Uint8 emotion);