One step closer to the full movement system ready.

The LocalPlayer::nextTile() function has been sanitized and the movement
system has been fine tuned, but yet not optimized.
(Optimizations and riddance of 32 hard-coded value will come later.)

There is just one case left not handled correctly when the character
walked within one tile south-east of a blocking one and then
the player click north-west (through the blocking tile) on a walkable
location. Quite rare but still here.

1 files changed, 18 insertions, 14 deletions

diff --git a/src/being.cpp b/src/being.cpp
index d18fcb8f..b248ffa0 100644
--- a/src/being.cpp
+++ b/src/being.cpp
@@ -621,7 +621,7 @@ void Being::logic()
         const float nominalLength = dir.length();
 
         // When we've not reached our destination, move to it.
-        if (nominalLength > 1.0f && !mWalkSpeed.isNull())
+        if (nominalLength > 0.0f && !mWalkSpeed.isNull())
         {
             // The deplacement of a point along a vector is calculated
             // using the Unit Vector (â) multiplied by the point speed.
@@ -648,22 +648,26 @@ void Being::logic()
             if (mAction != WALK)
                 setAction(WALK);
 
-            // Update the player sprite direction
-            int direction = 0;
-            const float dx = std::abs(dir.x);
-            float dy = std::abs(dir.y);
+            // Update the player sprite direction.
+            // N.B.: We only change this if the distance is more than one pixel.
+            if (nominalLength > 1.0f)
+            {
+                int direction = 0;
+                const float dx = std::abs(dir.x);
+                float dy = std::abs(dir.y);
 
-            // When not using mouse for the player, we slightly prefer
-            // UP and DOWN position, especially when walking diagonally.
-            if (this == player_node && !player_node->isPathSetByMouse())
-                dy = dy + 2;
+                // When not using mouse for the player, we slightly prefer
+                // UP and DOWN position, especially when walking diagonally.
+                if (this == player_node && !player_node->isPathSetByMouse())
+                    dy = dy + 2;
 
-            if (dx > dy)
-                 direction |= (dir.x > 0) ? RIGHT : LEFT;
-            else
-                 direction |= (dir.y > 0) ? DOWN : UP;
+                if (dx > dy)
+                     direction |= (dir.x > 0) ? RIGHT : LEFT;
+                else
+                     direction |= (dir.y > 0) ? DOWN : UP;
 
-            setDirection(direction);
+                setDirection(direction);
+            }
         }
         else if (!mPath.empty())
         {